From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Pavel Machek <pavel@ucw.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Christoph Hellwig <hch@lst.de>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Kate Stewart <kstewart@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
Rob Herring <rob.herring@linaro.org>,
Jonas Oberg <jonas@fsfe.org>, Joe Perches <joe@perches.com>,
linux-xfs <linux-xfs@vger.kernel.org>,
Charlemagne Lasse <charlemagnelasse@gmail.com>,
Carmen Bianca Bakker <carmenbianca@fsfe.org>
Subject: Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses
Date: Sat, 25 Nov 2017 17:53:53 -0200 [thread overview]
Message-ID: <20171125175353.467b6e49@vento.lan> (raw)
In-Reply-To: <CA+55aFzPUi6En9tg+kZnDHQd3yuz5n99rDkk2tjAA=w4-K3uBg@mail.gmail.com>
Em Sat, 25 Nov 2017 09:30:46 -1000
Linus Torvalds <torvalds@linux-foundation.org> escreveu:
> On Sat, Nov 25, 2017 at 9:17 AM, Pavel Machek <pavel@ucw.cz> wrote:
> >
> > There's logical place in the comment, and it should look like this:
> >
> > /*
> > * Driver for SMSC USB3503 USB 2.0 hub controller driver
> > *
> > * SPDX-License-Identifier: GPL-2.0+
> > * Copyright (c) 2012-2013 Dongjin Kim (tobetter@gmail.com)
> > */
>
> And this is *exactly* what I don't want o see, because now the SPDX
> placement is basically entirely random, and we'll get stupid conflicts
> that are must nastier, and people will get it wrong and we'll end up
> with two lines etc etc headaches.
>
> Yes, the single line at the top _also_ causes conflicts, but they are
> really easy to resolve exactly because there is absolutely no
> ambiguity about what the resolution is, and there is no question that
> there could be two different SPDX lines in the file.
>
> The "//" format is ambiguous and simple, and works well for the first line.
>
> And if we have the long-term plan to move over to // (which I really
> hope for), it's also the cleanest of them all.
Let me see if I got it straight. At drivers/media/common/siano/smsir.c,
we have, currently:
/****************************************************************
Siano Mobile Silicon, Inc.
MDTV receiver kernel modules.
Copyright (C) 2006-2009, Uri Shkolnik
Copyright (c) 2010 - Mauro Carvalho Chehab
- Ported the driver to use rc-core
- IR raw event decoding is now done at rc-core
- Code almost re-written
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
****************************************************************/
With is completely out of standard. I'd like to add an SPDX tag there
and, while doing that, adjust the comments.
So, if I understand well, your preference would be to make it like:
// SPDX-License-Identifier: GPL-2.0+
//
// Siano Mobile Silicon, Inc.
// MDTV receiver kernel modules.
// Copyright (C) 2006-2009, Uri Shkolnik
//
// Copyright (c) 2010 - Mauro Carvalho Chehab
// - Ported the driver to use rc-core
// - IR raw event decoding is now done at rc-core
// - Code almost re-written
Right?
Also, what about the header file (that, currently, has an identical header?
The way it was proposed (with /**/), it would be:
/* SPDX-License-Identifier: GPL-2.0+ */
/*
* Siano Mobile Silicon, Inc.
* MDTV receiver kernel modules.
* Copyright (C) 2006-2009, Uri Shkolnik
*
* Copyright (c) 2010 - Mauro Carvalho Chehab
* - Ported the driver to use rc-core
* - IR raw event decoding is now done at rc-core
* - Code almost re-written
*/
With, IMHO, looks really ugly.
Thanks,
Mauro
next prev parent reply other threads:[~2017-11-25 19:54 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 18:33 [patch V2 00/11] LICENSES: Add documentation and initial License files Thomas Gleixner
2017-11-16 18:33 ` [patch V2 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses Thomas Gleixner
2017-11-16 19:44 ` Rob Herring
2017-11-16 20:57 ` [patch V3 " Jonathan Corbet
2017-11-17 9:48 ` Thomas Gleixner
2017-11-17 22:38 ` Jonathan Corbet
2017-11-17 10:00 ` [patch V4 " Thomas Gleixner
2017-11-17 11:58 ` Philippe Ombredanne
[not found] ` <CAG_66ZRPXxodLw=eeTRtXuRGfvmonVNknzNmMuNMVooJgd1Uxw@mail.gmail.com>
2017-11-17 13:16 ` Thomas Gleixner
2017-11-17 17:06 ` Mauro Carvalho Chehab
2017-11-17 18:11 ` Thomas Gleixner
2017-11-17 18:39 ` Christoph Hellwig
2017-11-22 11:12 ` Thomas Gleixner
2017-11-22 11:51 ` Mauro Carvalho Chehab
2017-11-22 13:23 ` Christoph Hellwig
2017-11-22 13:35 ` Mauro Carvalho Chehab
2017-11-22 13:48 ` Greg Kroah-Hartman
2017-11-25 19:04 ` Pavel Machek
2017-11-25 19:11 ` Linus Torvalds
2017-11-25 19:17 ` Pavel Machek
2017-11-25 19:30 ` Linus Torvalds
2017-11-25 19:53 ` Mauro Carvalho Chehab [this message]
2017-11-25 20:30 ` Linus Torvalds
2017-11-25 18:51 ` Pavel Machek
2017-11-25 23:41 ` Philippe Ombredanne
2017-11-17 19:02 ` Jonas Oberg
2017-12-14 16:25 ` Joe Perches
2017-12-14 16:29 ` Thomas Gleixner
2018-01-05 13:05 ` [V4, " Alexandre Belloni
2018-01-05 18:55 ` Russell King - ARM Linux
2018-01-05 22:48 ` Frank Rowand
2018-01-05 23:05 ` Alexandre Belloni
2017-11-17 10:07 ` [patch V2 " Greg Kroah-Hartman
2017-11-17 10:17 ` Carmen Bianca Bakker
2017-11-17 10:21 ` Thomas Gleixner
2017-11-16 18:33 ` [patch V2 02/11] LICENSES: Add the GPL 2.0 license Thomas Gleixner
2017-11-17 10:09 ` Greg Kroah-Hartman
2017-11-18 19:03 ` Charlemagne Lasse
2017-11-18 19:05 ` Charlemagne Lasse
2017-11-18 19:13 ` Jonas Oberg
2017-11-18 19:14 ` Linus Torvalds
2017-11-18 20:41 ` Charlemagne Lasse
2017-11-19 8:50 ` Charlemagne Lasse
2017-11-20 15:31 ` Alan Cox
2017-11-20 15:42 ` Russell King - ARM Linux
2017-11-21 8:27 ` Jonas Oberg
2017-11-21 13:57 ` Philippe Ombredanne
2017-11-21 17:55 ` Philippe Ombredanne
2017-11-20 9:42 ` Thomas Gleixner
2017-11-16 18:33 ` [patch V2 03/11] LICENSES: Add the LGPL " Thomas Gleixner
2017-11-17 10:09 ` Greg Kroah-Hartman
2017-11-16 18:33 ` [patch V2 04/11] LICENSES: Add the LGPL-2.1 license Thomas Gleixner
2017-11-17 10:09 ` Greg Kroah-Hartman
2017-11-16 18:33 ` [patch V2 05/11] LICENSES: Add the BSD 2-clause "Simplified" license Thomas Gleixner
2017-11-17 10:08 ` Greg Kroah-Hartman
2017-11-16 18:33 ` [patch V2 06/11] LICENSES: Add the BSD 3-clause "New" or "Revised" License Thomas Gleixner
2017-11-17 10:09 ` Greg Kroah-Hartman
2017-11-16 18:33 ` [patch V2 07/11] LICENSES: Add the BSD-3-clause "Clear" license Thomas Gleixner
2017-11-17 10:08 ` Greg Kroah-Hartman
2017-11-16 18:33 ` [patch V2 08/11] LICENSES: Add the MIT license Thomas Gleixner
2017-11-16 18:33 ` [patch V2 09/11] LICENSES: Add Linux syscall note exception Thomas Gleixner
2017-11-16 21:00 ` [patch V3 " Jonathan Corbet
2017-11-17 10:07 ` [patch V2 " Greg Kroah-Hartman
2017-11-16 18:33 ` [patch V2 10/11] LICENSES: Add the GPL 1.0 license Thomas Gleixner
2017-11-17 10:08 ` Greg Kroah-Hartman
2017-11-16 18:33 ` [patch V2 11/11] LICENSES: Add MPL-1.1 license Thomas Gleixner
2017-11-17 10:08 ` Greg Kroah-Hartman
2017-11-16 19:25 ` [patch V2 00/11] LICENSES: Add documentation and initial License files Thomas Gleixner
2017-12-04 21:19 [patch V4 " Thomas Gleixner
2017-12-04 21:19 ` [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses Thomas Gleixner
2017-12-05 6:50 ` Heiko Carstens
2017-12-08 15:29 ` Philippe Ombredanne
2017-12-09 11:03 ` Philippe Ombredanne
2017-12-11 21:58 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171125175353.467b6e49@vento.lan \
--to=mchehab@s-opensource.com \
--cc=akpm@linuxfoundation.org \
--cc=carmenbianca@fsfe.org \
--cc=charlemagnelasse@gmail.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=joe@perches.com \
--cc=jonas@fsfe.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=pombredanne@nexb.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rob.herring@linaro.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).