From: Charlemagne Lasse <charlemagnelasse@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linuxfoundation.org>,
Andrew Morton <akpm@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Kate Stewart <kstewart@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Christoph Hellwig <hch@lst.de>,
Russell King <rmk+kernel@armlinux.org.uk>,
Rob Herring <rob.herring@linaro.org>,
Jonas Oberg <jonas@fsfe.org>, Joe Perches <joe@perches.com>,
linux-xfs@vger.kernel.org,
Carmen Bianca Bakker <carmenbianca@fsfe.org>
Subject: Re: [patch V2 02/11] LICENSES: Add the GPL 2.0 license
Date: Sat, 18 Nov 2017 20:03:56 +0100 [thread overview]
Message-ID: <CAFGhKbxbW87yowc7trkiczjXV=37SqswwmOriTdSoxCXzFk-0A@mail.gmail.com> (raw)
In-Reply-To: <20171116184358.475929943@linutronix.de>
2017-11-16 19:33 GMT+01:00 Thomas Gleixner <tglx@linutronix.de>:
> Add the full text of the GPL 2.0 license to the kernel tree. It was
> copied directly from:
>
> https://spdx.org/licenses/GPL-2.0.html#licenseText
>
> Add the required tags for reference and tooling.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
NACKed-by: Charlemagne Lasse <charlemagnelasse@gmail.com>
This is neither the GPL-2.0 from https://www.gnu.org/licenses/gpl-2.0.txt
(which you should have used) or
https://spdx.org/licenses/GPL-2.0.html#licenseText
Please download the correct ASCII version from gnu.org and add your SPDX
info in front of it. But I have also added detailed info about
non-whitespace changes in your patch.
But I am sure that you will tell me again that I am only arguing in
circles.
>
> ---
> LICENSES/preferred/GPL-2.0 | 348 +++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 348 insertions(+)
> create mode 100644 LICENSES/GPL-2.0
This patch seems to have been modified by hand because the summary doesn't
match the patch.
>
> --- /dev/null
> +++ b/LICENSES/preferred/GPL-2.0
<cut>
> +GNU GENERAL PUBLIC LICENSE
> +Version 2, June 1991
> +
> +Copyright (C) 1989, 1991 Free Software Foundation, Inc.
That should be: "Inc.," and not "Inc."
<cut>
> +
> +Everyone is permitted to copy and distribute verbatim copies
> +of this license document, but changing it is not allowed.
> +
> +Preamble
> +
> +The licenses for most software are designed to take away your freedom to
> +share and change it. By contrast, the GNU General Public License is
> +intended to guarantee your freedom to share and change free software--to
> +make sure the software is free for all its users. This General Public
> +License applies to most of the Free Software Foundation's software and to
> +any other program whose authors commit to using it. (Some other Free
> +Software Foundation software is covered by the GNU Library General Public
> +License instead.) You can apply it to your programs, too.
That should be "GNU Lesser General Public" and not "GNU Library General Public"
<cut>
> +The precise terms and conditions for copying, distribution and modification follow.
> +
> +TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
"GNU GENERAL PUBLIC LICENSE" is missing before
"TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION"
<cut>
> +To do so, attach the following notices to the program. It is safest to
> +attach them to the start of each source file to most effectively convey the
> +exclusion of warranty; and each file should have at least the "copyright"
> +line and a pointer to where the full notice is found.
> +
> + One line to give the program's name and a brief idea of what it does.
This should actually be:
<one line to give the program's name and a brief idea of what it does.>
> + Copyright (C) <year> <name of author>
> +
> + This program is free software; you can redistribute it and/or modify it
> + under the terms of the GNU General Public License as published by the
> + Free Software Foundation; either version 2 of the License, or (at your
> + option) any later version.
> +
> + This program is distributed in the hope that it will be useful, but
> + WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + General Public License for more details.
> +
> + You should have received a copy of the GNU General Public License along
> + with this program; if not, write to the Free Software Foundation, Inc.,
> + 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
This is the wrong address. It should actually be
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
<cut>
> + Yoyodyne, Inc., hereby disclaims all copyright interest in the program
> + `Gnomovision' (which makes passes at compilers) written by James
> + Hacker.
> +
> + signature of Ty Coon, 1 April 1989
This should actually be:
<signature of Ty Coon>, 1 April 1989
> + Ty Coon, President of Vice
> +
> +This General Public License does not permit incorporating your program into
> +proprietary programs. If your program is a subroutine library, you may
> +consider it more useful to permit linking proprietary applications with the
> +library. If this is what you want to do, use the GNU Library General Public
> +License instead of this License.
"Lesser Library General Public" and not "Library General Public License"
next prev parent reply other threads:[~2017-11-18 19:04 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 18:33 [patch V2 00/11] LICENSES: Add documentation and initial License files Thomas Gleixner
2017-11-16 18:33 ` [patch V2 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses Thomas Gleixner
2017-11-16 19:44 ` Rob Herring
2017-11-16 20:57 ` [patch V3 " Jonathan Corbet
2017-11-17 9:48 ` Thomas Gleixner
2017-11-17 22:38 ` Jonathan Corbet
2017-11-17 10:00 ` [patch V4 " Thomas Gleixner
2017-11-17 11:58 ` Philippe Ombredanne
[not found] ` <CAG_66ZRPXxodLw=eeTRtXuRGfvmonVNknzNmMuNMVooJgd1Uxw@mail.gmail.com>
2017-11-17 13:16 ` Thomas Gleixner
2017-11-17 17:06 ` Mauro Carvalho Chehab
2017-11-17 18:11 ` Thomas Gleixner
2017-11-17 18:39 ` Christoph Hellwig
2017-11-22 11:12 ` Thomas Gleixner
2017-11-22 11:51 ` Mauro Carvalho Chehab
2017-11-22 13:23 ` Christoph Hellwig
2017-11-22 13:35 ` Mauro Carvalho Chehab
2017-11-22 13:48 ` Greg Kroah-Hartman
2017-11-25 19:04 ` Pavel Machek
2017-11-25 19:11 ` Linus Torvalds
2017-11-25 19:17 ` Pavel Machek
2017-11-25 19:30 ` Linus Torvalds
2017-11-25 19:53 ` Mauro Carvalho Chehab
2017-11-25 20:30 ` Linus Torvalds
2017-11-25 18:51 ` Pavel Machek
2017-11-25 23:41 ` Philippe Ombredanne
2017-11-17 19:02 ` Jonas Oberg
2017-12-14 16:25 ` Joe Perches
2017-12-14 16:29 ` Thomas Gleixner
2018-01-05 13:05 ` [V4, " Alexandre Belloni
2018-01-05 18:55 ` Russell King - ARM Linux
2018-01-05 22:48 ` Frank Rowand
2018-01-05 23:05 ` Alexandre Belloni
2017-11-17 10:07 ` [patch V2 " Greg Kroah-Hartman
2017-11-17 10:17 ` Carmen Bianca Bakker
2017-11-17 10:21 ` Thomas Gleixner
2017-11-16 18:33 ` [patch V2 02/11] LICENSES: Add the GPL 2.0 license Thomas Gleixner
2017-11-17 10:09 ` Greg Kroah-Hartman
2017-11-18 19:03 ` Charlemagne Lasse [this message]
2017-11-18 19:05 ` Charlemagne Lasse
2017-11-18 19:13 ` Jonas Oberg
2017-11-18 19:14 ` Linus Torvalds
2017-11-18 20:41 ` Charlemagne Lasse
2017-11-19 8:50 ` Charlemagne Lasse
2017-11-20 15:31 ` Alan Cox
2017-11-20 15:42 ` Russell King - ARM Linux
2017-11-21 8:27 ` Jonas Oberg
2017-11-21 13:57 ` Philippe Ombredanne
2017-11-21 17:55 ` Philippe Ombredanne
2017-11-20 9:42 ` Thomas Gleixner
2017-11-16 18:33 ` [patch V2 03/11] LICENSES: Add the LGPL " Thomas Gleixner
2017-11-17 10:09 ` Greg Kroah-Hartman
2017-11-16 18:33 ` [patch V2 04/11] LICENSES: Add the LGPL-2.1 license Thomas Gleixner
2017-11-17 10:09 ` Greg Kroah-Hartman
2017-11-16 18:33 ` [patch V2 05/11] LICENSES: Add the BSD 2-clause "Simplified" license Thomas Gleixner
2017-11-17 10:08 ` Greg Kroah-Hartman
2017-11-16 18:33 ` [patch V2 06/11] LICENSES: Add the BSD 3-clause "New" or "Revised" License Thomas Gleixner
2017-11-17 10:09 ` Greg Kroah-Hartman
2017-11-16 18:33 ` [patch V2 07/11] LICENSES: Add the BSD-3-clause "Clear" license Thomas Gleixner
2017-11-17 10:08 ` Greg Kroah-Hartman
2017-11-16 18:33 ` [patch V2 08/11] LICENSES: Add the MIT license Thomas Gleixner
2017-11-16 18:33 ` [patch V2 09/11] LICENSES: Add Linux syscall note exception Thomas Gleixner
2017-11-16 21:00 ` [patch V3 " Jonathan Corbet
2017-11-17 10:07 ` [patch V2 " Greg Kroah-Hartman
2017-11-16 18:33 ` [patch V2 10/11] LICENSES: Add the GPL 1.0 license Thomas Gleixner
2017-11-17 10:08 ` Greg Kroah-Hartman
2017-11-16 18:33 ` [patch V2 11/11] LICENSES: Add MPL-1.1 license Thomas Gleixner
2017-11-17 10:08 ` Greg Kroah-Hartman
2017-11-16 19:25 ` [patch V2 00/11] LICENSES: Add documentation and initial License files Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFGhKbxbW87yowc7trkiczjXV=37SqswwmOriTdSoxCXzFk-0A@mail.gmail.com' \
--to=charlemagnelasse@gmail.com \
--cc=akpm@linuxfoundation.org \
--cc=carmenbianca@fsfe.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=joe@perches.com \
--cc=jonas@fsfe.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rob.herring@linaro.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).