From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Clark Williams <williams@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
John Kacur <jkacur@redhat.com>, Scott Wood <swood@redhat.com>,
Mike Galbraith <efault@gmx.de>
Subject: Re: [PATCH RT] fix IPI balancing for 4.14-rt
Date: Tue, 28 Nov 2017 09:31:14 +0100 [thread overview]
Message-ID: <20171128083114.GA1540@linutronix.de> (raw)
In-Reply-To: <20171127172521.184b9a46@gandalf.local.home>
On 2017-11-27 17:25:21 [-0500], Steven Rostedt wrote:
> On Thu, 23 Nov 2017 18:25:39 +0100
> Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
>
>
> > I cherry-picked commit 4bdced5c9a29 ("sched/rt: Simplify the IPI based
> > RT balancing logic") and while refreshing the queue I noticed that the
> > irq_work struct moved and added the fix below into the original patch
> > where the IRQ_WORK_HARD_IRQ flag was added.
>
> Perhaps you should keep it as a separate patch. 4bdced5c9a29 is now in
> mainline. The next time you port to mainline, you may drop this fix,
> and cause the scheduling IPI to run in threaded context (which would be
> bad).
>
> Having it as a separate patch, would remind us that it would need to be
> added to mainline in the future.
That patch in v4.14 rt-devel RT git tree has it as one commit. The patch
in RT queue has the IRQ_WORK_HARD_IRQ added in the patch where that flag
was introduced. For reference:
https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git/tree/patches/irqwork-push_most_work_into_softirq_context.patch?h=linux-4.14.y-rt-patches&id=657d8cd9f93891840fb1cd1666a8e590d19e72ba#n144
> Feel free to add to that that patch:
>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> -- Steve
Sebastian
next prev parent reply other threads:[~2017-11-28 8:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 18:05 [PATCH tip/sched/core v3] sched/rt: Simplify the IPI rt balancing logic Steven Rostedt
2017-11-21 15:14 ` [PATCH RT] fix IPI balancing for 4.14-rt Clark Williams
2017-11-21 15:24 ` Steven Rostedt
2017-11-23 17:25 ` Sebastian Andrzej Siewior
2017-11-27 22:25 ` Steven Rostedt
2017-11-28 8:31 ` Sebastian Andrzej Siewior [this message]
2017-11-28 15:32 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128083114.GA1540@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=bristot@redhat.com \
--cc=efault@gmx.de \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=swood@redhat.com \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).