[PATCH v3] bcma:Adjust block comments

[PATCH v3] bcma:Adjust block comments

[Ashish Kalra]

use * for block comments in multiple lines according to kernel coding
style

Reported by: checkpatch.pl

Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
---
Change log:
        -v3: Improvement on  commit message as per review from Morgan Freeman <morganfreeman6991@gmail.com>
        -v2: Improvement on  commit message as per review from Morgan Freeman <morganfreeman6991@gmail.com>(https://lkml.org/lkml/2017/11/27/1259)
        -v1: https://lkml.org/lkml/2017/11/26/85

 drivers/bcma/driver_pcie2.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/bcma/driver_pcie2.c b/drivers/bcma/driver_pcie2.c
index b1a6e327cb23..cf889fc62ac7 100644
--- a/drivers/bcma/driver_pcie2.c
+++ b/drivers/bcma/driver_pcie2.c
@@ -83,7 +83,8 @@ static void bcma_core_pcie2_hw_ltr_war(struct bcma_drv_pcie2 *pcie2)
 		bcma_core_pcie2_set_ltr_vals(pcie2);
 
 		/* TODO:
-		si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */
+		 *si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0);
+		 */
 
 		/* enable the LTR */
 		devstsctr2 |= PCIE2_CAP_DEVSTSCTRL2_LTRENAB;
-- 
2.14.1

Re: [PATCH v3] bcma:Adjust block comments

[Himanshu Jha]

Hi Ashish,

On Tue, Nov 28, 2017 at 09:24:58PM +0530, Ashish Kalra wrote:
> use * for block comments in multiple lines according to kernel coding
> style
> 
> Reported by: checkpatch.pl
> 
> Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
> ---

Looks good now!
FWIW,

Reviewed-by: Himanshu Jha <himanshujha199640@gmail.com>


> Change log:
>         -v3: Improvement on  commit message as per review from Morgan Freeman <morganfreeman6991@gmail.com>

BTW, this <morganfreeman6991@gmail.com> is my secondary email subscibed
to linux-wirless as I don't want my primary email to be flooded with
frequent emails, and my upstream mail is himanshujha199640@gmail.com !



Thanks
Himanshu Jha

Re: [v3] bcma: Adjust block comment

[Kalle Valo]

Ashish Kalra <eashishkalra@gmail.com> wrote:

> use * for block comments in multiple lines according to kernel coding
> style
> 
> Reported by: checkpatch.pl
> 
> Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
> Reviewed-by: Himanshu Jha <himanshujha199640@gmail.com>

Patch applied to wireless-drivers-next.git, thanks.

a765c8fdc869 bcma: Adjust block comment

-- 
https://patchwork.kernel.org/patch/10080747/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches