* [PATCH] pcmcia: at91_cf: Use PTR_ERR_OR_ZERO()
@ 2017-11-28 15:21 Vasyl Gomonovych
2017-11-28 15:41 ` Nicolas Ferre
2017-11-29 20:59 ` Alexandre Belloni
0 siblings, 2 replies; 3+ messages in thread
From: Vasyl Gomonovych @ 2017-11-28 15:21 UTC (permalink / raw)
To: nicolas.ferre, alexandre.belloni, linux-pcmcia, linux-arm-kernel
Cc: linux-kernel, gomonovych
Fix ptr_ret.cocci warnings:
drivers/pcmcia/at91_cf.c:239:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
drivers/pcmcia/at91_cf.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pcmcia/at91_cf.c b/drivers/pcmcia/at91_cf.c
index 87147bcd1655..7da7b0f0ae1b 100644
--- a/drivers/pcmcia/at91_cf.c
+++ b/drivers/pcmcia/at91_cf.c
@@ -236,10 +236,8 @@ static int at91_cf_dt_init(struct platform_device *pdev)
pdev->dev.platform_data = board;
mc = syscon_regmap_lookup_by_compatible("atmel,at91rm9200-sdramc");
- if (IS_ERR(mc))
- return PTR_ERR(mc);
- return 0;
+ return PTR_ERR_OR_ZERO(mc);
}
#else
static int at91_cf_dt_init(struct platform_device *pdev)
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pcmcia: at91_cf: Use PTR_ERR_OR_ZERO()
2017-11-28 15:21 [PATCH] pcmcia: at91_cf: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
@ 2017-11-28 15:41 ` Nicolas Ferre
2017-11-29 20:59 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2017-11-28 15:41 UTC (permalink / raw)
To: Vasyl Gomonovych, alexandre.belloni, linux-pcmcia, linux-arm-kernel
Cc: linux-kernel
On 28/11/2017 at 16:21, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/pcmcia/at91_cf.c:239:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
okay...
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> drivers/pcmcia/at91_cf.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pcmcia/at91_cf.c b/drivers/pcmcia/at91_cf.c
> index 87147bcd1655..7da7b0f0ae1b 100644
> --- a/drivers/pcmcia/at91_cf.c
> +++ b/drivers/pcmcia/at91_cf.c
> @@ -236,10 +236,8 @@ static int at91_cf_dt_init(struct platform_device *pdev)
> pdev->dev.platform_data = board;
>
> mc = syscon_regmap_lookup_by_compatible("atmel,at91rm9200-sdramc");
> - if (IS_ERR(mc))
> - return PTR_ERR(mc);
>
> - return 0;
> + return PTR_ERR_OR_ZERO(mc);
> }
> #else
> static int at91_cf_dt_init(struct platform_device *pdev)
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pcmcia: at91_cf: Use PTR_ERR_OR_ZERO()
2017-11-28 15:21 [PATCH] pcmcia: at91_cf: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
2017-11-28 15:41 ` Nicolas Ferre
@ 2017-11-29 20:59 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2017-11-29 20:59 UTC (permalink / raw)
To: Vasyl Gomonovych
Cc: nicolas.ferre, linux-pcmcia, linux-arm-kernel, linux-kernel
On 28/11/2017 at 16:21:40 +0100, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/pcmcia/at91_cf.c:239:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
> drivers/pcmcia/at91_cf.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-29 20:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-28 15:21 [PATCH] pcmcia: at91_cf: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
2017-11-28 15:41 ` Nicolas Ferre
2017-11-29 20:59 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).