* [PATCH] PNP: pnpbios: Use PTR_ERR_OR_ZERO()
@ 2017-11-29 16:20 Vasyl Gomonovych
2017-11-29 20:55 ` Jean Delvare
0 siblings, 1 reply; 3+ messages in thread
From: Vasyl Gomonovych @ 2017-11-29 16:20 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Vasyl Gomonovych, Rafael J. Wysocki, Jean Delvare, linux-kernel
Fix ptr_ret.cocci warnings:
drivers/pnp/pnpbios/core.c:584:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
drivers/pnp/pnpbios/core.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/pnp/pnpbios/core.c b/drivers/pnp/pnpbios/core.c
index e681140b85d8..077f334fdbae 100644
--- a/drivers/pnp/pnpbios/core.c
+++ b/drivers/pnp/pnpbios/core.c
@@ -581,10 +581,7 @@ static int __init pnpbios_thread_init(void)
init_completion(&unload_sem);
task = kthread_run(pnp_dock_thread, NULL, "kpnpbiosd");
- if (IS_ERR(task))
- return PTR_ERR(task);
-
- return 0;
+ return PTR_ERR_OR_ZERO(task);
}
/* Start the kernel thread later: */
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PNP: pnpbios: Use PTR_ERR_OR_ZERO()
2017-11-29 16:20 [PATCH] PNP: pnpbios: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
@ 2017-11-29 20:55 ` Jean Delvare
2017-12-17 17:36 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Jean Delvare @ 2017-11-29 20:55 UTC (permalink / raw)
To: Vasyl Gomonovych; +Cc: Greg Kroah-Hartman, Rafael J. Wysocki, linux-kernel
On Wed, 29 Nov 2017 17:20:57 +0100, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/pnp/pnpbios/core.c:584:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
> drivers/pnp/pnpbios/core.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/pnp/pnpbios/core.c b/drivers/pnp/pnpbios/core.c
> index e681140b85d8..077f334fdbae 100644
> --- a/drivers/pnp/pnpbios/core.c
> +++ b/drivers/pnp/pnpbios/core.c
> @@ -581,10 +581,7 @@ static int __init pnpbios_thread_init(void)
>
> init_completion(&unload_sem);
> task = kthread_run(pnp_dock_thread, NULL, "kpnpbiosd");
> - if (IS_ERR(task))
> - return PTR_ERR(task);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(task);
> }
>
> /* Start the kernel thread later: */
Looks good to me.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PNP: pnpbios: Use PTR_ERR_OR_ZERO()
2017-11-29 20:55 ` Jean Delvare
@ 2017-12-17 17:36 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2017-12-17 17:36 UTC (permalink / raw)
To: Jean Delvare, Vasyl Gomonovych, linux-kernel; +Cc: Greg Kroah-Hartman
On Wednesday, November 29, 2017 9:55:23 PM CET Jean Delvare wrote:
> On Wed, 29 Nov 2017 17:20:57 +0100, Vasyl Gomonovych wrote:
> > Fix ptr_ret.cocci warnings:
> > drivers/pnp/pnpbios/core.c:584:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> >
> > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> >
> > Generated by: scripts/coccinelle/api/ptr_ret.cocci
> >
> > Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> > ---
> > drivers/pnp/pnpbios/core.c | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/drivers/pnp/pnpbios/core.c b/drivers/pnp/pnpbios/core.c
> > index e681140b85d8..077f334fdbae 100644
> > --- a/drivers/pnp/pnpbios/core.c
> > +++ b/drivers/pnp/pnpbios/core.c
> > @@ -581,10 +581,7 @@ static int __init pnpbios_thread_init(void)
> >
> > init_completion(&unload_sem);
> > task = kthread_run(pnp_dock_thread, NULL, "kpnpbiosd");
> > - if (IS_ERR(task))
> > - return PTR_ERR(task);
> > -
> > - return 0;
> > + return PTR_ERR_OR_ZERO(task);
> > }
> >
> > /* Start the kernel thread later: */
>
> Looks good to me.
>
> Reviewed-by: Jean Delvare <jdelvare@suse.de>
>
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-17 17:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-29 16:20 [PATCH] PNP: pnpbios: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
2017-11-29 20:55 ` Jean Delvare
2017-12-17 17:36 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).