From: Brian Norris <briannorris@chromium.org>
To: Nickey Yang <nickey.yang@rock-chips.com>
Cc: robh+dt@kernel.org, heiko@sntech.de, mark.rutland@arm.com,
airlied@linux.ie, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
laurent.pinchart@ideasonboard.com, seanpaul@chromium.org,
mka@chromium.org, hoegsberg@gmail.com, architt@codeaurora.org,
philippe.cornu@st.com, yannick.fertre@st.com, hl@rock-chips.com,
zyw@rock-chips.com, xbl@rock-chips.com
Subject: Re: [PATCH v4 2/3] dt-bindings: display: rockchip: update DSI controller
Date: Fri, 1 Dec 2017 10:21:19 -0800 [thread overview]
Message-ID: <20171201182118.GA66630@google.com> (raw)
In-Reply-To: <1512100685-4015-3-git-send-email-nickey.yang@rock-chips.com>
On Fri, Dec 01, 2017 at 11:58:04AM +0800, Nickey Yang wrote:
> This patch update describe panel/port links, including
> unit addresses in documentation of device tree bindings
> for the rockchip DSI controller based on the Synopsys
> DesignWare MIPI DSI host controller.
>
> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
Seems OK to me:
Reviewed-by: Brian Norris <briannorris@chromium.org>
>
> ---
> Changes in v4:
> - keep the -cells properties
>
> .../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 ++++++++++++++++++++--
> 1 file changed, 21 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt
> index 6bb59ab..ce4c1fc 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt
> +++ b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt
> @@ -14,6 +14,8 @@ Required properties:
> - rockchip,grf: this soc should set GRF regs to mux vopl/vopb.
> - ports: contain a port node with endpoint definitions as defined in [2].
> For vopb,set the reg = <0> and set the reg = <1> for vopl.
> +- video port 0 for the VOP input, the remote endpoint maybe vopb or vopl
> +- video port 1 for either a panel or subsequent encoder
>
> Optional properties:
> - power-domains: a phandle to mipi dsi power domain node.
> @@ -40,11 +42,12 @@ Example:
> ports {
> #address-cells = <1>;
> #size-cells = <0>;
> - reg = <1>;
>
> - mipi_in: port {
> + mipi_in: port@0 {
> + reg = <0>;
> #address-cells = <1>;
> #size-cells = <0>;
> +
> mipi_in_vopb: endpoint@0 {
> reg = <0>;
> remote-endpoint = <&vopb_out_mipi>;
> @@ -54,6 +57,16 @@ Example:
> remote-endpoint = <&vopl_out_mipi>;
> };
> };
> +
> + mipi_out: port@1 {
> + reg = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + mipi_out_panel: endpoint {
> + remote-endpoint = <&panel_in_mipi>;
> + };
> + };
> };
>
> panel {
> @@ -64,5 +77,11 @@ Example:
> pinctrl-names = "default";
> pinctrl-0 = <&lcd_en>;
> backlight = <&backlight>;
> +
> + port {
> + panel_in_mipi: endpoint {
> + remote-endpoint = <&mipi_out_panel>;
> + };
> + };
> };
> };
> --
> 1.9.1
>
next prev parent reply other threads:[~2017-12-01 18:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 3:58 [PATCH v4 0/3] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge Nickey Yang
2017-12-01 3:58 ` [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata Nickey Yang
2017-12-01 8:32 ` Philippe CORNU
[not found] ` <c6a53132-1ee3-00be-d52d-218560c07975@rock-chips.com>
2017-12-01 10:07 ` Philippe CORNU
2017-12-05 9:14 ` Nickey Yang
2017-12-05 18:56 ` Brian Norris
2017-12-06 7:16 ` Nickey Yang
2017-12-01 18:29 ` Emil Velikov
2017-12-01 3:58 ` [PATCH v4 2/3] dt-bindings: display: rockchip: update DSI controller Nickey Yang
2017-12-01 18:21 ` Brian Norris [this message]
2017-12-01 3:58 ` [PATCH v4 3/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver Nickey Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201182118.GA66630@google.com \
--to=briannorris@chromium.org \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hl@rock-chips.com \
--cc=hoegsberg@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=nickey.yang@rock-chips.com \
--cc=philippe.cornu@st.com \
--cc=robh+dt@kernel.org \
--cc=seanpaul@chromium.org \
--cc=xbl@rock-chips.com \
--cc=yannick.fertre@st.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).