linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] [FIX] staging: pi433: fix last commit indentation
@ 2017-12-03 15:52 Victor Carvalho
  2017-12-06 14:54 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Victor Carvalho @ 2017-12-03 15:52 UTC (permalink / raw)
  To: gregkh; +Cc: linux-kernel

fix indentation in commit:

 - 928150e1dbb8638f309493b7dc72d56c20896704 staging: pi433: fix coding style in function rf69_set_rx_cfg()

Signed-off-by: Victor Carvalho <victor.ruivo@cryptolab.net>
---
 drivers/staging/pi433/pi433_if.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 97ab5fa27059..a9fd7fc209d6 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -203,11 +203,12 @@ rf69_set_rx_cfg(struct pi433_device *dev, struct pi433_rx_cfg *rx_cfg)
 	/* packet config */
 	/* enable */
 	SET_CHECKED(rf69_set_sync_enable(dev->spi, rx_cfg->enable_sync));
-	if (rx_cfg->enable_sync == optionOn)
+	if (rx_cfg->enable_sync == optionOn) {
 		SET_CHECKED(rf69_set_fifo_fill_condition(dev->spi,
 							 afterSyncInterrupt));
-	else
+	} else {
 		SET_CHECKED(rf69_set_fifo_fill_condition(dev->spi, always));
+	}
 
 	if (rx_cfg->enable_length_byte == optionOn) {
 		ret = rf69_set_packet_format(dev->spi, packetLengthVar);
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] [FIX] staging: pi433: fix last commit indentation
  2017-12-03 15:52 [PATCH] [FIX] staging: pi433: fix last commit indentation Victor Carvalho
@ 2017-12-06 14:54 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-12-06 14:54 UTC (permalink / raw)
  To: Victor Carvalho; +Cc: linux-kernel

On Sun, Dec 03, 2017 at 01:52:43PM -0200, Victor Carvalho wrote:
> fix indentation in commit:
> 
>  - 928150e1dbb8638f309493b7dc72d56c20896704 staging: pi433: fix coding style in function rf69_set_rx_cfg()

There is no such commit in the kernel tree :(

Also, no need for [FIX] in the subject line.  If yuo have a problem with
a previous patch, just fix it up and resend the whole thing and properly
version the patch.

Also, use scripts/get_maintainer.pl to know who to cc: and what mailing
list to send the patches to, you missed a bunch of people here :(

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-12-06 14:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-03 15:52 [PATCH] [FIX] staging: pi433: fix last commit indentation Victor Carvalho
2017-12-06 14:54 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).