* [PATCH v2 1/2] x86/apic: Avoid wrong warning when parsing 'apic=' in X86-32 case.
@ 2017-12-04 4:03 Dou Liyang
2017-12-04 4:03 ` [PATCH v2 2/2] x86/apic: Update the 'apic=' description of setting APIC driver Dou Liyang
2017-12-28 11:36 ` [tip:x86/urgent] x86/apic: Avoid wrong warning when parsing 'apic=' in X86-32 case tip-bot for Dou Liyang
0 siblings, 2 replies; 4+ messages in thread
From: Dou Liyang @ 2017-12-04 4:03 UTC (permalink / raw)
To: linux-kernel, x86; +Cc: tglx, hpa, corbet, mingo, peterz, rdunlap, Dou Liyang
There are two consumers of apic=:
apic_set_verbosity() for setting the APIC debug level;
parse_apic() for registering APIC driver by hand.
X86-32 supports both of them, but sometimes, kernel issues a weird warning.
eg: when kernel was booted up with 'apic=bigsmp' in command line,
early_param would warn like that:
...
[ 0.000000] APIC Verbosity level bigsmp not recognised use apic=verbose or apic=debug
[ 0.000000] Malformed early option 'apic'
...
Wrap the warning code in CONFIG_X86_64 case to avoid this.
Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
---
arch/x86/kernel/apic/apic.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 6e272f3ea984..880441f24146 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -2626,11 +2626,13 @@ static int __init apic_set_verbosity(char *arg)
apic_verbosity = APIC_DEBUG;
else if (strcmp("verbose", arg) == 0)
apic_verbosity = APIC_VERBOSE;
+#ifdef CONFIG_X86_64
else {
pr_warning("APIC Verbosity level %s not recognised"
" use apic=verbose or apic=debug\n", arg);
return -EINVAL;
}
+#endif
return 0;
}
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/2] x86/apic: Update the 'apic=' description of setting APIC driver
2017-12-04 4:03 [PATCH v2 1/2] x86/apic: Avoid wrong warning when parsing 'apic=' in X86-32 case Dou Liyang
@ 2017-12-04 4:03 ` Dou Liyang
2017-12-28 11:37 ` [tip:x86/urgent] " tip-bot for Dou Liyang
2017-12-28 11:36 ` [tip:x86/urgent] x86/apic: Avoid wrong warning when parsing 'apic=' in X86-32 case tip-bot for Dou Liyang
1 sibling, 1 reply; 4+ messages in thread
From: Dou Liyang @ 2017-12-04 4:03 UTC (permalink / raw)
To: linux-kernel, x86; +Cc: tglx, hpa, corbet, mingo, peterz, rdunlap, Dou Liyang
There are two consumers of apic=: the APIC debug level and the low
level generic architecture code, but Linux just documented the first
one.
Append the second description.
Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
---
V1 --> V2:
-Replcace the description suggested by Randy Dunlap
---
Documentation/admin-guide/kernel-parameters.txt | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 6571fbfdb2a1..0ead24cb282f 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -328,11 +328,15 @@
not play well with APC CPU idle - disable it if you have
APC and your system crashes randomly.
- apic= [APIC,X86-32] Advanced Programmable Interrupt Controller
+ apic= [APIC,X86] Advanced Programmable Interrupt Controller
Change the output verbosity whilst booting
Format: { quiet (default) | verbose | debug }
Change the amount of debugging information output
when initialising the APIC and IO-APIC components.
+ For X86-32, this can also be used to specify an APIC
+ driver name.
+ Format: apic=driver_name
+ Examples: apic=bigsmp
apic_extnmi= [APIC,X86] External NMI delivery setting
Format: { bsp (default) | all | none }
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [tip:x86/urgent] x86/apic: Avoid wrong warning when parsing 'apic=' in X86-32 case
2017-12-04 4:03 [PATCH v2 1/2] x86/apic: Avoid wrong warning when parsing 'apic=' in X86-32 case Dou Liyang
2017-12-04 4:03 ` [PATCH v2 2/2] x86/apic: Update the 'apic=' description of setting APIC driver Dou Liyang
@ 2017-12-28 11:36 ` tip-bot for Dou Liyang
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Dou Liyang @ 2017-12-28 11:36 UTC (permalink / raw)
To: linux-tip-commits; +Cc: mingo, hpa, tglx, linux-kernel, douly.fnst
Commit-ID: 4fcab6693445cfb84f2b65868c58043535090e52
Gitweb: https://git.kernel.org/tip/4fcab6693445cfb84f2b65868c58043535090e52
Author: Dou Liyang <douly.fnst@cn.fujitsu.com>
AuthorDate: Mon, 4 Dec 2017 12:03:12 +0800
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 28 Dec 2017 12:32:06 +0100
x86/apic: Avoid wrong warning when parsing 'apic=' in X86-32 case
There are two consumers of apic=:
apic_set_verbosity() for setting the APIC debug level;
parse_apic() for registering APIC driver by hand.
X86-32 supports both of them, but sometimes, kernel issues a weird warning.
eg: when kernel was booted up with 'apic=bigsmp' in command line,
early_param would warn like that:
...
[ 0.000000] APIC Verbosity level bigsmp not recognised use apic=verbose or apic=debug
[ 0.000000] Malformed early option 'apic'
...
Wrap the warning code in CONFIG_X86_64 case to avoid this.
Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: peterz@infradead.org
Cc: rdunlap@infradead.org
Cc: corbet@lwn.net
Link: https://lkml.kernel.org/r/20171204040313.24824-1-douly.fnst@cn.fujitsu.com
---
arch/x86/kernel/apic/apic.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 6e272f3..880441f 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -2626,11 +2626,13 @@ static int __init apic_set_verbosity(char *arg)
apic_verbosity = APIC_DEBUG;
else if (strcmp("verbose", arg) == 0)
apic_verbosity = APIC_VERBOSE;
+#ifdef CONFIG_X86_64
else {
pr_warning("APIC Verbosity level %s not recognised"
" use apic=verbose or apic=debug\n", arg);
return -EINVAL;
}
+#endif
return 0;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [tip:x86/urgent] x86/apic: Update the 'apic=' description of setting APIC driver
2017-12-04 4:03 ` [PATCH v2 2/2] x86/apic: Update the 'apic=' description of setting APIC driver Dou Liyang
@ 2017-12-28 11:37 ` tip-bot for Dou Liyang
0 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Dou Liyang @ 2017-12-28 11:37 UTC (permalink / raw)
To: linux-tip-commits; +Cc: hpa, linux-kernel, tglx, douly.fnst, mingo
Commit-ID: 64e05d118e357bb52a084b609436acf292ce7944
Gitweb: https://git.kernel.org/tip/64e05d118e357bb52a084b609436acf292ce7944
Author: Dou Liyang <douly.fnst@cn.fujitsu.com>
AuthorDate: Mon, 4 Dec 2017 12:03:13 +0800
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 28 Dec 2017 12:32:07 +0100
x86/apic: Update the 'apic=' description of setting APIC driver
There are two consumers of apic=: the APIC debug level and the low
level generic architecture code, but Linux just documented the first
one.
Append the second description.
Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: peterz@infradead.org
Cc: rdunlap@infradead.org
Cc: corbet@lwn.net
Link: https://lkml.kernel.org/r/20171204040313.24824-2-douly.fnst@cn.fujitsu.com
---
Documentation/admin-guide/kernel-parameters.txt | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index b74e133..852fb11 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -328,11 +328,15 @@
not play well with APC CPU idle - disable it if you have
APC and your system crashes randomly.
- apic= [APIC,X86-32] Advanced Programmable Interrupt Controller
+ apic= [APIC,X86] Advanced Programmable Interrupt Controller
Change the output verbosity whilst booting
Format: { quiet (default) | verbose | debug }
Change the amount of debugging information output
when initialising the APIC and IO-APIC components.
+ For X86-32, this can also be used to specify an APIC
+ driver name.
+ Format: apic=driver_name
+ Examples: apic=bigsmp
apic_extnmi= [APIC,X86] External NMI delivery setting
Format: { bsp (default) | all | none }
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-28 11:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-04 4:03 [PATCH v2 1/2] x86/apic: Avoid wrong warning when parsing 'apic=' in X86-32 case Dou Liyang
2017-12-04 4:03 ` [PATCH v2 2/2] x86/apic: Update the 'apic=' description of setting APIC driver Dou Liyang
2017-12-28 11:37 ` [tip:x86/urgent] " tip-bot for Dou Liyang
2017-12-28 11:36 ` [tip:x86/urgent] x86/apic: Avoid wrong warning when parsing 'apic=' in X86-32 case tip-bot for Dou Liyang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).