linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Łukasz Stelmach" <l.stelmach@samsung.com>
To: "Andrew F. Davis" <afd@ti.com>,
	PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>,
	Rob Herring <robh+dt@kernel.org>, Matt Mackall <mpm@selenic.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Kukjin Kim <kgene@kernel.org>,
	devicetree@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Łukasz Stelmach" <l.stelmach@samsung.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>
Subject: [PATCH v3 0/3] True RNG driver for Samsung Exynos 5250+ SoCs
Date: Mon, 04 Dec 2017 13:53:48 +0100	[thread overview]
Message-ID: <20171204125351.26805-1-l.stelmach@samsung.com> (raw)
In-Reply-To: <20171204120429.22892-1-l.stelmach@samsung.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 2935 bytes --]

Hello.

The following patches add support for the true random number generator
found in Samsung Exynos 5250+ SoCs.

Patch #1 adds documentation for devicetree bindings.

Patch #2 introduces the driver and appropriate changes in Makefile and Kconfig.

Patch #3 adds nodes in devicetree files for Exynos SoCs (requires
https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/commit/?id=cdd745c8c76b02471d88f467c44a3d4eb431aa0b).

Changes in v3:

- Changed node-name in device-tree bindings according to from Krzysztof
  Koz‚³owski's recommendation.
- Fixed name and added EXYNOS_ in EXYNOS_TRNG_CTRL_RNGEN
- Removed unnecessary label and simplifed the abnormal exit path in
  exynos_trng_probe()
- Replaced __raw_{readl,writel}() with {readl,writel}_relaxed() (thanks
  PrasannaKumar Muralidharan)

Changes in v2:
- Fixed indentation in drivers/char/hw_random/Kconfig.
- Defined TRNG_CTRL_RGNEN.
- Removed global variable exynos_trng_dev.
- Removed exynos_trng_{set,get}_reg() functions.
- Used the min_t() macro instead of the ternary operator in
  exynos_trng_do_read().
- Moved trng initialisation to the variable declaration in
  exynos_trng_init().
- Fixed comment formating.
- Removed unnecessary "TODO" comments.
- Return ENOMEM, if devm_kzalloc() devm_kstrdup() fail.
- Rephrased and unified error messages in exynos_trng_probe().
- Removed nullification of trng->mem.
- Added err_pm_get label at the end of exynos_trng_probe().
- Removed double error message at the end of exynos_trng_probe().
- Implemented exynos_trng_remove().

v2 available here:

https://www.spinics.net/lists/linux-samsung-soc/msg61280.html
https://patchwork.kernel.org/patch/10076225/
https://patchwork.kernel.org/patch/10076227/
https://patchwork.kernel.org/patch/10076237/

v1 can be found:

https://www.spinics.net/lists/linux-samsung-soc/msg61253.html
https://patchwork.kernel.org/patch/10072967/
https://patchwork.kernel.org/patch/10072971/
https://patchwork.kernel.org/patch/10072963/

‚£ukasz Stelmach (3):
  dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings
  hwrng: exynos - add Samsung Exynos True RNG driver
  ARM: dts: exynos: Add nodes for True Random Number Generator

 .../bindings/rng/samsung,exynos5250-trng.txt       |  17 ++
 MAINTAINERS                                        |   7 +
 arch/arm/boot/dts/exynos5.dtsi                     |   5 +
 arch/arm/boot/dts/exynos5250.dtsi                  |   5 +
 arch/arm/boot/dts/exynos5410.dtsi                  |   5 +
 arch/arm/boot/dts/exynos5420.dtsi                  |   5 +
 drivers/char/hw_random/Kconfig                     |  12 +
 drivers/char/hw_random/Makefile                    |   1 +
 drivers/char/hw_random/exynos-trng.c               | 245 +++++++++++++++++++++
 9 files changed, 302 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
 create mode 100644 drivers/char/hw_random/exynos-trng.c

-- 
2.11.0

       reply	other threads:[~2017-12-04 12:54 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20171204120429.22892-1-l.stelmach@samsung.com>
     [not found] ` <CGME20171204125413eucas1p17e7b90e3eab244e716ea3b0023ff9a41@eucas1p1.samsung.com>
2017-12-04 12:53   ` Łukasz Stelmach [this message]
2017-12-04 12:53 ` [PATCH v3 1/3] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings Łukasz Stelmach
2017-12-04 13:13   ` Krzysztof Kozlowski
     [not found]     ` <CGME20171205093028eucas1p1fb6d7b8bde6cd5e3a0bfca8ddafe8a31@eucas1p1.samsung.com>
2017-12-05  9:30       ` Łukasz Stelmach
2017-12-05 10:04         ` Krzysztof Kozlowski
2017-12-04 20:27   ` Rob Herring
2017-12-04 12:53 ` [PATCH v3 2/3] hwrng: exynos - add Samsung Exynos True RNG driver Łukasz Stelmach
2017-12-04 13:19   ` Krzysztof Kozlowski
2017-12-22  8:24   ` Herbert Xu
2017-12-22  8:29     ` Marek Szyprowski
2017-12-22  8:35       ` Herbert Xu
     [not found]         ` <CGME20171222124132eucas1p281d0ae6925ec5358baa3bbbc4e35b628@eucas1p2.samsung.com>
2017-12-22 12:41           ` Łukasz Stelmach
     [not found]   ` <CGME20171222132349eucas1p2270e45b81c9d77cb09addfd769877098@eucas1p2.samsung.com>
2017-12-22 13:23     ` [PATCH v4] " Łukasz Stelmach
2017-12-22 13:34       ` Philippe Ombredanne
     [not found]         ` <CGME20171222163901eucas1p253c4258fb141ea955c40185cd2f38197@eucas1p2.samsung.com>
2017-12-22 16:38           ` Łukasz Stelmach
2017-12-22 18:30             ` Philippe Ombredanne
     [not found]               ` <CGME20171227101226eucas1p2baa0309227b8e6a1e77dd7ca88f6412b@eucas1p2.samsung.com>
2017-12-27 10:12                 ` Łukasz Stelmach
2017-12-27 21:51                   ` Philippe Ombredanne
     [not found]       ` <CGME20171222164840eucas1p17e3d17666ba3d0c5fced2d1c9259bf0b@eucas1p1.samsung.com>
2017-12-22 16:48         ` [PATCH v5] " Łukasz Stelmach
2017-12-22 18:31           ` Philippe Ombredanne
2018-01-05 11:14           ` Herbert Xu
2017-12-04 12:53 ` [PATCH v3 3/3] ARM: dts: exynos: Add nodes for True Random Number Generator Łukasz Stelmach
2017-12-11 18:49   ` Krzysztof Kozlowski
     [not found]     ` <CGME20171212103557eucas1p202966a9335d52149ce69ef122f1758d8@eucas1p2.samsung.com>
2017-12-12 10:35       ` Łukasz Stelmach
2017-12-12 10:49         ` Krzysztof Kozlowski
     [not found]   ` <CGME20171212120906eucas1p23883590efde24a67800473b0d34871e5@eucas1p2.samsung.com>
2017-12-12 12:09     ` [PATCH v4] " Łukasz Stelmach
2017-12-12 17:44       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171204125351.26805-1-l.stelmach@samsung.com \
    --to=l.stelmach@samsung.com \
    --cc=afd@ti.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mpm@selenic.com \
    --cc=prasannatsmkumar@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).