From: "Łukasz Stelmach" <l.stelmach@samsung.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
"Andrew F . Davis" <afd@ti.com>,
PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Matt Mackall <mpm@selenic.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v3 2/3] hwrng: exynos - add Samsung Exynos True RNG driver
Date: Fri, 22 Dec 2017 13:41:18 +0100 [thread overview]
Message-ID: <878tdvhr4h.fsf%l.stelmach@samsung.com> (raw)
In-Reply-To: <20171222083551.GF29663@gondor.apana.org.au>
[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]
It was <2017-12-22 pią 09:35>, when Herbert Xu wrote:
> On Fri, Dec 22, 2017 at 09:29:38AM +0100, Marek Szyprowski wrote:
>> Hi,
>>
>> On 2017-12-22 09:24, Herbert Xu wrote:
>> >On Mon, Dec 04, 2017 at 01:53:50PM +0100, Łukasz Stelmach wrote:
>> >>Add support for True Random Number Generator found in Samsung Exynos
>> >>5250+ SoCs.
>> >>
>> >>Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
>> >This doesn't build for me:
>> >
>> > CC [M] drivers/char/hw_random/exynos-trng.o
>> >../drivers/char/hw_random/exynos-trng.c:230:1: error: \u2018exynos_rng_dt_match\u2019 undeclared here (not in a function)
>> >../drivers/char/hw_random/exynos-trng.c:230:1: error: \u2018__mod_of__exynos_rng_dt_match_device_table\u2019 aliased to undefined symbol \u2018exynos_rng_dt_match\u2019
>> >make[2]: *** [drivers/char/hw_random/exynos-trng.o] Error 1
>> >make[1]: *** [_module_drivers/char/hw_random] Error 2
>>
>> This looks like a missing dependency on "OF" when "COMPILE_TEST" is
>> selected.
>
> Actually it looks like a typo. The variable is actually called
> exynos_trng_dt_match as opposed to exynos_rng_dt_match.
Indeed. Honestly, I haven't seen this problem, not even once. Right, I
have never compiled it as a module. Thanks for spotting.
--
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]
next prev parent reply other threads:[~2017-12-22 12:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171204120429.22892-1-l.stelmach@samsung.com>
[not found] ` <CGME20171204125413eucas1p17e7b90e3eab244e716ea3b0023ff9a41@eucas1p1.samsung.com>
2017-12-04 12:53 ` [PATCH v3 0/3] True RNG driver for Samsung Exynos 5250+ SoCs Łukasz Stelmach
2017-12-04 12:53 ` [PATCH v3 1/3] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings Łukasz Stelmach
2017-12-04 13:13 ` Krzysztof Kozlowski
[not found] ` <CGME20171205093028eucas1p1fb6d7b8bde6cd5e3a0bfca8ddafe8a31@eucas1p1.samsung.com>
2017-12-05 9:30 ` Łukasz Stelmach
2017-12-05 10:04 ` Krzysztof Kozlowski
2017-12-04 20:27 ` Rob Herring
2017-12-04 12:53 ` [PATCH v3 2/3] hwrng: exynos - add Samsung Exynos True RNG driver Łukasz Stelmach
2017-12-04 13:19 ` Krzysztof Kozlowski
2017-12-22 8:24 ` Herbert Xu
2017-12-22 8:29 ` Marek Szyprowski
2017-12-22 8:35 ` Herbert Xu
[not found] ` <CGME20171222124132eucas1p281d0ae6925ec5358baa3bbbc4e35b628@eucas1p2.samsung.com>
2017-12-22 12:41 ` Łukasz Stelmach [this message]
[not found] ` <CGME20171222132349eucas1p2270e45b81c9d77cb09addfd769877098@eucas1p2.samsung.com>
2017-12-22 13:23 ` [PATCH v4] " Łukasz Stelmach
2017-12-22 13:34 ` Philippe Ombredanne
[not found] ` <CGME20171222163901eucas1p253c4258fb141ea955c40185cd2f38197@eucas1p2.samsung.com>
2017-12-22 16:38 ` Łukasz Stelmach
2017-12-22 18:30 ` Philippe Ombredanne
[not found] ` <CGME20171227101226eucas1p2baa0309227b8e6a1e77dd7ca88f6412b@eucas1p2.samsung.com>
2017-12-27 10:12 ` Łukasz Stelmach
2017-12-27 21:51 ` Philippe Ombredanne
[not found] ` <CGME20171222164840eucas1p17e3d17666ba3d0c5fced2d1c9259bf0b@eucas1p1.samsung.com>
2017-12-22 16:48 ` [PATCH v5] " Łukasz Stelmach
2017-12-22 18:31 ` Philippe Ombredanne
2018-01-05 11:14 ` Herbert Xu
2017-12-04 12:53 ` [PATCH v3 3/3] ARM: dts: exynos: Add nodes for True Random Number Generator Łukasz Stelmach
2017-12-11 18:49 ` Krzysztof Kozlowski
[not found] ` <CGME20171212103557eucas1p202966a9335d52149ce69ef122f1758d8@eucas1p2.samsung.com>
2017-12-12 10:35 ` Łukasz Stelmach
2017-12-12 10:49 ` Krzysztof Kozlowski
[not found] ` <CGME20171212120906eucas1p23883590efde24a67800473b0d34871e5@eucas1p2.samsung.com>
2017-12-12 12:09 ` [PATCH v4] " Łukasz Stelmach
2017-12-12 17:44 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tdvhr4h.fsf%l.stelmach@samsung.com \
--to=l.stelmach@samsung.com \
--cc=afd@ti.com \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mpm@selenic.com \
--cc=prasannatsmkumar@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).