* [PATCH v2] perf tools: set browser mode right before setup_browser()
@ 2017-12-04 16:02 Seokho Song
2017-12-06 16:44 ` [tip:perf/core] perf report: Set " tip-bot for Seokho Song
0 siblings, 1 reply; 2+ messages in thread
From: Seokho Song @ 2017-12-04 16:02 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Jiri Olsa, Namhyung Kim, Seokho Song, Park Ju Hyung
There are codes that print messages to the screen between assignment
of the use_browser variable and setup_browser().
But since the GUI browser is not initialized during that period,
all messages fail to show if the user passed the --gtk option
to perf as GTK is not initialized yet.
Reorder the code to assign use_browser variable right before
setup_browser() is called.
Acked-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Seokho Song <0xdevssh@gmail.com>
Signed-off-by: Park Ju Hyung <qkrwngud825@gmail.com>
---
tools/perf/builtin-report.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 1394cd8d96f7..c763390084b9 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -918,13 +918,6 @@ int cmd_report(int argc, const char **argv)
return -EINVAL;
}
- if (report.use_stdio)
- use_browser = 0;
- else if (report.use_tui)
- use_browser = 1;
- else if (report.use_gtk)
- use_browser = 2;
-
if (report.inverted_callchain)
callchain_param.order = ORDER_CALLER;
if (symbol_conf.cumulate_callchain && !callchain_param.order_set)
@@ -1011,6 +1004,13 @@ int cmd_report(int argc, const char **argv)
perf_hpp_list.need_collapse = true;
}
+ if (report.use_stdio)
+ use_browser = 0;
+ else if (report.use_tui)
+ use_browser = 1;
+ else if (report.use_gtk)
+ use_browser = 2;
+
/* Force tty output for header output and per-thread stat. */
if (report.header || report.header_only || report.show_threads)
use_browser = 0;
--
2.15.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:perf/core] perf report: Set browser mode right before setup_browser()
2017-12-04 16:02 [PATCH v2] perf tools: set browser mode right before setup_browser() Seokho Song
@ 2017-12-06 16:44 ` tip-bot for Seokho Song
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Seokho Song @ 2017-12-06 16:44 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, jolsa, mingo, 0xdevssh, namhyung, qkrwngud825,
linux-kernel, tglx, hpa
Commit-ID: 712d36db5a5c57eb79e962a0f9b85964640e8415
Gitweb: https://git.kernel.org/tip/712d36db5a5c57eb79e962a0f9b85964640e8415
Author: Seokho Song <0xdevssh@gmail.com>
AuthorDate: Tue, 5 Dec 2017 01:02:44 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 5 Dec 2017 15:43:56 -0300
perf report: Set browser mode right before setup_browser()
There are codes that print messages to the screen between assignment of
the use_browser variable and setup_browser().
But since the GUI browser is not initialized during that period, all
messages fail to show if the user passed the --gtk option to perf as GTK
is not initialized yet.
Reorder the code to assign use_browser variable right before
setup_browser() is called.
Signed-off-by: Seokho Song <0xdevssh@gmail.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/20171204160244.6332-1-0xdevssh@gmail.com
Signed-off-by: Park Ju Hyung <qkrwngud825@gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-report.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index af5dd03..eb9ce63 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -921,13 +921,6 @@ int cmd_report(int argc, const char **argv)
return -EINVAL;
}
- if (report.use_stdio)
- use_browser = 0;
- else if (report.use_tui)
- use_browser = 1;
- else if (report.use_gtk)
- use_browser = 2;
-
if (report.inverted_callchain)
callchain_param.order = ORDER_CALLER;
if (symbol_conf.cumulate_callchain && !callchain_param.order_set)
@@ -1014,6 +1007,13 @@ repeat:
perf_hpp_list.need_collapse = true;
}
+ if (report.use_stdio)
+ use_browser = 0;
+ else if (report.use_tui)
+ use_browser = 1;
+ else if (report.use_gtk)
+ use_browser = 2;
+
/* Force tty output for header output and per-thread stat. */
if (report.header || report.header_only || report.show_threads)
use_browser = 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-06 16:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-04 16:02 [PATCH v2] perf tools: set browser mode right before setup_browser() Seokho Song
2017-12-06 16:44 ` [tip:perf/core] perf report: Set " tip-bot for Seokho Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).