From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: Denys Zagorui <dzagorui@cisco.com>
Cc: gregkh@linuxfoundation.org, jslaby@suse.com,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] serial: 8250: convert to threaded IRQ
Date: Thu, 7 Dec 2017 14:45:09 +0000 [thread overview]
Message-ID: <20171207144509.482b3e45@alans-desktop> (raw)
In-Reply-To: <20171204152627.23906-1-dzagorui@cisco.com>
On Mon, 4 Dec 2017 17:26:27 +0200
Denys Zagorui <dzagorui@cisco.com> wrote:
> During using virtualization it is common to see
> many "too much work for irq*" messages.
Your emulator is buggy.
NAK
You are adding a ton of overhead to an absolutely performance critical
path on real hardware. We absolutely cannot have 16450 or 16550A UARTS
being serviced via a threaded IRQ.
Fix your emulator. You are getting the problem because your serial port
emulation isn't doing timing correct queueing of characters. If you are
modelling 115,200 baud then don't queue characters faster than that or
batch them excessively. We went to 512 as the pass limit to allow
virtualization layers to get this right more easily as you don't have to
do timing on tiny batches.
(And if you need performance of any kind stop using the uart emulation
and use virtio)
Alan
prev parent reply other threads:[~2017-12-07 14:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 15:26 [PATCH v3] serial: 8250: convert to threaded IRQ Denys Zagorui
2017-12-07 14:45 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207144509.482b3e45@alans-desktop \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=dzagorui@cisco.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).