From: "Simon Sandström" <simon@nikanor.nu>
To: gregkh@linuxfoundation.org
Cc: marcin.s.ciupak@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] staging: pi433: Refactor usage of dev_dbg and #ifdef DEBUG
Date: Sat, 9 Dec 2017 19:02:54 +0100 [thread overview]
Message-ID: <20171209180257.24240-1-simon@nikanor.nu> (raw)
These patches refactors the usage of dev_dbg and #ifdef DEBUG in rf69.c.
All dev_dbg() calls that just prints the function name are removed, since
we have ftrace. For all other calls the #ifdef DEBUG block around them are
removed.
There are still two more defines used in rf69.c: DEBUG_FIFO_ACCESS and
DEBUG_VALUES. Perhaps they should be removed as well?
- Simon
---
Simon Sandström (3):
staging: pi433: Remove indentation on #ifdef blocks
staging: pi433: Remove function entry dev_dbg()
staging: pi433: Remove unnecessary #ifdef DEBUG around dev_dbg
drivers/staging/pi433/rf69.c | 232 ++++++-------------------------------------
1 file changed, 32 insertions(+), 200 deletions(-)
--
2.11.0
next reply other threads:[~2017-12-09 18:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-09 18:02 Simon Sandström [this message]
2017-12-09 18:02 ` [PATCH 1/3] staging: pi433: Remove indentation on #ifdef blocks Simon Sandström
2017-12-09 18:02 ` [PATCH 2/3] staging: pi433: Remove function entry dev_dbg() Simon Sandström
2017-12-09 18:02 ` [PATCH 3/3] staging: pi433: Remove unnecessary #ifdef DEBUG around dev_dbg Simon Sandström
2017-12-09 18:08 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171209180257.24240-1-simon@nikanor.nu \
--to=simon@nikanor.nu \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.s.ciupak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).