linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Simon Sandström" <simon@nikanor.nu>
To: gregkh@linuxfoundation.org
Cc: marcin.s.ciupak@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] staging: pi433: Remove unnecessary #ifdef DEBUG around dev_dbg
Date: Sat,  9 Dec 2017 19:02:57 +0100	[thread overview]
Message-ID: <20171209180257.24240-4-simon@nikanor.nu> (raw)
In-Reply-To: <20171209180257.24240-1-simon@nikanor.nu>

dev_dbg() already depends on DEBUG.

Signed-off-by: Simon Sandström <simon@nikanor.nu>
---
 drivers/staging/pi433/rf69.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index 04a74423c325..6e38e6a515a4 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -767,9 +767,7 @@ int rf69_read_fifo (struct spi_device *spi, u8 *buffer, unsigned int size)
 	int retval;
 
 	if (size > FIFO_SIZE) {
-#ifdef DEBUG
 		dev_dbg(&spi->dev, "read fifo: passed in buffer bigger then internal buffer\n");
-#endif
 		return -EMSGSIZE;
 	}
 
@@ -801,9 +799,7 @@ int rf69_write_fifo(struct spi_device *spi, u8 *buffer, unsigned int size)
 	u8 local_buffer[FIFO_SIZE + 1];
 
 	if (size > FIFO_SIZE) {
-#ifdef DEBUG
 		dev_dbg(&spi->dev, "read fifo: passed in buffer bigger then internal buffer\n");
-#endif
 		return -EMSGSIZE;
 	}
 
-- 
2.11.0

  parent reply	other threads:[~2017-12-09 18:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-09 18:02 [PATCH 0/3] staging: pi433: Refactor usage of dev_dbg and #ifdef DEBUG Simon Sandström
2017-12-09 18:02 ` [PATCH 1/3] staging: pi433: Remove indentation on #ifdef blocks Simon Sandström
2017-12-09 18:02 ` [PATCH 2/3] staging: pi433: Remove function entry dev_dbg() Simon Sandström
2017-12-09 18:02 ` Simon Sandström [this message]
2017-12-09 18:08   ` [PATCH 3/3] staging: pi433: Remove unnecessary #ifdef DEBUG around dev_dbg Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171209180257.24240-4-simon@nikanor.nu \
    --to=simon@nikanor.nu \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.s.ciupak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).