From: Daniel Vetter <daniel@ffwll.ch>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
LKML <linux-kernel@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
Marta Lofstedt <marta.lofstedt@intel.com>,
Byungchul Park <byungchul.park@lge.com>,
Ingo Molnar <mingo@kernel.org>, Tejun Heo <tj@kernel.org>,
Kees Cook <keescook@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>, Shaohua Li <shli@fb.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>, Oleg Nesterov <oleg@redhat.com>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] kthread: finer-grained lockdep/cross-release completion
Date: Mon, 11 Dec 2017 10:19:28 +0100 [thread overview]
Message-ID: <20171211091928.cpw3srz2rddmruxj@phenom.ffwll.local> (raw)
In-Reply-To: <20171208105419.jdzene5wrsriwm2n@hirez.programming.kicks-ass.net>
On Fri, Dec 08, 2017 at 11:54:19AM +0100, Peter Zijlstra wrote:
> On Thu, Dec 07, 2017 at 11:08:49AM +0100, Daniel Vetter wrote:
> > Since -rc1 we're hitting a bunch of lockdep splats using the new
> > cross-release stuff around the 2 kthread completions. In all cases
> > they are because totally independent uses of kthread are mixed up by
> > lockdep into the same locking class, creating artificial deadlocks.
> >
> > Fix this by converting kthread code in the same way as e.g.
> > alloc_workqueue already works: Use macros for the public api so we can
> > have a callsite specific lockdep key, then pass that through the
> > entire callchain. Due to the many entry points this is slightly
> > tedious.
> >
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Cc: Marta Lofstedt <marta.lofstedt@intel.com>
> > Cc: Byungchul Park <byungchul.park@lge.com>
> > Cc: Ingo Molnar <mingo@kernel.org>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Tejun Heo <tj@kernel.org>
> > Cc: Kees Cook <keescook@chromium.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Shaohua Li <shli@fb.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Jens Axboe <axboe@kernel.dk>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Jonathan Corbet <corbet@lwn.net>
> > Cc: Oleg Nesterov <oleg@redhat.com>
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=103950
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Who's going to pick this up? Ingo, Andrew?
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2017-12-11 9:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 10:08 [PATCH] kthread: finer-grained lockdep/cross-release completion Daniel Vetter
2017-12-07 12:22 ` Peter Zijlstra
2017-12-07 14:58 ` Daniel Vetter
2017-12-07 19:57 ` Peter Zijlstra
2017-12-07 20:56 ` [Intel-gfx] " Daniel Vetter
2017-12-08 10:14 ` Peter Zijlstra
2017-12-08 16:36 ` Daniel Vetter
2017-12-08 18:40 ` Peter Zijlstra
2017-12-08 10:54 ` Peter Zijlstra
2017-12-11 9:19 ` Daniel Vetter [this message]
2017-12-18 7:11 ` Daniel Vetter
2017-12-18 17:42 ` Linus Torvalds
2017-12-19 9:59 ` Daniel Vetter
2017-12-20 1:14 ` Byungchul Park
2018-03-15 10:31 ` Daniel Vetter
2018-03-15 12:41 ` Peter Zijlstra
2018-03-15 23:26 ` Byungchul Park
2018-10-18 8:56 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211091928.cpw3srz2rddmruxj@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=byungchul.park@lge.com \
--cc=corbet@lwn.net \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marta.lofstedt@intel.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=shli@fb.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).