From: Mark Brown <broonie@kernel.org>
To: Andi Shyti <andi.shyti@samsung.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Andi Shyti <andi@etezian.org>, Kukjin Kim <kgene@kernel.org>,
linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] spi: s3c64xx: add SPDX identifier
Date: Wed, 13 Dec 2017 09:38:06 +0000 [thread overview]
Message-ID: <20171213093806.GA6416@sirena.org.uk> (raw)
In-Reply-To: <20171213014854.GG20051@gangnam.samsung>
[-- Attachment #1: Type: text/plain, Size: 581 bytes --]
On Wed, Dec 13, 2017 at 10:48:54AM +0900, Andi Shyti wrote:
> > > +//
> > > +// Copyright (c) 2009 Samsung Electronics Co., Ltd.
> > > +// Jaswinder Singh <jassi.brar@samsung.com>
> it just looks ugly to me to have something like
> // SPDX...
> /*
> * Copyright (c)...
> * Jasw...
> */
> I would make everything of the '//' style (I've also seen that
> this is the trend also in other subsystems), but honestly I don't
> really care. If you're strong on not moving entirely in '//' style
Yes, my preference is to avoid a mixture like you've got there.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2017-12-13 9:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171212075830epcas2p31afc4a2e715e857694082748fd2bbe49@epcas2p3.samsung.com>
2017-12-12 7:58 ` [PATCH] spi: s3c64xx: add SPDX identifier Andi Shyti
2017-12-12 9:17 ` Krzysztof Kozlowski
2017-12-12 10:07 ` Mark Brown
2017-12-12 10:13 ` Krzysztof Kozlowski
2017-12-12 10:31 ` Mark Brown
2017-12-12 13:03 ` Andi Shyti
2017-12-12 13:45 ` Krzysztof Kozlowski
2017-12-12 14:48 ` Philippe Ombredanne
2017-12-12 15:00 ` Krzysztof Kozlowski
2017-12-12 15:24 ` Philippe Ombredanne
2017-12-12 15:35 ` Krzysztof Kozlowski
2017-12-13 1:48 ` Andi Shyti
2017-12-13 7:23 ` Krzysztof Kozlowski
2017-12-13 9:38 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213093806.GA6416@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=gregkh@linuxfoundation.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).