From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Andi Shyti <andi.shyti@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH] spi: s3c64xx: add SPDX identifier
Date: Tue, 12 Dec 2017 11:13:26 +0100 [thread overview]
Message-ID: <CAJKOXPdM+C_JWOiqT8obEAsEsGJ1GvJMG=o2Kq0TCiOwdmZOxw@mail.gmail.com> (raw)
In-Reply-To: <20171212100730.GA16323@sirena.org.uk>
On Tue, Dec 12, 2017 at 11:07 AM, Mark Brown <broonie@kernel.org> wrote:
> On Tue, Dec 12, 2017 at 10:17:09AM +0100, Krzysztof Kozlowski wrote:
>> On Tue, Dec 12, 2017 at 8:58 AM, Andi Shyti <andi.shyti@samsung.com> wrote:
>
>> > +// SPDX-License-Identifier: GPL-2.0
>
>> Why changing the comment style?
>
> Apparently that's the thing for SPDX headers.
Yes (although in sources one can find /* */ as well) but the rest of
comment does not have to be changed in that case. With quick grep
through sources I could not find such practice.
Best regards,
Krzysztof
next prev parent reply other threads:[~2017-12-12 10:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171212075830epcas2p31afc4a2e715e857694082748fd2bbe49@epcas2p3.samsung.com>
2017-12-12 7:58 ` [PATCH] spi: s3c64xx: add SPDX identifier Andi Shyti
2017-12-12 9:17 ` Krzysztof Kozlowski
2017-12-12 10:07 ` Mark Brown
2017-12-12 10:13 ` Krzysztof Kozlowski [this message]
2017-12-12 10:31 ` Mark Brown
2017-12-12 13:03 ` Andi Shyti
2017-12-12 13:45 ` Krzysztof Kozlowski
2017-12-12 14:48 ` Philippe Ombredanne
2017-12-12 15:00 ` Krzysztof Kozlowski
2017-12-12 15:24 ` Philippe Ombredanne
2017-12-12 15:35 ` Krzysztof Kozlowski
2017-12-13 1:48 ` Andi Shyti
2017-12-13 7:23 ` Krzysztof Kozlowski
2017-12-13 9:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPdM+C_JWOiqT8obEAsEsGJ1GvJMG=o2Kq0TCiOwdmZOxw@mail.gmail.com' \
--to=krzk@kernel.org \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=broonie@kernel.org \
--cc=kgene@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).