From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Niklas Cassel <niklas.cassel@axis.com>, kishon@ti.com
Cc: linux-pci@vger.kernel.org, Niklas Cassel <niklass@axis.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/3] Fix find_first_zero_bit() usage
Date: Thu, 14 Dec 2017 10:51:16 +0000 [thread overview]
Message-ID: <20171214105116.GA1442@e107981-ln.cambridge.arm.com> (raw)
In-Reply-To: <20171212141634.5985-1-niklas.cassel@axis.com>
Hi Kishon,
On Tue, Dec 12, 2017 at 03:16:31PM +0100, Niklas Cassel wrote:
> find_first_zero_bit()'s parameter 'size' is defined in bits,
> not in bytes.
>
> Calling find_first_zero_bit() with the wrong size unit
> will lead to insidious bugs.
>
> Fix all uses of find_first_zero_bit() called with
> sizeof() as size argument in drivers/pci.
>
> Also had to fix broken error handling in pci_epc_epf_link()
> in order to do proper error handling for find_first_zero_bit().
>
> Niklas Cassel (3):
> PCI: designware-ep: Fix find_first_zero_bit() usage
> PCI: endpoint: Fix error handling in pci_epc_epf_link()
> PCI: endpoint: Fix find_first_zero_bit() usage
>
> drivers/pci/dwc/pcie-designware-ep.c | 34 ++++++++++++++++++++++++++--------
> drivers/pci/dwc/pcie-designware.h | 8 ++++++--
> drivers/pci/endpoint/pci-ep-cfs.c | 13 ++++++++-----
> 3 files changed, 40 insertions(+), 15 deletions(-)
I would need your ACK asap to queue this series.
Thanks,
Lorenzo
next prev parent reply other threads:[~2017-12-14 10:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 14:16 [PATCH v4 0/3] Fix find_first_zero_bit() usage Niklas Cassel
2017-12-12 14:16 ` [PATCH v4 1/3] PCI: designware-ep: " Niklas Cassel
2017-12-14 11:03 ` Kishon Vijay Abraham I
2017-12-12 14:16 ` [PATCH v4 2/3] PCI: endpoint: Fix error handling in pci_epc_epf_link() Niklas Cassel
2017-12-14 11:07 ` Kishon Vijay Abraham I
2017-12-14 12:07 ` Lorenzo Pieralisi
2017-12-14 12:13 ` Kishon Vijay Abraham I
2017-12-12 14:16 ` [PATCH v4 3/3] PCI: endpoint: Fix find_first_zero_bit() usage Niklas Cassel
2017-12-14 11:09 ` Kishon Vijay Abraham I
2017-12-12 14:33 ` [PATCH v4 0/3] " David Laight
2017-12-12 15:24 ` Lorenzo Pieralisi
2017-12-12 15:39 ` David Laight
2017-12-13 21:59 ` Bjorn Helgaas
2017-12-14 13:32 ` Niklas Cassel
2017-12-14 13:47 ` Lorenzo Pieralisi
2017-12-14 23:21 ` Bjorn Helgaas
2017-12-15 9:42 ` Lorenzo Pieralisi
2017-12-14 10:51 ` Lorenzo Pieralisi [this message]
2017-12-14 11:25 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214105116.GA1442@e107981-ln.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=niklas.cassel@axis.com \
--cc=niklass@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).