From: Bjorn Helgaas <helgaas@kernel.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Niklas Cassel <niklas.cassel@axis.com>,
linux-pci@vger.kernel.org, kishon@ti.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/3] Fix find_first_zero_bit() usage
Date: Thu, 14 Dec 2017 17:21:38 -0600 [thread overview]
Message-ID: <20171214232138.GO30595@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20171214134707.GE27348@e107981-ln.cambridge.arm.com>
On Thu, Dec 14, 2017 at 01:47:07PM +0000, Lorenzo Pieralisi wrote:
> On Thu, Dec 14, 2017 at 02:32:30PM +0100, Niklas Cassel wrote:
> > On Wed, Dec 13, 2017 at 03:59:25PM -0600, Bjorn Helgaas wrote:
> > > On Tue, Dec 12, 2017 at 03:16:31PM +0100, Niklas Cassel wrote:
> > > > find_first_zero_bit()'s parameter 'size' is defined in bits,
> > > > not in bytes.
> > > >
> > > > Calling find_first_zero_bit() with the wrong size unit
> > > > will lead to insidious bugs.
> > > >
> > > > Fix all uses of find_first_zero_bit() called with
> > > > sizeof() as size argument in drivers/pci.
> > > >
> > > > Also had to fix broken error handling in pci_epc_epf_link()
> > > > in order to do proper error handling for find_first_zero_bit().
> > > >
> > > > Niklas Cassel (3):
> > > > PCI: designware-ep: Fix find_first_zero_bit() usage
> > > > PCI: endpoint: Fix error handling in pci_epc_epf_link()
> > > > PCI: endpoint: Fix find_first_zero_bit() usage
> > > >
> > > > drivers/pci/dwc/pcie-designware-ep.c | 34 ++++++++++++++++++++++++++--------
> > > > drivers/pci/dwc/pcie-designware.h | 8 ++++++--
> > > > drivers/pci/endpoint/pci-ep-cfs.c | 13 ++++++++-----
> > > > 3 files changed, 40 insertions(+), 15 deletions(-)
> > >
> > > In the interest of making forward progress, I applied these to
> > > for-linus for v4.15.
> > >
> > > The issues apparently have been there since v4.12-rc1, but I guess
> > > this is proposed for for-linus because (a) it fixes insidious bugs
> > > and (b) the endpoint framework is relatively little-used yet so
> > > low-risk. Right?
> > >
> >
> > Hello Bjorn,
> >
> > As far as I know, dra7xx is the only in-tree user of the endpoint
> > framework. Therefore, I see no real need to rush these patches.
> >
> > One benefit of sending them to v4.15 would be if anyone starts
> > developing endpoint support for their driver (with v4.15 as a base),
> > we eliminate the risk that they might get hit by these bugs, and
> > potentially waste time finding bugs that have already been found.
> >
> > Please note that Kishon had some last minute review comments,
> > so I had to submit a V5 of the patch series.
>
> I missed this message (please CC me on the cover letter too next time) I
> hope Bjorn can drop v4 and replace it with v5 - or I can just queue v5
> for v4.16 - just let me know please how you want to handle it.
I dropped them from my for-linus tree. Lorenzo, can you take care of
v5 for v4.16?
Thanks!
next prev parent reply other threads:[~2017-12-14 23:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 14:16 [PATCH v4 0/3] Fix find_first_zero_bit() usage Niklas Cassel
2017-12-12 14:16 ` [PATCH v4 1/3] PCI: designware-ep: " Niklas Cassel
2017-12-14 11:03 ` Kishon Vijay Abraham I
2017-12-12 14:16 ` [PATCH v4 2/3] PCI: endpoint: Fix error handling in pci_epc_epf_link() Niklas Cassel
2017-12-14 11:07 ` Kishon Vijay Abraham I
2017-12-14 12:07 ` Lorenzo Pieralisi
2017-12-14 12:13 ` Kishon Vijay Abraham I
2017-12-12 14:16 ` [PATCH v4 3/3] PCI: endpoint: Fix find_first_zero_bit() usage Niklas Cassel
2017-12-14 11:09 ` Kishon Vijay Abraham I
2017-12-12 14:33 ` [PATCH v4 0/3] " David Laight
2017-12-12 15:24 ` Lorenzo Pieralisi
2017-12-12 15:39 ` David Laight
2017-12-13 21:59 ` Bjorn Helgaas
2017-12-14 13:32 ` Niklas Cassel
2017-12-14 13:47 ` Lorenzo Pieralisi
2017-12-14 23:21 ` Bjorn Helgaas [this message]
2017-12-15 9:42 ` Lorenzo Pieralisi
2017-12-14 10:51 ` Lorenzo Pieralisi
2017-12-14 11:25 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214232138.GO30595@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=niklas.cassel@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).