From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Chen.Liu" <chen.liu.opensource@gmail.com>, <lgirdwood@gmail.com>,
<perex@perex.cz>, <tiwai@suse.com>, <shengjiu.wang@freescale.com>,
<patches@opensource.wolfsonmicro.com>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
<daniel.baluta@nxp.com>
Subject: Re: [PATCH v2] ASOC: wm8960: Add multiple MCLK frequency support
Date: Thu, 14 Dec 2017 15:51:51 +0000 [thread overview]
Message-ID: <20171214155151.gfauoqjwomhadibh@localhost.localdomain> (raw)
In-Reply-To: <20171214153139.GG9788@sirena.org.uk>
On Thu, Dec 14, 2017 at 03:31:39PM +0000, Mark Brown wrote:
> On Thu, Dec 14, 2017 at 11:56:48AM +0000, Charles Keepax wrote:
> > On Wed, Dec 13, 2017 at 08:37:30PM +0800, Chen.Liu wrote:
>
> > > + if (unsupported)
> > > + snd_soc_update_bits(codec, WM8960_CLOCK1, 0x6,
> > > + WM8960_SYSCLK_DIV_2);
> > > +
>
> > Looking at this a bit more I do have some reservations. Firstly
> > this divider can be set through wm8960_set_dai_clkdiv, and
> > secondly it is also set at the bottom of
>
> Removing set_clkdiv() would be a better thing if there were conflicts
> here, in general we're trying to avoid uses of it.
Ok that can probably be done as a separate patch I will review
again with that in mind.
Thanks,
Charles
next prev parent reply other threads:[~2017-12-14 15:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 12:37 [PATCH v2] ASOC: wm8960: Add multiple MCLK frequency support Chen.Liu
2017-12-14 11:56 ` Charles Keepax
2017-12-14 15:31 ` Mark Brown
2017-12-14 15:51 ` Charles Keepax [this message]
2017-12-14 16:45 ` Mark Brown
2017-12-14 16:19 ` Charles Keepax
[not found] ` <CACJSzi0Kuknj6xFpambi87a1cXecGdfNGQ7PpgywwZV=9_U1yA@mail.gmail.com>
2017-12-18 9:31 ` Charles Keepax
[not found] ` <CACJSzi13ZdOjvz1A2YFbE3z0nUPjeC7i5Dh+ZTnsQH55ON=YMA@mail.gmail.com>
2017-12-18 11:55 ` Charles Keepax
[not found] ` <CACJSzi0hbv2p_6dXkp2AFwyYVzmU6_H56LgJxY70_ZKn2y=aUw@mail.gmail.com>
2017-12-21 16:48 ` Charles Keepax
2017-12-22 10:40 ` chen liu
2017-12-29 11:05 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214155151.gfauoqjwomhadibh@localhost.localdomain \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=chen.liu.opensource@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=shengjiu.wang@freescale.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).