From: chen liu <chen.liu.opensource@gmail.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
shengjiu.wang@freescale.com, linux-kernel@vger.kernel.org,
daniel.baluta@nxp.com, patches@opensource.wolfsonmicro.com,
alsa-devel@alsa-project.org
Subject: Re: [PATCH v2] ASOC: wm8960: Add multiple MCLK frequency support
Date: Fri, 22 Dec 2017 18:40:04 +0800 [thread overview]
Message-ID: <CACJSzi0DjUTrbNOH4ykg=3uD=6+TuMdNB7ku_KhQOGLLbgOSWQ@mail.gmail.com> (raw)
In-Reply-To: <20171221164810.ocdl3im5gy3mipmn@localhost.localdomain>
2017-12-22 0:48 GMT+08:00 Charles Keepax <ckeepax@opensource.cirrus.com>:
> On Tue, Dec 19, 2017 at 02:19:48PM +0800, chen liu wrote:
>> 2017-12-18 19:55 GMT+08:00 Charles Keepax <ckeepax@opensource.cirrus.com>:
>> > On Mon, Dec 18, 2017 at 07:32:41PM +0800, chen liu wrote:
>> > > 2017-12-18 17:31 GMT+08:00 Charles Keepax <ckeepax@opensource.cirrus.com
>> > > > On Fri, Dec 15, 2017 at 09:07:15PM +0800, chen liu wrote:
>> > > > > 2017-12-15 0:19 GMT+08:00 Charles Keepax <
>> > ckeepax@opensource.cirrus.com
>> > > > > > On Wed, Dec 13, 2017 at 08:37:30PM +0800, Chen.Liu wrote:
> One thing I don't understand though is it looks like the freq_out
> returned from wm8960_configure_pll should already be taking the
> SYSCLK_DIV into account:
>
> for (j = 0; j < ARRAY_SIZE(dac_divs); ++j) {
> sysclk = lrclk * dac_divs[j];
> freq_out = sysclk * sysclk_divs[i];
>
> So if lrclk=44100, j=0, i=2 which I believe is the case in
> question we should get:
>
> sysclk = 44100 * 256 = 11.2896MHz
> freq_out = 11.2896MHz * 2 = 22.5792MHz
>
> So when wm8960_configure_pll returns i=2 then it should also be
> setting freq_out as 22.5792MHz. So you final call there to
> wm8960_set_pll should be:
Hi Charles,
You are right.
This problem seems to affect only the clock frequency configured in
manual mode.
Because i'm directly calling the 'snd_soc_dai_set_pll' function in the
machine driver,the driver will prompts ''WM8960 PLL: Unsupported N"
error message.
The following code is part of how i configured the clock frequency in the
machine driver:
======================================================
+ if (params_rate(params) == 44100)
+ pll_out = 11289600;
+ else
+ pll_out = 12288000;
+
+ ret = snd_soc_dai_set_pll(codec_dai, WM8960_SYSCLK_PLL, 0,
+
data->clk_frequency, pll_out);
======================================================
On the other hand,i think if the codec support these MCLK clock frequency
in the manual,so no matter use manual mode and automatic mode to
configure the clock frequency,the driver prompt errors is very bad.
Thanks again,
Chen.
next prev parent reply other threads:[~2017-12-22 10:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 12:37 [PATCH v2] ASOC: wm8960: Add multiple MCLK frequency support Chen.Liu
2017-12-14 11:56 ` Charles Keepax
2017-12-14 15:31 ` Mark Brown
2017-12-14 15:51 ` Charles Keepax
2017-12-14 16:45 ` Mark Brown
2017-12-14 16:19 ` Charles Keepax
[not found] ` <CACJSzi0Kuknj6xFpambi87a1cXecGdfNGQ7PpgywwZV=9_U1yA@mail.gmail.com>
2017-12-18 9:31 ` Charles Keepax
[not found] ` <CACJSzi13ZdOjvz1A2YFbE3z0nUPjeC7i5Dh+ZTnsQH55ON=YMA@mail.gmail.com>
2017-12-18 11:55 ` Charles Keepax
[not found] ` <CACJSzi0hbv2p_6dXkp2AFwyYVzmU6_H56LgJxY70_ZKn2y=aUw@mail.gmail.com>
2017-12-21 16:48 ` Charles Keepax
2017-12-22 10:40 ` chen liu [this message]
2017-12-29 11:05 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACJSzi0DjUTrbNOH4ykg=3uD=6+TuMdNB7ku_KhQOGLLbgOSWQ@mail.gmail.com' \
--to=chen.liu.opensource@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=daniel.baluta@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=shengjiu.wang@freescale.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).