* [PATCH 0/3] thunderbolt fixes for v4.15-rc2 @ 2017-12-01 12:08 Mika Westerberg 2017-12-01 12:08 ` [PATCH 1/3] thunderbolt: Make pathname to force_power shorter Mika Westerberg ` (3 more replies) 0 siblings, 4 replies; 8+ messages in thread From: Mika Westerberg @ 2017-12-01 12:08 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Mika Westerberg, linux-kernel Hi Greg, Here are two Thunderbolt fixes and one related MAINTAINERS update for the next -rc: - Use shorter path for force_power attribute in thunderbolt.rst - Ring interrupts were not masked properly when Rx polling starts - Add thunderbolt.rst to the Thunderbolt driver MAINTAINERS entry Thanks! Andy Shevchenko (1): thunderbolt: Make pathname to force_power shorter Mika Westerberg (2): MAINTAINERS: Add thunderbolt.rst to the Thunderbolt driver entry thunderbolt: Mask ring interrupt properly when polling starts Documentation/admin-guide/thunderbolt.rst | 2 +- MAINTAINERS | 1 + drivers/thunderbolt/nhi.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) -- 2.15.0 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/3] thunderbolt: Make pathname to force_power shorter 2017-12-01 12:08 [PATCH 0/3] thunderbolt fixes for v4.15-rc2 Mika Westerberg @ 2017-12-01 12:08 ` Mika Westerberg 2017-12-01 12:08 ` [PATCH 2/3] MAINTAINERS: Add thunderbolt.rst to the Thunderbolt driver entry Mika Westerberg ` (2 subsequent siblings) 3 siblings, 0 replies; 8+ messages in thread From: Mika Westerberg @ 2017-12-01 12:08 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Mika Westerberg, linux-kernel, Andy Shevchenko From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> WMI is the bus inside kernel, so, we may access the GUID via /sys/bus/wmi instead of doing this through /sys/devices path. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Mario Limonciello <mario.limonciello@dell.com> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> --- Documentation/admin-guide/thunderbolt.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/admin-guide/thunderbolt.rst b/Documentation/admin-guide/thunderbolt.rst index de50a8561774..9b55952039a6 100644 --- a/Documentation/admin-guide/thunderbolt.rst +++ b/Documentation/admin-guide/thunderbolt.rst @@ -230,7 +230,7 @@ If supported by your machine this will be exposed by the WMI bus with a sysfs attribute called "force_power". For example the intel-wmi-thunderbolt driver exposes this attribute in: - /sys/devices/platform/PNP0C14:00/wmi_bus/wmi_bus-PNP0C14:00/86CCFD48-205E-4A77-9C48-2021CBEDE341/force_power + /sys/bus/wmi/devices/86CCFD48-205E-4A77-9C48-2021CBEDE341/force_power To force the power to on, write 1 to this attribute file. To disable force power, write 0 to this attribute file. -- 2.15.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/3] MAINTAINERS: Add thunderbolt.rst to the Thunderbolt driver entry 2017-12-01 12:08 [PATCH 0/3] thunderbolt fixes for v4.15-rc2 Mika Westerberg 2017-12-01 12:08 ` [PATCH 1/3] thunderbolt: Make pathname to force_power shorter Mika Westerberg @ 2017-12-01 12:08 ` Mika Westerberg 2017-12-01 12:08 ` [PATCH 3/3] thunderbolt: Mask ring interrupt properly when polling starts Mika Westerberg 2017-12-05 8:49 ` [PATCH 0/3] thunderbolt fixes for v4.15-rc2 Mika Westerberg 3 siblings, 0 replies; 8+ messages in thread From: Mika Westerberg @ 2017-12-01 12:08 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Mika Westerberg, linux-kernel Make sure Thunderbolt maintainers get to see patches that touch documentation of the Thunderbolt driver as well. Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index aa71ab52fd76..478e4d342c2a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13471,6 +13471,7 @@ M: Mika Westerberg <mika.westerberg@linux.intel.com> M: Yehezkel Bernat <yehezkel.bernat@intel.com> T: git git://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git S: Maintained +F: Documentation/admin-guide/thunderbolt.rst F: drivers/thunderbolt/ F: include/linux/thunderbolt.h -- 2.15.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/3] thunderbolt: Mask ring interrupt properly when polling starts 2017-12-01 12:08 [PATCH 0/3] thunderbolt fixes for v4.15-rc2 Mika Westerberg 2017-12-01 12:08 ` [PATCH 1/3] thunderbolt: Make pathname to force_power shorter Mika Westerberg 2017-12-01 12:08 ` [PATCH 2/3] MAINTAINERS: Add thunderbolt.rst to the Thunderbolt driver entry Mika Westerberg @ 2017-12-01 12:08 ` Mika Westerberg 2017-12-05 8:49 ` [PATCH 0/3] thunderbolt fixes for v4.15-rc2 Mika Westerberg 3 siblings, 0 replies; 8+ messages in thread From: Mika Westerberg @ 2017-12-01 12:08 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Mika Westerberg, linux-kernel When ring enters polling mode we are expected to mask the ring interrupt before the callback is called. However, the current code actually unmasks it probably because of a copy-paste mistake. Mask the interrupt properly from now on. Fixes: 4ffe722eefcb ("thunderbolt: Add polling mode for rings") Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Acked-by: Yehezkel Bernat <yehezkel.bernat@intel.com> --- drivers/thunderbolt/nhi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c index 419a7a90bce0..f45bcbc63738 100644 --- a/drivers/thunderbolt/nhi.c +++ b/drivers/thunderbolt/nhi.c @@ -339,7 +339,7 @@ static void __ring_interrupt(struct tb_ring *ring) return; if (ring->start_poll) { - __ring_interrupt_mask(ring, false); + __ring_interrupt_mask(ring, true); ring->start_poll(ring->poll_data); } else { schedule_work(&ring->work); -- 2.15.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 0/3] thunderbolt fixes for v4.15-rc2 2017-12-01 12:08 [PATCH 0/3] thunderbolt fixes for v4.15-rc2 Mika Westerberg ` (2 preceding siblings ...) 2017-12-01 12:08 ` [PATCH 3/3] thunderbolt: Mask ring interrupt properly when polling starts Mika Westerberg @ 2017-12-05 8:49 ` Mika Westerberg 2017-12-05 8:52 ` Greg Kroah-Hartman 3 siblings, 1 reply; 8+ messages in thread From: Mika Westerberg @ 2017-12-05 8:49 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: linux-kernel On Fri, Dec 01, 2017 at 03:08:02PM +0300, Mika Westerberg wrote: > Hi Greg, > > Here are two Thunderbolt fixes and one related MAINTAINERS update for the > next -rc: > > - Use shorter path for force_power attribute in thunderbolt.rst > - Ring interrupts were not masked properly when Rx polling starts > - Add thunderbolt.rst to the Thunderbolt driver MAINTAINERS entry > > Thanks! Hi Greg, I wonder if I missed something in this series? These are fixes I picked up to my tree and then forwarded to you to be included in your char-misc repository for -rc. Thanks! ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/3] thunderbolt fixes for v4.15-rc2 2017-12-05 8:49 ` [PATCH 0/3] thunderbolt fixes for v4.15-rc2 Mika Westerberg @ 2017-12-05 8:52 ` Greg Kroah-Hartman 2017-12-16 8:50 ` Mika Westerberg 0 siblings, 1 reply; 8+ messages in thread From: Greg Kroah-Hartman @ 2017-12-05 8:52 UTC (permalink / raw) To: Mika Westerberg; +Cc: linux-kernel On Tue, Dec 05, 2017 at 10:49:13AM +0200, Mika Westerberg wrote: > On Fri, Dec 01, 2017 at 03:08:02PM +0300, Mika Westerberg wrote: > > Hi Greg, > > > > Here are two Thunderbolt fixes and one related MAINTAINERS update for the > > next -rc: > > > > - Use shorter path for force_power attribute in thunderbolt.rst > > - Ring interrupts were not masked properly when Rx polling starts > > - Add thunderbolt.rst to the Thunderbolt driver MAINTAINERS entry > > > > Thanks! > > Hi Greg, > > I wonder if I missed something in this series? These are fixes I picked > up to my tree and then forwarded to you to be included in your char-misc > repository for -rc. I was traveling all last week, please give me a chance to catch up on patches :) thanks, greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/3] thunderbolt fixes for v4.15-rc2 2017-12-05 8:52 ` Greg Kroah-Hartman @ 2017-12-16 8:50 ` Mika Westerberg 2017-12-16 16:11 ` Greg Kroah-Hartman 0 siblings, 1 reply; 8+ messages in thread From: Mika Westerberg @ 2017-12-16 8:50 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: linux-kernel On Tue, Dec 05, 2017 at 09:52:50AM +0100, Greg Kroah-Hartman wrote: > On Tue, Dec 05, 2017 at 10:49:13AM +0200, Mika Westerberg wrote: > > On Fri, Dec 01, 2017 at 03:08:02PM +0300, Mika Westerberg wrote: > > > Hi Greg, > > > > > > Here are two Thunderbolt fixes and one related MAINTAINERS update for the > > > next -rc: > > > > > > - Use shorter path for force_power attribute in thunderbolt.rst > > > - Ring interrupts were not masked properly when Rx polling starts > > > - Add thunderbolt.rst to the Thunderbolt driver MAINTAINERS entry > > > > > > Thanks! > > > > Hi Greg, > > > > I wonder if I missed something in this series? These are fixes I picked > > up to my tree and then forwarded to you to be included in your char-misc > > repository for -rc. > > I was traveling all last week, please give me a chance to catch up on > patches :) Hi Greg, Any change to get these fixes for next -rc? They have been on relevant mailing list since v4.15-rc1 and all Thunderbolt maintainers have seen them. I picked them up to our Thunderbolt tree and forwarded to you. Isn't that how the process is supposed to work? Thanks again. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/3] thunderbolt fixes for v4.15-rc2 2017-12-16 8:50 ` Mika Westerberg @ 2017-12-16 16:11 ` Greg Kroah-Hartman 0 siblings, 0 replies; 8+ messages in thread From: Greg Kroah-Hartman @ 2017-12-16 16:11 UTC (permalink / raw) To: Mika Westerberg; +Cc: linux-kernel On Sat, Dec 16, 2017 at 10:50:21AM +0200, Mika Westerberg wrote: > On Tue, Dec 05, 2017 at 09:52:50AM +0100, Greg Kroah-Hartman wrote: > > On Tue, Dec 05, 2017 at 10:49:13AM +0200, Mika Westerberg wrote: > > > On Fri, Dec 01, 2017 at 03:08:02PM +0300, Mika Westerberg wrote: > > > > Hi Greg, > > > > > > > > Here are two Thunderbolt fixes and one related MAINTAINERS update for the > > > > next -rc: > > > > > > > > - Use shorter path for force_power attribute in thunderbolt.rst > > > > - Ring interrupts were not masked properly when Rx polling starts > > > > - Add thunderbolt.rst to the Thunderbolt driver MAINTAINERS entry > > > > > > > > Thanks! > > > > > > Hi Greg, > > > > > > I wonder if I missed something in this series? These are fixes I picked > > > up to my tree and then forwarded to you to be included in your char-misc > > > repository for -rc. > > > > I was traveling all last week, please give me a chance to catch up on > > patches :) > > Hi Greg, > > Any change to get these fixes for next -rc? They have been on relevant > mailing list since v4.15-rc1 and all Thunderbolt maintainers have seen > them. I picked them up to our Thunderbolt tree and forwarded to you. > Isn't that how the process is supposed to work? Yeah, sorry for the delay, I knew I just had to get them in before -final, so they were at the bottom of the pile. Now queued up. greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-12-16 16:11 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-12-01 12:08 [PATCH 0/3] thunderbolt fixes for v4.15-rc2 Mika Westerberg 2017-12-01 12:08 ` [PATCH 1/3] thunderbolt: Make pathname to force_power shorter Mika Westerberg 2017-12-01 12:08 ` [PATCH 2/3] MAINTAINERS: Add thunderbolt.rst to the Thunderbolt driver entry Mika Westerberg 2017-12-01 12:08 ` [PATCH 3/3] thunderbolt: Mask ring interrupt properly when polling starts Mika Westerberg 2017-12-05 8:49 ` [PATCH 0/3] thunderbolt fixes for v4.15-rc2 Mika Westerberg 2017-12-05 8:52 ` Greg Kroah-Hartman 2017-12-16 8:50 ` Mika Westerberg 2017-12-16 16:11 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).