linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: exynos: Use lower case hex addresses in node unit addresses
@ 2017-12-20 19:27 ` Krzysztof Kozlowski
  2017-12-20 19:27   ` [PATCH 2/2] arm64: dts: exynos: Fix typo in MSCL clock controller unit address Krzysztof Kozlowski
  2017-12-21  0:51   ` [PATCH 1/2] arm64: dts: exynos: Use lower case hex addresses in node unit addresses Chanwoo Choi
  0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2017-12-20 19:27 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
	Kukjin Kim, Krzysztof Kozlowski, Chanwoo Choi, Marek Szyprowski,
	Andrzej Hajda, Alim Akhtar, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel

Convert all hex addresses in node unit addresses to lower case to
fix warnings like:
    arch/arm64/boot/dts/exynos/exynos5433-tm2e.dtb: Warning (simple_bus_reg):
      Node /soc/video-scaler@13C00000 simple-bus unit address format error, expected "13c00000"

Conversion was done using sed:
    $ sed -e 's/@\([a-zA-Z0-9_-]*\) {/@\L\1 {/' -i arch/arm64/boot/dts/exynos/*.dts*

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 8 ++++----
 arch/arm64/boot/dts/exynos/exynos7.dtsi    | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 1962b8074349..0ba5df825eff 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -994,7 +994,7 @@
 			reg = <0x145f0000 0x1038>;
 		};
 
-		gsc_0: video-scaler@13C00000 {
+		gsc_0: video-scaler@13c00000 {
 			compatible = "samsung,exynos5433-gsc";
 			reg = <0x13c00000 0x1000>;
 			interrupts = <GIC_SPI 297 IRQ_TYPE_LEVEL_HIGH>;
@@ -1008,7 +1008,7 @@
 			power-domains = <&pd_gscl>;
 		};
 
-		gsc_1: video-scaler@13C10000 {
+		gsc_1: video-scaler@13c10000 {
 			compatible = "samsung,exynos5433-gsc";
 			reg = <0x13c10000 0x1000>;
 			interrupts = <GIC_SPI 298 IRQ_TYPE_LEVEL_HIGH>;
@@ -1022,7 +1022,7 @@
 			power-domains = <&pd_gscl>;
 		};
 
-		gsc_2: video-scaler@13C20000 {
+		gsc_2: video-scaler@13c20000 {
 			compatible = "samsung,exynos5433-gsc";
 			reg = <0x13c20000 0x1000>;
 			interrupts = <GIC_SPI 299 IRQ_TYPE_LEVEL_HIGH>;
@@ -1049,7 +1049,7 @@
 			power-domains = <&pd_mscl>;
 		};
 
-		mfc: codec@152E0000 {
+		mfc: codec@152e0000 {
 			compatible = "samsung,exynos5433-mfc";
 			reg = <0x152E0000 0x10000>;
 			interrupts = <GIC_SPI 358 IRQ_TYPE_LEVEL_HIGH>;
diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
index 9a3fbed1765a..3504837b1d43 100644
--- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
@@ -103,7 +103,7 @@
 			#size-cells = <1>;
 			ranges;
 
-			pdma0: pdma@10E10000 {
+			pdma0: pdma@10e10000 {
 				compatible = "arm,pl330", "arm,primecell";
 				reg = <0x10E10000 0x1000>;
 				interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
@@ -114,7 +114,7 @@
 				#dma-requests = <32>;
 			};
 
-			pdma1: pdma@10EB0000 {
+			pdma1: pdma@10eb0000 {
 				compatible = "arm,pl330", "arm,primecell";
 				reg = <0x10EB0000 0x1000>;
 				interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH 2/2] arm64: dts: exynos: Fix typo in MSCL clock controller unit address
  2017-12-20 19:27 ` [PATCH 1/2] arm64: dts: exynos: Use lower case hex addresses in node unit addresses Krzysztof Kozlowski
@ 2017-12-20 19:27   ` Krzysztof Kozlowski
  2017-12-21  0:54     ` Chanwoo Choi
  2017-12-21  0:51   ` [PATCH 1/2] arm64: dts: exynos: Use lower case hex addresses in node unit addresses Chanwoo Choi
  1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2017-12-20 19:27 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
	Kukjin Kim, Krzysztof Kozlowski, Chanwoo Choi, Marek Szyprowski,
	Andrzej Hajda, Alim Akhtar, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel

Fix typo in unit address of MSCL clock controller (the reg entry is
correct).

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 0ba5df825eff..3e8311c60d1b 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -468,7 +468,7 @@
 			clocks = <&xxti>, <&cmu_mif CLK_SCLK_BUS_PLL_ATLAS>;
 		};
 
-		cmu_mscl: clock-controller@105d0000 {
+		cmu_mscl: clock-controller@150d0000 {
 			compatible = "samsung,exynos5433-cmu-mscl";
 			reg = <0x150d0000 0x1000>;
 			#clock-cells = <1>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] arm64: dts: exynos: Use lower case hex addresses in node unit addresses
  2017-12-20 19:27 ` [PATCH 1/2] arm64: dts: exynos: Use lower case hex addresses in node unit addresses Krzysztof Kozlowski
  2017-12-20 19:27   ` [PATCH 2/2] arm64: dts: exynos: Fix typo in MSCL clock controller unit address Krzysztof Kozlowski
@ 2017-12-21  0:51   ` Chanwoo Choi
  1 sibling, 0 replies; 4+ messages in thread
From: Chanwoo Choi @ 2017-12-21  0:51 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Rob Herring, Mark Rutland, Catalin Marinas,
	Will Deacon, Kukjin Kim, Marek Szyprowski, Andrzej Hajda,
	Alim Akhtar, devicetree, linux-arm-kernel, linux-samsung-soc,
	linux-kernel

Dear Krzysztof,

On 2017년 12월 21일 04:27, Krzysztof Kozlowski wrote:
> Convert all hex addresses in node unit addresses to lower case to
> fix warnings like:
>     arch/arm64/boot/dts/exynos/exynos5433-tm2e.dtb: Warning (simple_bus_reg):
>       Node /soc/video-scaler@13C00000 simple-bus unit address format error, expected "13c00000"
> 
> Conversion was done using sed:
>     $ sed -e 's/@\([a-zA-Z0-9_-]*\) {/@\L\1 {/' -i arch/arm64/boot/dts/exynos/*.dts*
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 8 ++++----
>  arch/arm64/boot/dts/exynos/exynos7.dtsi    | 4 ++--
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 1962b8074349..0ba5df825eff 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -994,7 +994,7 @@
>  			reg = <0x145f0000 0x1038>;
>  		};
>  
> -		gsc_0: video-scaler@13C00000 {
> +		gsc_0: video-scaler@13c00000 {
>  			compatible = "samsung,exynos5433-gsc";
>  			reg = <0x13c00000 0x1000>;
>  			interrupts = <GIC_SPI 297 IRQ_TYPE_LEVEL_HIGH>;
> @@ -1008,7 +1008,7 @@
>  			power-domains = <&pd_gscl>;
>  		};
>  
> -		gsc_1: video-scaler@13C10000 {
> +		gsc_1: video-scaler@13c10000 {
>  			compatible = "samsung,exynos5433-gsc";
>  			reg = <0x13c10000 0x1000>;
>  			interrupts = <GIC_SPI 298 IRQ_TYPE_LEVEL_HIGH>;
> @@ -1022,7 +1022,7 @@
>  			power-domains = <&pd_gscl>;
>  		};
>  
> -		gsc_2: video-scaler@13C20000 {
> +		gsc_2: video-scaler@13c20000 {
>  			compatible = "samsung,exynos5433-gsc";
>  			reg = <0x13c20000 0x1000>;
>  			interrupts = <GIC_SPI 299 IRQ_TYPE_LEVEL_HIGH>;
> @@ -1049,7 +1049,7 @@
>  			power-domains = <&pd_mscl>;
>  		};
>  
> -		mfc: codec@152E0000 {
> +		mfc: codec@152e0000 {
>  			compatible = "samsung,exynos5433-mfc";
>  			reg = <0x152E0000 0x10000>;
>  			interrupts = <GIC_SPI 358 IRQ_TYPE_LEVEL_HIGH>;
> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> index 9a3fbed1765a..3504837b1d43 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> @@ -103,7 +103,7 @@
>  			#size-cells = <1>;
>  			ranges;
>  
> -			pdma0: pdma@10E10000 {
> +			pdma0: pdma@10e10000 {
>  				compatible = "arm,pl330", "arm,primecell";
>  				reg = <0x10E10000 0x1000>;
>  				interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
> @@ -114,7 +114,7 @@
>  				#dma-requests = <32>;
>  			};
>  
> -			pdma1: pdma@10EB0000 {
> +			pdma1: pdma@10eb0000 {
>  				compatible = "arm,pl330", "arm,primecell";
>  				reg = <0x10EB0000 0x1000>;
>  				interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH>;
> 

Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] arm64: dts: exynos: Fix typo in MSCL clock controller unit address
  2017-12-20 19:27   ` [PATCH 2/2] arm64: dts: exynos: Fix typo in MSCL clock controller unit address Krzysztof Kozlowski
@ 2017-12-21  0:54     ` Chanwoo Choi
  0 siblings, 0 replies; 4+ messages in thread
From: Chanwoo Choi @ 2017-12-21  0:54 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Rob Herring, Mark Rutland, Catalin Marinas,
	Will Deacon, Kukjin Kim, Marek Szyprowski, Andrzej Hajda,
	Alim Akhtar, devicetree, linux-arm-kernel, linux-samsung-soc,
	linux-kernel

On 2017년 12월 21일 04:27, Krzysztof Kozlowski wrote:
> Fix typo in unit address of MSCL clock controller (the reg entry is
> correct).
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 0ba5df825eff..3e8311c60d1b 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -468,7 +468,7 @@
>  			clocks = <&xxti>, <&cmu_mif CLK_SCLK_BUS_PLL_ATLAS>;
>  		};
>  
> -		cmu_mscl: clock-controller@105d0000 {
> +		cmu_mscl: clock-controller@150d0000 {
>  			compatible = "samsung,exynos5433-cmu-mscl";
>  			reg = <0x150d0000 0x1000>;
>  			#clock-cells = <1>;
> 

Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-21  0:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20171220192737epcas4p17c4e71c11e5864fd59f06396c0867a3a@epcas4p1.samsung.com>
2017-12-20 19:27 ` [PATCH 1/2] arm64: dts: exynos: Use lower case hex addresses in node unit addresses Krzysztof Kozlowski
2017-12-20 19:27   ` [PATCH 2/2] arm64: dts: exynos: Fix typo in MSCL clock controller unit address Krzysztof Kozlowski
2017-12-21  0:54     ` Chanwoo Choi
2017-12-21  0:51   ` [PATCH 1/2] arm64: dts: exynos: Use lower case hex addresses in node unit addresses Chanwoo Choi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).