* [PATCH] mfd: axp20x: Mark axp288 CHRG_BAK_CTRL register volatile
@ 2017-12-22 12:35 Hans de Goede
2017-12-26 7:35 ` Chen-Yu Tsai
2018-01-02 15:36 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Hans de Goede @ 2017-12-22 12:35 UTC (permalink / raw)
To: Lee Jones, Chen-Yu Tsai; +Cc: Hans de Goede, linux-kernel
The input current limit bits get updated by the charger detection logic,
so we should not cache the contents of this register.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/mfd/axp20x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
index 2468b431bb22..61dff7b6c9c8 100644
--- a/drivers/mfd/axp20x.c
+++ b/drivers/mfd/axp20x.c
@@ -129,6 +129,7 @@ static const struct regmap_range axp288_volatile_ranges[] = {
regmap_reg_range(AXP20X_PWR_INPUT_STATUS, AXP288_POWER_REASON),
regmap_reg_range(AXP288_BC_GLOBAL, AXP288_BC_GLOBAL),
regmap_reg_range(AXP288_BC_DET_STAT, AXP288_BC_DET_STAT),
+ regmap_reg_range(AXP20X_CHRG_BAK_CTRL, AXP20X_CHRG_BAK_CTRL),
regmap_reg_range(AXP20X_IRQ1_EN, AXP20X_IPSOUT_V_HIGH_L),
regmap_reg_range(AXP20X_TIMER_CTRL, AXP20X_TIMER_CTRL),
regmap_reg_range(AXP22X_GPIO_STATE, AXP22X_GPIO_STATE),
--
2.14.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: axp20x: Mark axp288 CHRG_BAK_CTRL register volatile
2017-12-22 12:35 [PATCH] mfd: axp20x: Mark axp288 CHRG_BAK_CTRL register volatile Hans de Goede
@ 2017-12-26 7:35 ` Chen-Yu Tsai
2018-01-02 15:36 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Chen-Yu Tsai @ 2017-12-26 7:35 UTC (permalink / raw)
To: Hans de Goede; +Cc: Lee Jones, Chen-Yu Tsai, linux-kernel
On Fri, Dec 22, 2017 at 8:35 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> The input current limit bits get updated by the charger detection logic,
> so we should not cache the contents of this register.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: axp20x: Mark axp288 CHRG_BAK_CTRL register volatile
2017-12-22 12:35 [PATCH] mfd: axp20x: Mark axp288 CHRG_BAK_CTRL register volatile Hans de Goede
2017-12-26 7:35 ` Chen-Yu Tsai
@ 2018-01-02 15:36 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2018-01-02 15:36 UTC (permalink / raw)
To: Hans de Goede; +Cc: Chen-Yu Tsai, linux-kernel
On Fri, 22 Dec 2017, Hans de Goede wrote:
> The input current limit bits get updated by the charger detection logic,
> so we should not cache the contents of this register.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/mfd/axp20x.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-02 15:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-22 12:35 [PATCH] mfd: axp20x: Mark axp288 CHRG_BAK_CTRL register volatile Hans de Goede
2017-12-26 7:35 ` Chen-Yu Tsai
2018-01-02 15:36 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).