* [PATCH][next] soundwire: intel: fix missing assignment to ret
@ 2017-12-21 23:32 Colin King
2017-12-22 3:31 ` Vinod Koul
2017-12-22 12:42 ` Vinod Koul
0 siblings, 2 replies; 5+ messages in thread
From: Colin King @ 2017-12-21 23:32 UTC (permalink / raw)
To: Vinod Koul, Sanyog Kale, alsa-devel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently the return status ret is being checked but it has not been
updated since the previous check on ret. It appears that assignment of
ret from return status of the call to sdw_cdns_enable_interrupt was
accidentally ommited. Fix this.
Detected by CoverityScan, CID#1463148 ("Logically dead code")
Fixes: 71bb8a1b059e ("soundwire: intel: Add Intel Master driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/soundwire/intel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index 6a9177ea6eb9..86a7bd1fc912 100644
--- a/drivers/soundwire/intel.c
+++ b/drivers/soundwire/intel.c
@@ -295,7 +295,7 @@ static int intel_probe(struct platform_device *pdev)
if (ret)
goto err_init;
- sdw_cdns_enable_interrupt(&sdw->cdns);
+ ret = sdw_cdns_enable_interrupt(&sdw->cdns);
if (ret)
goto err_init;
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH][next] soundwire: intel: fix missing assignment to ret
2017-12-21 23:32 [PATCH][next] soundwire: intel: fix missing assignment to ret Colin King
@ 2017-12-22 3:31 ` Vinod Koul
2017-12-22 7:15 ` Greg KH
2017-12-22 12:42 ` Vinod Koul
1 sibling, 1 reply; 5+ messages in thread
From: Vinod Koul @ 2017-12-22 3:31 UTC (permalink / raw)
To: Colin King, Greg KH
Cc: Sanyog Kale, alsa-devel, kernel-janitors, linux-kernel
On Thu, Dec 21, 2017 at 11:32:10PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the return status ret is being checked but it has not been
> updated since the previous check on ret. It appears that assignment of
> ret from return status of the call to sdw_cdns_enable_interrupt was
> accidentally ommited. Fix this.
Thanks Colin, this looks good to me.
Greg, we have this and another patch from Colin, both lgtm.
Would you like me to collect these and send to you before merge cycle or
apply directly?
>
> Detected by CoverityScan, CID#1463148 ("Logically dead code")
>
> Fixes: 71bb8a1b059e ("soundwire: intel: Add Intel Master driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/soundwire/intel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
> index 6a9177ea6eb9..86a7bd1fc912 100644
> --- a/drivers/soundwire/intel.c
> +++ b/drivers/soundwire/intel.c
> @@ -295,7 +295,7 @@ static int intel_probe(struct platform_device *pdev)
> if (ret)
> goto err_init;
>
> - sdw_cdns_enable_interrupt(&sdw->cdns);
> + ret = sdw_cdns_enable_interrupt(&sdw->cdns);
> if (ret)
> goto err_init;
>
> --
> 2.14.1
>
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] soundwire: intel: fix missing assignment to ret
2017-12-22 3:31 ` Vinod Koul
@ 2017-12-22 7:15 ` Greg KH
2017-12-22 8:10 ` Vinod Koul
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2017-12-22 7:15 UTC (permalink / raw)
To: Vinod Koul
Cc: Colin King, Sanyog Kale, alsa-devel, kernel-janitors, linux-kernel
On Fri, Dec 22, 2017 at 09:01:49AM +0530, Vinod Koul wrote:
> On Thu, Dec 21, 2017 at 11:32:10PM +0000, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Currently the return status ret is being checked but it has not been
> > updated since the previous check on ret. It appears that assignment of
> > ret from return status of the call to sdw_cdns_enable_interrupt was
> > accidentally ommited. Fix this.
>
> Thanks Colin, this looks good to me.
>
> Greg, we have this and another patch from Colin, both lgtm.
>
> Would you like me to collect these and send to you before merge cycle or
> apply directly?
Please collect and then send on, as it is not in my queue at all.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] soundwire: intel: fix missing assignment to ret
2017-12-22 7:15 ` Greg KH
@ 2017-12-22 8:10 ` Vinod Koul
0 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2017-12-22 8:10 UTC (permalink / raw)
To: Greg KH
Cc: Colin King, Sanyog Kale, alsa-devel, kernel-janitors, linux-kernel
On Fri, Dec 22, 2017 at 08:15:22AM +0100, Greg KH wrote:
> On Fri, Dec 22, 2017 at 09:01:49AM +0530, Vinod Koul wrote:
> > On Thu, Dec 21, 2017 at 11:32:10PM +0000, Colin King wrote:
> > > From: Colin Ian King <colin.king@canonical.com>
> > >
> > > Currently the return status ret is being checked but it has not been
> > > updated since the previous check on ret. It appears that assignment of
> > > ret from return status of the call to sdw_cdns_enable_interrupt was
> > > accidentally ommited. Fix this.
> >
> > Thanks Colin, this looks good to me.
> >
> > Greg, we have this and another patch from Colin, both lgtm.
> >
> > Would you like me to collect these and send to you before merge cycle or
> > apply directly?
>
> Please collect and then send on, as it is not in my queue at all.
Sounds good, will do that
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] soundwire: intel: fix missing assignment to ret
2017-12-21 23:32 [PATCH][next] soundwire: intel: fix missing assignment to ret Colin King
2017-12-22 3:31 ` Vinod Koul
@ 2017-12-22 12:42 ` Vinod Koul
1 sibling, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2017-12-22 12:42 UTC (permalink / raw)
To: Colin King; +Cc: Sanyog Kale, alsa-devel, kernel-janitors, linux-kernel
On Thu, Dec 21, 2017 at 11:32:10PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the return status ret is being checked but it has not been
> updated since the previous check on ret. It appears that assignment of
> ret from return status of the call to sdw_cdns_enable_interrupt was
> accidentally ommited. Fix this.
Applied, thanks
>
> Detected by CoverityScan, CID#1463148 ("Logically dead code")
>
> Fixes: 71bb8a1b059e ("soundwire: intel: Add Intel Master driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/soundwire/intel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
> index 6a9177ea6eb9..86a7bd1fc912 100644
> --- a/drivers/soundwire/intel.c
> +++ b/drivers/soundwire/intel.c
> @@ -295,7 +295,7 @@ static int intel_probe(struct platform_device *pdev)
> if (ret)
> goto err_init;
>
> - sdw_cdns_enable_interrupt(&sdw->cdns);
> + ret = sdw_cdns_enable_interrupt(&sdw->cdns);
> if (ret)
> goto err_init;
>
> --
> 2.14.1
>
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-22 12:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-21 23:32 [PATCH][next] soundwire: intel: fix missing assignment to ret Colin King
2017-12-22 3:31 ` Vinod Koul
2017-12-22 7:15 ` Greg KH
2017-12-22 8:10 ` Vinod Koul
2017-12-22 12:42 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).