From: Jason Gunthorpe <jgg@ziepe.ca>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Peter Huewe <peterhuewe@gmx.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH] tpm: remove unused data fields from I2C and OF device ID tables
Date: Fri, 22 Dec 2017 09:06:07 -0700 [thread overview]
Message-ID: <20171222160607.GA30884@ziepe.ca> (raw)
In-Reply-To: <20171222102636.12530-1-javierm@redhat.com>
On Fri, Dec 22, 2017 at 11:26:36AM +0100, Javier Martinez Canillas wrote:
> The data field for the entries in the device tables are set but not used.
>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>
> drivers/char/tpm/tpm_i2c_infineon.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_i2c_infineon.c b/drivers/char/tpm/tpm_i2c_infineon.c
> index 005c38879b2e..19fbd6a3a8e9 100644
> +++ b/drivers/char/tpm/tpm_i2c_infineon.c
> @@ -665,9 +665,9 @@ static int tpm_tis_i2c_init(struct device *dev)
> }
>
> static const struct i2c_device_id tpm_tis_i2c_table[] = {
> - {"tpm_i2c_infineon", 0},
> - {"slb9635tt", 0},
> - {"slb9645tt", 1},
> + {"tpm_i2c_infineon" },
> + {"slb9635tt" },
> + {"slb9645tt" },
^^^
The space should go too..
Jason
prev parent reply other threads:[~2017-12-22 16:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 10:26 [PATCH] tpm: remove unused data fields from I2C and OF device ID tables Javier Martinez Canillas
2017-12-22 16:06 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171222160607.GA30884@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=javierm@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).