[PATCH] tpm: remove unused data fields from I2C and OF device ID tables

[PATCH] tpm: remove unused data fields from I2C and OF device ID tables

[Javier Martinez Canillas]

The data field for the entries in the device tables are set but not used.

Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---

 drivers/char/tpm/tpm_i2c_infineon.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/char/tpm/tpm_i2c_infineon.c b/drivers/char/tpm/tpm_i2c_infineon.c
index 005c38879b2e..19fbd6a3a8e9 100644
--- a/drivers/char/tpm/tpm_i2c_infineon.c
+++ b/drivers/char/tpm/tpm_i2c_infineon.c
@@ -665,9 +665,9 @@ static int tpm_tis_i2c_init(struct device *dev)
 }
 
 static const struct i2c_device_id tpm_tis_i2c_table[] = {
-	{"tpm_i2c_infineon", 0},
-	{"slb9635tt", 0},
-	{"slb9645tt", 1},
+	{"tpm_i2c_infineon" },
+	{"slb9635tt" },
+	{"slb9645tt" },
 	{},
 };
 
@@ -675,9 +675,9 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_table);
 
 #ifdef CONFIG_OF
 static const struct of_device_id tpm_tis_i2c_of_match[] = {
-	{ .compatible = "infineon,tpm_i2c_infineon", .data = (void *)0 },
-	{ .compatible = "infineon,slb9635tt", .data = (void *)0 },
-	{ .compatible = "infineon,slb9645tt", .data = (void *)1 },
+	{ .compatible = "infineon,tpm_i2c_infineon" },
+	{ .compatible = "infineon,slb9635tt" },
+	{ .compatible = "infineon,slb9645tt" },
 	{},
 };
 MODULE_DEVICE_TABLE(of, tpm_tis_i2c_of_match);
-- 
2.14.3

Re: [PATCH] tpm: remove unused data fields from I2C and OF device ID tables

[Jason Gunthorpe]

On Fri, Dec 22, 2017 at 11:26:36AM +0100, Javier Martinez Canillas wrote:
> The data field for the entries in the device tables are set but not used.
> 
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> 
>  drivers/char/tpm/tpm_i2c_infineon.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm_i2c_infineon.c b/drivers/char/tpm/tpm_i2c_infineon.c
> index 005c38879b2e..19fbd6a3a8e9 100644
> +++ b/drivers/char/tpm/tpm_i2c_infineon.c
> @@ -665,9 +665,9 @@ static int tpm_tis_i2c_init(struct device *dev)
>  }
>  
>  static const struct i2c_device_id tpm_tis_i2c_table[] = {
> -	{"tpm_i2c_infineon", 0},
> -	{"slb9635tt", 0},
> -	{"slb9645tt", 1},
> +	{"tpm_i2c_infineon" },
> +	{"slb9635tt" },
> +	{"slb9645tt" },

                   ^^^

The space should go too..

Jason