From: Matthew Wilcox <willy@infradead.org>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-kernel@vger.kernel.org, Dave Hansen <dave.hansen@intel.com>,
linux-mm@kvack.org, Matthew Wilcox <mawilcox@microsoft.com>,
linux-sparse@vger.kernel.org
Subject: Re: [PATCH 2/2] Introduce __cond_lock_err
Date: Sat, 23 Dec 2017 05:06:21 -0800 [thread overview]
Message-ID: <20171223130621.GA3994@bombadil.infradead.org> (raw)
In-Reply-To: <20171223093910.GB6160@localhost>
On Sat, Dec 23, 2017 at 01:39:11AM -0800, Josh Triplett wrote:
> +linux-sparse
Ehh ... we've probably trimmed too much to give linux-sparse a good summary.
Here're the important lines from my patch:
+# define __cond_lock_err(x,c) ((c) ? 1 : ({ __acquire(x); 0; }))
+ return __cond_lock_err(*ptlp, __follow_pte_pmd(mm, address, start, end,
+ ptepp, pmdpp, ptlp));
This is supposed to be "If "c" is an error value, we don't have a lock,
otherwise we have a lock". And to translate from linux-speak into
sparse-speak:
# define __acquire(x) __context__(x,1)
Josh & Ross pointed out (quite correctly) that code which does something like
if (foo())
return;
will work with this, but code that does
if (foo() < 0)
return;
will not because we're now returning 1 instead of -ENOMEM (for example).
So they made the very sensible suggestion that I change the definition
of __cond_lock to:
# define __cond_lock_err(x,c) ((c) ?: ({ __acquire(x); 0; }))
Unfortunately, when I do that, the context imbalance warning returns.
As I said below, this is with sparse 0.5.1.
> On Fri, Dec 22, 2017 at 05:36:34AM -0800, Matthew Wilcox wrote:
> > On Fri, Dec 22, 2017 at 04:31:12AM -0800, Matthew Wilcox wrote:
> > > On Thu, Dec 21, 2017 at 08:21:20PM -0800, Josh Triplett wrote:
> > > > On Thu, Dec 21, 2017 at 05:10:00PM -0800, Matthew Wilcox wrote:
> > > > > Yes, but this define is only #if __CHECKER__, so it doesn't matter what we
> > > > > return as this code will never run.
> > > >
> > > > It does matter slightly, as Sparse does some (very limited) value-based
> > > > analyses. Let's future-proof it.
> > > >
> > > > > That said, if sparse supports the GNU syntax of ?: then I have no
> > > > > objection to doing that.
> > > >
> > > > Sparse does support that syntax.
> > >
> > > Great, I'll fix that and resubmit.
> >
> > Except the context imbalance warning comes back if I do. This is sparse
> > 0.5.1 (Debian's 0.5.1-2 package).
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-12-23 13:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 16:58 [PATCH 1/2] mm: Make follow_pte_pmd an inline Matthew Wilcox
2017-12-19 16:58 ` [PATCH 2/2] Introduce __cond_lock_err Matthew Wilcox
2017-12-21 21:48 ` Ross Zwisler
2017-12-21 22:00 ` Josh Triplett
2017-12-21 22:10 ` Ross Zwisler
2017-12-22 1:10 ` Matthew Wilcox
2017-12-22 4:21 ` Josh Triplett
2017-12-22 12:31 ` Matthew Wilcox
2017-12-22 13:36 ` Matthew Wilcox
2017-12-23 9:39 ` Josh Triplett
2017-12-23 13:06 ` Matthew Wilcox [this message]
2017-12-27 14:38 ` Luc Van Oostenryck
2017-12-27 14:28 ` Luc Van Oostenryck
2017-12-30 7:17 ` Matthew Wilcox
2017-12-19 17:05 ` [PATCH 1/2] mm: Make follow_pte_pmd an inline Joe Perches
2017-12-19 17:12 ` Matthew Wilcox
2017-12-21 21:29 ` Ross Zwisler
2017-12-22 1:07 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171223130621.GA3994@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=dave.hansen@intel.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sparse@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).