linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-kernel@vger.kernel.org,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	Dave Hansen <dave.hansen@intel.com>,
	linux-mm@kvack.org, Josh Triplett <josh@joshtriplett.org>,
	Matthew Wilcox <mawilcox@microsoft.com>
Subject: Re: [PATCH 1/2] mm: Make follow_pte_pmd an inline
Date: Thu, 21 Dec 2017 14:29:43 -0700	[thread overview]
Message-ID: <20171221212943.GB9087@linux.intel.com> (raw)
In-Reply-To: <20171219165823.24243-1-willy@infradead.org>

On Tue, Dec 19, 2017 at 08:58:22AM -0800, Matthew Wilcox wrote:
> From: Matthew Wilcox <mawilcox@microsoft.com>
> 
> The one user of follow_pte_pmd (dax) emits a sparse warning because
> it doesn't know that follow_pte_pmd conditionally returns with the
> pte/pmd locked.  The required annotation is already there; it's just
> in the wrong file.

Can you help me find the required annotation that is already there but in the
wrong file?

This does seem to quiet a lockep warning in fs/dax.c, but I think we still
have a related one in mm/memory.c:

mm/memory.c:4204:5: warning: context imbalance in '__follow_pte_pmd' - different lock contexts for basic block

Should we deal with this one as well?

  parent reply	other threads:[~2017-12-21 21:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-19 16:58 [PATCH 1/2] mm: Make follow_pte_pmd an inline Matthew Wilcox
2017-12-19 16:58 ` [PATCH 2/2] Introduce __cond_lock_err Matthew Wilcox
2017-12-21 21:48   ` Ross Zwisler
2017-12-21 22:00     ` Josh Triplett
2017-12-21 22:10       ` Ross Zwisler
2017-12-22  1:10     ` Matthew Wilcox
2017-12-22  4:21       ` Josh Triplett
2017-12-22 12:31         ` Matthew Wilcox
2017-12-22 13:36           ` Matthew Wilcox
2017-12-23  9:39             ` Josh Triplett
2017-12-23 13:06               ` Matthew Wilcox
2017-12-27 14:38                 ` Luc Van Oostenryck
2017-12-27 14:28           ` Luc Van Oostenryck
2017-12-30  7:17             ` Matthew Wilcox
2017-12-19 17:05 ` [PATCH 1/2] mm: Make follow_pte_pmd an inline Joe Perches
2017-12-19 17:12   ` Matthew Wilcox
2017-12-21 21:29 ` Ross Zwisler [this message]
2017-12-22  1:07   ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171221212943.GB9087@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=dave.hansen@intel.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mawilcox@microsoft.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).