linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RESEND] phy: sun4i-usb: add support for R40 USB PHY
@ 2018-01-03  8:49 Icenowy Zheng
  2018-01-15 15:06 ` [RESEND] " Hermann Lauer
  0 siblings, 1 reply; 6+ messages in thread
From: Icenowy Zheng @ 2018-01-03  8:49 UTC (permalink / raw)
  To: Kishon Vijay Abraham I
  Cc: devicetree, linux-arm-kernel, linux-kernel, linux-sunxi, Icenowy Zheng

Allwinner R40 features a USB PHY like the one in A64, but with 3 PHYs.

Add support for it.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Acked-by: Rob Herring <robh@kernel.org>
---
When resending, the ACK's by Maxime and Rob are added.

 Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt |  1 +
 drivers/phy/allwinner/phy-sun4i-usb.c                   | 12 ++++++++++++
 2 files changed, 13 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt b/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt
index c1ce5a0a652e..07ca4ec4a745 100644
--- a/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt
+++ b/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt
@@ -11,6 +11,7 @@ Required properties:
   * allwinner,sun8i-a33-usb-phy
   * allwinner,sun8i-a83t-usb-phy
   * allwinner,sun8i-h3-usb-phy
+  * allwinner,sun8i-r40-usb-phy
   * allwinner,sun8i-v3s-usb-phy
   * allwinner,sun50i-a64-usb-phy
 - reg : a list of offset + length pairs
diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c
index aa857be692cf..bee798892b21 100644
--- a/drivers/phy/allwinner/phy-sun4i-usb.c
+++ b/drivers/phy/allwinner/phy-sun4i-usb.c
@@ -112,6 +112,7 @@ enum sun4i_usb_phy_type {
 	sun8i_a33_phy,
 	sun8i_a83t_phy,
 	sun8i_h3_phy,
+	sun8i_r40_phy,
 	sun8i_v3s_phy,
 	sun50i_a64_phy,
 };
@@ -919,6 +920,16 @@ static const struct sun4i_usb_phy_cfg sun8i_h3_cfg = {
 	.phy0_dual_route = true,
 };
 
+static const struct sun4i_usb_phy_cfg sun8i_r40_cfg = {
+	.num_phys = 3,
+	.type = sun8i_r40_phy,
+	.disc_thresh = 3,
+	.phyctl_offset = REG_PHYCTL_A33,
+	.dedicated_clocks = true,
+	.enable_pmu_unk1 = true,
+	.phy0_dual_route = true,
+};
+
 static const struct sun4i_usb_phy_cfg sun8i_v3s_cfg = {
 	.num_phys = 1,
 	.type = sun8i_v3s_phy,
@@ -948,6 +959,7 @@ static const struct of_device_id sun4i_usb_phy_of_match[] = {
 	{ .compatible = "allwinner,sun8i-a33-usb-phy", .data = &sun8i_a33_cfg },
 	{ .compatible = "allwinner,sun8i-a83t-usb-phy", .data = &sun8i_a83t_cfg },
 	{ .compatible = "allwinner,sun8i-h3-usb-phy", .data = &sun8i_h3_cfg },
+	{ .compatible = "allwinner,sun8i-r40-usb-phy", .data = &sun8i_r40_cfg },
 	{ .compatible = "allwinner,sun8i-v3s-usb-phy", .data = &sun8i_v3s_cfg },
 	{ .compatible = "allwinner,sun50i-a64-usb-phy",
 	  .data = &sun50i_a64_cfg},
-- 
2.14.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [RESEND] phy: sun4i-usb: add support for R40 USB PHY
  2018-01-03  8:49 [PATCH RESEND] phy: sun4i-usb: add support for R40 USB PHY Icenowy Zheng
@ 2018-01-15 15:06 ` Hermann Lauer
  2018-01-19  6:25   ` Chen-Yu Tsai
  0 siblings, 1 reply; 6+ messages in thread
From: Hermann Lauer @ 2018-01-15 15:06 UTC (permalink / raw)
  To: Icenowy Zheng
  Cc: Kishon Vijay Abraham I, devicetree, linux-sunxi, linux-kernel,
	linux-arm-kernel

On Wed, Jan 03, 2018 at 04:49:44PM +0800, Icenowy Zheng wrote:
> Allwinner R40 features a USB PHY like the one in A64, but with 3 PHYs.
> 
> Add support for it.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Acked-by: Rob Herring <robh@kernel.org>

You may add

Tested-by: Hermann.Lauer@iwr.uni-heidelberg.de

as my Banana Pi M2 Ultra is running over a week now with an usb-network
adapter which is needed until devicetree entries for the Banana Pi M2 Ultra
are available for the ccu register enabling allowing access to the ethernet phy.

Thanks !

> ---
> When resending, the ACK's by Maxime and Rob are added.
> 
>  Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt |  1 +
>  drivers/phy/allwinner/phy-sun4i-usb.c                   | 12 ++++++++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt b/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt
> index c1ce5a0a652e..07ca4ec4a745 100644
> --- a/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt
> @@ -11,6 +11,7 @@ Required properties:
>    * allwinner,sun8i-a33-usb-phy
>    * allwinner,sun8i-a83t-usb-phy
>    * allwinner,sun8i-h3-usb-phy
> +  * allwinner,sun8i-r40-usb-phy
>    * allwinner,sun8i-v3s-usb-phy
>    * allwinner,sun50i-a64-usb-phy
>  - reg : a list of offset + length pairs
> diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c
> index aa857be692cf..bee798892b21 100644
> --- a/drivers/phy/allwinner/phy-sun4i-usb.c
> +++ b/drivers/phy/allwinner/phy-sun4i-usb.c
> @@ -112,6 +112,7 @@ enum sun4i_usb_phy_type {
>  	sun8i_a33_phy,
>  	sun8i_a83t_phy,
>  	sun8i_h3_phy,
> +	sun8i_r40_phy,
>  	sun8i_v3s_phy,
>  	sun50i_a64_phy,
>  };
> @@ -919,6 +920,16 @@ static const struct sun4i_usb_phy_cfg sun8i_h3_cfg = {
>  	.phy0_dual_route = true,
>  };
>  
> +static const struct sun4i_usb_phy_cfg sun8i_r40_cfg = {
> +	.num_phys = 3,
> +	.type = sun8i_r40_phy,
> +	.disc_thresh = 3,
> +	.phyctl_offset = REG_PHYCTL_A33,
> +	.dedicated_clocks = true,
> +	.enable_pmu_unk1 = true,
> +	.phy0_dual_route = true,
> +};
> +
>  static const struct sun4i_usb_phy_cfg sun8i_v3s_cfg = {
>  	.num_phys = 1,
>  	.type = sun8i_v3s_phy,
> @@ -948,6 +959,7 @@ static const struct of_device_id sun4i_usb_phy_of_match[] = {
>  	{ .compatible = "allwinner,sun8i-a33-usb-phy", .data = &sun8i_a33_cfg },
>  	{ .compatible = "allwinner,sun8i-a83t-usb-phy", .data = &sun8i_a83t_cfg },
>  	{ .compatible = "allwinner,sun8i-h3-usb-phy", .data = &sun8i_h3_cfg },
> +	{ .compatible = "allwinner,sun8i-r40-usb-phy", .data = &sun8i_r40_cfg },
>  	{ .compatible = "allwinner,sun8i-v3s-usb-phy", .data = &sun8i_v3s_cfg },
>  	{ .compatible = "allwinner,sun50i-a64-usb-phy",
>  	  .data = &sun50i_a64_cfg},

-- 
Netzwerkadministration/Zentrale Dienste, Interdiziplinaeres 
Zentrum fuer wissenschaftliches Rechnen der Universitaet Heidelberg
IWR; INF 205; 69120 Heidelberg; Tel: (06221)54-14405 Fax: -14427
Email: Hermann.Lauer@iwr.uni-heidelberg.de

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RESEND] phy: sun4i-usb: add support for R40 USB PHY
  2018-01-15 15:06 ` [RESEND] " Hermann Lauer
@ 2018-01-19  6:25   ` Chen-Yu Tsai
  2018-01-19  6:30     ` Icenowy Zheng
  2018-01-19  8:13     ` Kishon Vijay Abraham I
  0 siblings, 2 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2018-01-19  6:25 UTC (permalink / raw)
  To: Kishon Vijay Abraham I
  Cc: Icenowy Zheng, Hermann Lauer, devicetree, linux-sunxi,
	linux-kernel, linux-arm-kernel

Hi Kishon,

On Mon, Jan 15, 2018 at 11:06 PM, Hermann Lauer
<Hermann.Lauer@iwr.uni-heidelberg.de> wrote:
> On Wed, Jan 03, 2018 at 04:49:44PM +0800, Icenowy Zheng wrote:
>> Allwinner R40 features a USB PHY like the one in A64, but with 3 PHYs.
>>
>> Add support for it.
>>
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>> Acked-by: Rob Herring <robh@kernel.org>
>
> You may add
>
> Tested-by: Hermann.Lauer@iwr.uni-heidelberg.de

Gentle ping for this patch to be included in 4.16

ChenYu

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RESEND] phy: sun4i-usb: add support for R40 USB PHY
  2018-01-19  6:25   ` Chen-Yu Tsai
@ 2018-01-19  6:30     ` Icenowy Zheng
  2018-01-19  8:13     ` Kishon Vijay Abraham I
  1 sibling, 0 replies; 6+ messages in thread
From: Icenowy Zheng @ 2018-01-19  6:30 UTC (permalink / raw)
  To: linux-arm-kernel, Chen-Yu Tsai, Kishon Vijay Abraham I
  Cc: devicetree, linux-kernel, linux-sunxi, Hermann Lauer, linux-arm-kernel



于 2018年1月19日 GMT+08:00 下午2:25:09, Chen-Yu Tsai <wens@csie.org> 写到:
>Hi Kishon,
>
>On Mon, Jan 15, 2018 at 11:06 PM, Hermann Lauer
><Hermann.Lauer@iwr.uni-heidelberg.de> wrote:
>> On Wed, Jan 03, 2018 at 04:49:44PM +0800, Icenowy Zheng wrote:
>>> Allwinner R40 features a USB PHY like the one in A64, but with 3
>PHYs.
>>>
>>> Add support for it.
>>>
>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>>> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>>> Acked-by: Rob Herring <robh@kernel.org>
>>
>> You may add
>>
>> Tested-by: Hermann.Lauer@iwr.uni-heidelberg.de
>
>Gentle ping for this patch to be included in 4.16

I think maybe I forgot PATCH in title so it didn't enter patchwork?

>
>ChenYu
>
>_______________________________________________
>linux-arm-kernel mailing list
>linux-arm-kernel@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RESEND] phy: sun4i-usb: add support for R40 USB PHY
  2018-01-19  6:25   ` Chen-Yu Tsai
  2018-01-19  6:30     ` Icenowy Zheng
@ 2018-01-19  8:13     ` Kishon Vijay Abraham I
  2018-02-16 11:13       ` Kishon Vijay Abraham I
  1 sibling, 1 reply; 6+ messages in thread
From: Kishon Vijay Abraham I @ 2018-01-19  8:13 UTC (permalink / raw)
  To: Chen-Yu Tsai
  Cc: Icenowy Zheng, Hermann Lauer, devicetree, linux-sunxi,
	linux-kernel, linux-arm-kernel

Hi,

On Friday 19 January 2018 11:55 AM, Chen-Yu Tsai wrote:
> Hi Kishon,
> 
> On Mon, Jan 15, 2018 at 11:06 PM, Hermann Lauer
> <Hermann.Lauer@iwr.uni-heidelberg.de> wrote:
>> On Wed, Jan 03, 2018 at 04:49:44PM +0800, Icenowy Zheng wrote:
>>> Allwinner R40 features a USB PHY like the one in A64, but with 3 PHYs.
>>>
>>> Add support for it.
>>>
>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>>> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>>> Acked-by: Rob Herring <robh@kernel.org>
>>
>> You may add
>>
>> Tested-by: Hermann.Lauer@iwr.uni-heidelberg.de
> 
> Gentle ping for this patch to be included in 4.16

Sent the pull request for 4.16 to Greg on Jan 2nd. So this can't be included in
4.16. Sorry.

Thanks
Kishon

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RESEND] phy: sun4i-usb: add support for R40 USB PHY
  2018-01-19  8:13     ` Kishon Vijay Abraham I
@ 2018-02-16 11:13       ` Kishon Vijay Abraham I
  0 siblings, 0 replies; 6+ messages in thread
From: Kishon Vijay Abraham I @ 2018-02-16 11:13 UTC (permalink / raw)
  To: Chen-Yu Tsai
  Cc: Icenowy Zheng, Hermann Lauer, devicetree, linux-sunxi,
	linux-kernel, linux-arm-kernel



On Friday 19 January 2018 01:43 PM, Kishon Vijay Abraham I wrote:
> Hi,
> 
> On Friday 19 January 2018 11:55 AM, Chen-Yu Tsai wrote:
>> Hi Kishon,
>>
>> On Mon, Jan 15, 2018 at 11:06 PM, Hermann Lauer
>> <Hermann.Lauer@iwr.uni-heidelberg.de> wrote:
>>> On Wed, Jan 03, 2018 at 04:49:44PM +0800, Icenowy Zheng wrote:
>>>> Allwinner R40 features a USB PHY like the one in A64, but with 3 PHYs.
>>>>
>>>> Add support for it.
>>>>
>>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>>>> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>>>> Acked-by: Rob Herring <robh@kernel.org>
>>>
>>> You may add
>>>
>>> Tested-by: Hermann.Lauer@iwr.uni-heidelberg.de
>>
>> Gentle ping for this patch to be included in 4.16
> 
> Sent the pull request for 4.16 to Greg on Jan 2nd. So this can't be included in
> 4.16. Sorry.

merged now, thanks!

-Kishon

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-02-16 11:13 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-03  8:49 [PATCH RESEND] phy: sun4i-usb: add support for R40 USB PHY Icenowy Zheng
2018-01-15 15:06 ` [RESEND] " Hermann Lauer
2018-01-19  6:25   ` Chen-Yu Tsai
2018-01-19  6:30     ` Icenowy Zheng
2018-01-19  8:13     ` Kishon Vijay Abraham I
2018-02-16 11:13       ` Kishon Vijay Abraham I

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).