[PATCH 1/3] ARM: dts: rockchip: drop veyron's nonstandard 'backlight-boot-off'

[PATCH 1/3] ARM: dts: rockchip: drop veyron's nonstandard 'backlight-boot-off'

[Brian Norris]

This was used out-of-tree as a hack for resolving issues where some
systems expect the backlight to turn on automatically at boot, while
others expect to manage the backlight status via a DRM/panel driver.
Those issues have since been fixed upstream in pwm_bl.c without device
tree hacks, and so this un-documented property should no longer be
useful.

Signed-off-by: Brian Norris <briannorris@chromium.org>
---
 arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
index d752a315f884..be487111d025 100644
--- a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
@@ -92,7 +92,6 @@
 			248 249 250 251 252 253 254 255>;
 		default-brightness-level = <128>;
 		enable-gpios = <&gpio7 RK_PA2 GPIO_ACTIVE_HIGH>;
-		backlight-boot-off;
 		pinctrl-names = "default";
 		pinctrl-0 = <&bl_en>;
 		pwms = <&pwm0 0 1000000 0>;
-- 
2.16.0.rc0.223.g4a4ac83678-goog

[PATCH 2/3] ARM: tegra: paz00: drop nonstandard 'backlight-boot-off'

[Brian Norris]

This was used out-of-tree as a hack for resolving issues where some
systems expect the backlight to turn on automatically at boot, while
others expect to manage the backlight status via a DRM/panel driver.
Those issues have since been fixed upstream in pwm_bl.c without device
tree hacks, and so this un-documented property should no longer be
useful.

Signed-off-by: Brian Norris <briannorris@chromium.org>
---
 arch/arm/boot/dts/tegra20-paz00.dts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/tegra20-paz00.dts b/arch/arm/boot/dts/tegra20-paz00.dts
index 30436969adc0..12c63b23ed5e 100644
--- a/arch/arm/boot/dts/tegra20-paz00.dts
+++ b/arch/arm/boot/dts/tegra20-paz00.dts
@@ -504,8 +504,6 @@
 
 		brightness-levels = <0 16 32 48 64 80 96 112 128 144 160 176 192 208 224 240 255>;
 		default-brightness-level = <10>;
-
-		backlight-boot-off;
 	};
 
 	clocks {
-- 
2.16.0.rc0.223.g4a4ac83678-goog

[PATCH 3/3] arm64: tegra: remove tegra132 norrin's nonstandard 'backlight-boot-off'

[Brian Norris]

This was used out-of-tree as a hack for resolving issues where some
systems expect the backlight to turn on automatically at boot, while
others expect to manage the backlight status via a DRM/panel driver.
Those issues have since been fixed upstream in pwm_bl.c without device
tree hacks, and so this un-documented property should no longer be
useful.

Signed-off-by: Brian Norris <briannorris@chromium.org>
---
 arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
index a0385a386a3f..ba2e1b7c198e 100644
--- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
@@ -951,8 +951,6 @@
 
 		brightness-levels = <0 4 8 16 32 64 128 255>;
 		default-brightness-level = <6>;
-
-		backlight-boot-off;
 	};
 
 	clocks {
-- 
2.16.0.rc0.223.g4a4ac83678-goog

Re: [PATCH 2/3] ARM: tegra: paz00: drop nonstandard 'backlight-boot-off'

[Marc Dietrich]

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

Hi,

Am Samstag, 6. Januar 2018, 01:47:56 CET schrieb Brian Norris:
> This was used out-of-tree as a hack for resolving issues where some
> systems expect the backlight to turn on automatically at boot, while
> others expect to manage the backlight status via a DRM/panel driver.
> Those issues have since been fixed upstream in pwm_bl.c without device
> tree hacks, and so this un-documented property should no longer be
> useful.
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>

seems to work again. Thanks!

Reviewed-by: Marc Dietrich <marvin24@gmx.de>

> ---
>  arch/arm/boot/dts/tegra20-paz00.dts | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/tegra20-paz00.dts
> b/arch/arm/boot/dts/tegra20-paz00.dts index 30436969adc0..12c63b23ed5e
> 100644
> --- a/arch/arm/boot/dts/tegra20-paz00.dts
> +++ b/arch/arm/boot/dts/tegra20-paz00.dts
> @@ -504,8 +504,6 @@
> 
>  		brightness-levels = <0 16 32 48 64 80 96 112 128 144 160 176 192 208 224
> 240 255>; default-brightness-level = <10>;
> -
> -		backlight-boot-off;
>  	};
> 
>  	clocks {


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 2/3] ARM: tegra: paz00: drop nonstandard 'backlight-boot-off'

[Brian Norris]

On Wed, Jan 10, 2018 at 12:31:31PM +0100, Marc Dietrich wrote:
> Hi,
> 
> Am Samstag, 6. Januar 2018, 01:47:56 CET schrieb Brian Norris:
> > This was used out-of-tree as a hack for resolving issues where some
> > systems expect the backlight to turn on automatically at boot, while
> > others expect to manage the backlight status via a DRM/panel driver.
> > Those issues have since been fixed upstream in pwm_bl.c without device
> > tree hacks, and so this un-documented property should no longer be
> > useful.
> > 
> > Signed-off-by: Brian Norris <briannorris@chromium.org>
> 
> seems to work again. Thanks!

BTW, I guess I could have put this in the commit message, but the
problem that this out-of-tree property was trying to resolve was fixed
by this (and some other related patches):

d1b812945750 backlight: pwm_bl: Check the PWM state for initial backlight power state

Brian

> Reviewed-by: Marc Dietrich <marvin24@gmx.de>
> 
> > ---
> >  arch/arm/boot/dts/tegra20-paz00.dts | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/tegra20-paz00.dts
> > b/arch/arm/boot/dts/tegra20-paz00.dts index 30436969adc0..12c63b23ed5e
> > 100644
> > --- a/arch/arm/boot/dts/tegra20-paz00.dts
> > +++ b/arch/arm/boot/dts/tegra20-paz00.dts
> > @@ -504,8 +504,6 @@
> > 
> >  		brightness-levels = <0 16 32 48 64 80 96 112 128 144 160 176 192 208 224
> > 240 255>; default-brightness-level = <10>;
> > -
> > -		backlight-boot-off;
> >  	};
> > 
> >  	clocks {
> 

Re: [PATCH 1/3] ARM: dts: rockchip: drop veyron's nonstandard 'backlight-boot-off'

[Heiko Stuebner]

Am Freitag, 5. Januar 2018, 16:47:55 CET schrieb Brian Norris:
> This was used out-of-tree as a hack for resolving issues where some
> systems expect the backlight to turn on automatically at boot, while
> others expect to manage the backlight status via a DRM/panel driver.
> Those issues have since been fixed upstream in pwm_bl.c without device
> tree hacks, and so this un-documented property should no longer be
> useful.
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>

applied (for 4.17 though)


Thanks
Heiko