* [PATCH v2] Staging: iio: cdc: Prefer using BIT macro
@ 2018-01-06 15:05 Sumit Pundir
2018-01-06 15:10 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Sumit Pundir @ 2018-01-06 15:05 UTC (permalink / raw)
To: lars
Cc: Michael.Hennerich, jic23, knaack.h, pmeerw, gregkh, linux-iio,
devel, linux-kernel
This patch fixes the following checkpatch.pl issue at multiple lines:
CHECK: Prefer using the BIT macro
Signed-off-by: Sumit Pundir <pundirsumit11@gmail.com>
---
v2:
Added the specific driver being changed to the patch title
and the appropriate fixes as suggested.
drivers/staging/iio/cdc/ad7152.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
index 59d1b35..19dc896 100644
--- a/drivers/staging/iio/cdc/ad7152.c
+++ b/drivers/staging/iio/cdc/ad7152.c
@@ -47,7 +47,7 @@
#define AD7152_STATUS_PWDN BIT(7)
/* Setup Register Bit Designations (AD7152_REG_CHx_SETUP) */
-#define AD7152_SETUP_CAPDIFF (1 << 5)
+#define AD7152_SETUP_CAPDIFF BIT(5)
#define AD7152_SETUP_RANGE_2pF (0 << 6)
#define AD7152_SETUP_RANGE_0_5pF (1 << 6)
#define AD7152_SETUP_RANGE_1pF (2 << 6)
@@ -55,8 +55,8 @@
#define AD7152_SETUP_RANGE(x) ((x) << 6)
/* Config Register Bit Designations (AD7152_REG_CFG) */
-#define AD7152_CONF_CH2EN (1 << 3)
-#define AD7152_CONF_CH1EN (1 << 4)
+#define AD7152_CONF_CH2EN BIT(3)
+#define AD7152_CONF_CH1EN BIT(4)
#define AD7152_CONF_MODE_IDLE (0 << 0)
#define AD7152_CONF_MODE_CONT_CONV (1 << 0)
#define AD7152_CONF_MODE_SINGLE_CONV (2 << 0)
@@ -64,7 +64,7 @@
#define AD7152_CONF_MODE_GAIN_CAL (6 << 0)
/* Capdac Register Bit Designations (AD7152_REG_CAPDAC_XXX) */
-#define AD7152_CAPDAC_DACEN (1 << 7)
+#define AD7152_CAPDAC_DACEN BIT(7)
#define AD7152_CAPDAC_DACP(x) ((x) & 0x1F)
/* CFG2 Register Bit Designations (AD7152_REG_CFG2) */
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] Staging: iio: cdc: Prefer using BIT macro
2018-01-06 15:05 [PATCH v2] Staging: iio: cdc: Prefer using BIT macro Sumit Pundir
@ 2018-01-06 15:10 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2018-01-06 15:10 UTC (permalink / raw)
To: Sumit Pundir
Cc: lars, Michael.Hennerich, knaack.h, pmeerw, gregkh, linux-iio,
devel, linux-kernel
On Sat, 6 Jan 2018 20:35:24 +0530
Sumit Pundir <pundirsumit11@gmail.com> wrote:
> This patch fixes the following checkpatch.pl issue at multiple lines:
>
> CHECK: Prefer using the BIT macro
>
> Signed-off-by: Sumit Pundir <pundirsumit11@gmail.com>
> ---
> v2:
> Added the specific driver being changed to the patch title
Not that I can see.
Anyhow, never mind I'll fix it whilst applying.
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> and the appropriate fixes as suggested.
>
> drivers/staging/iio/cdc/ad7152.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
> index 59d1b35..19dc896 100644
> --- a/drivers/staging/iio/cdc/ad7152.c
> +++ b/drivers/staging/iio/cdc/ad7152.c
> @@ -47,7 +47,7 @@
> #define AD7152_STATUS_PWDN BIT(7)
>
> /* Setup Register Bit Designations (AD7152_REG_CHx_SETUP) */
> -#define AD7152_SETUP_CAPDIFF (1 << 5)
> +#define AD7152_SETUP_CAPDIFF BIT(5)
> #define AD7152_SETUP_RANGE_2pF (0 << 6)
> #define AD7152_SETUP_RANGE_0_5pF (1 << 6)
> #define AD7152_SETUP_RANGE_1pF (2 << 6)
> @@ -55,8 +55,8 @@
> #define AD7152_SETUP_RANGE(x) ((x) << 6)
>
> /* Config Register Bit Designations (AD7152_REG_CFG) */
> -#define AD7152_CONF_CH2EN (1 << 3)
> -#define AD7152_CONF_CH1EN (1 << 4)
> +#define AD7152_CONF_CH2EN BIT(3)
> +#define AD7152_CONF_CH1EN BIT(4)
> #define AD7152_CONF_MODE_IDLE (0 << 0)
> #define AD7152_CONF_MODE_CONT_CONV (1 << 0)
> #define AD7152_CONF_MODE_SINGLE_CONV (2 << 0)
> @@ -64,7 +64,7 @@
> #define AD7152_CONF_MODE_GAIN_CAL (6 << 0)
>
> /* Capdac Register Bit Designations (AD7152_REG_CAPDAC_XXX) */
> -#define AD7152_CAPDAC_DACEN (1 << 7)
> +#define AD7152_CAPDAC_DACEN BIT(7)
> #define AD7152_CAPDAC_DACP(x) ((x) & 0x1F)
>
> /* CFG2 Register Bit Designations (AD7152_REG_CFG2) */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-06 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-06 15:05 [PATCH v2] Staging: iio: cdc: Prefer using BIT macro Sumit Pundir
2018-01-06 15:10 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).