From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Johan Hovold <johan@kernel.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
stable <stable@vger.kernel.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>
Subject: Re: [PATCH 3/3] Input: 88pm860x-ts: fix child-node lookup
Date: Mon, 8 Jan 2018 17:35:57 -0800 [thread overview]
Message-ID: <20180109013557.geqzv3irrqtha3nt@dtor-ws> (raw)
In-Reply-To: <20171111154339.16875-3-johan@kernel.org>
On Sat, Nov 11, 2017 at 04:43:39PM +0100, Johan Hovold wrote:
> Fix child node-lookup during probe, which ended up searching the whole
> device tree depth-first starting at parent rather than just matching on
> its children.
>
> To make things worse, the parent node was prematurely freed, while the
> child node was leaked.
>
> Fixes: 2e57d56747e6 ("mfd: 88pm860x: Device tree support")
> Cc: stable <stable@vger.kernel.org> # 3.7
> Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Applied, thank you.
> ---
> drivers/input/touchscreen/88pm860x-ts.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/touchscreen/88pm860x-ts.c b/drivers/input/touchscreen/88pm860x-ts.c
> index 7ed828a51f4c..3486d9403805 100644
> --- a/drivers/input/touchscreen/88pm860x-ts.c
> +++ b/drivers/input/touchscreen/88pm860x-ts.c
> @@ -126,7 +126,7 @@ static int pm860x_touch_dt_init(struct platform_device *pdev,
> int data, n, ret;
> if (!np)
> return -ENODEV;
> - np = of_find_node_by_name(np, "touch");
> + np = of_get_child_by_name(np, "touch");
> if (!np) {
> dev_err(&pdev->dev, "Can't find touch node\n");
> return -EINVAL;
> @@ -144,13 +144,13 @@ static int pm860x_touch_dt_init(struct platform_device *pdev,
> if (data) {
> ret = pm860x_reg_write(i2c, PM8607_GPADC_MISC1, data);
> if (ret < 0)
> - return -EINVAL;
> + goto err_put_node;
> }
> /* set tsi prebias time */
> if (!of_property_read_u32(np, "marvell,88pm860x-tsi-prebias", &data)) {
> ret = pm860x_reg_write(i2c, PM8607_TSI_PREBIAS, data);
> if (ret < 0)
> - return -EINVAL;
> + goto err_put_node;
> }
> /* set prebias & prechg time of pen detect */
> data = 0;
> @@ -161,10 +161,18 @@ static int pm860x_touch_dt_init(struct platform_device *pdev,
> if (data) {
> ret = pm860x_reg_write(i2c, PM8607_PD_PREBIAS, data);
> if (ret < 0)
> - return -EINVAL;
> + goto err_put_node;
> }
> of_property_read_u32(np, "marvell,88pm860x-resistor-X", res_x);
> +
> + of_node_put(np);
> +
> return 0;
> +
> +err_put_node:
> + of_node_put(np);
> +
> + return -EINVAL;
> }
> #else
> #define pm860x_touch_dt_init(x, y, z) (-1)
> --
> 2.15.0
>
--
Dmitry
next prev parent reply other threads:[~2018-01-09 1:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-11 15:43 [PATCH 1/3] Input: twl4030-vibra: fix sibling-node lookup Johan Hovold
2017-11-11 15:43 ` [PATCH 2/3] Input: twl6040-vibra: fix child-node lookup Johan Hovold
2017-11-13 7:17 ` Peter Ujfalusi
[not found] ` <91A591C4-D6BD-462D-B81E-224DB268EDDB@goldelico.com>
2017-11-13 9:16 ` Johan Hovold
2017-11-13 14:10 ` Peter Ujfalusi
2017-11-13 14:19 ` Johan Hovold
2017-11-13 14:39 ` H. Nikolaus Schaller
2017-11-13 14:46 ` Johan Hovold
2018-01-09 1:35 ` Dmitry Torokhov
2017-11-11 15:43 ` [PATCH 3/3] Input: 88pm860x-ts: " Johan Hovold
2018-01-09 1:35 ` Dmitry Torokhov [this message]
2017-11-11 17:50 ` [PATCH 1/3] Input: twl4030-vibra: fix sibling-node lookup Dmitry Torokhov
2017-11-12 12:12 ` Johan Hovold
2017-11-13 9:11 ` Lee Jones
2017-11-13 9:35 ` Johan Hovold
2017-11-13 10:20 ` Lee Jones
2017-11-13 11:51 ` Johan Hovold
2017-11-13 21:54 ` Dmitry Torokhov
2017-11-14 10:39 ` Lee Jones
2017-11-13 7:17 ` Peter Ujfalusi
2017-12-11 10:21 ` Johan Hovold
2018-01-08 13:55 ` Johan Hovold
2018-01-09 1:36 ` Dmitry Torokhov
2018-01-09 9:21 ` Johan Hovold
2018-01-09 1:17 ` Dmitry Torokhov
2018-01-09 1:35 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109013557.geqzv3irrqtha3nt@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=johan@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).