From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Johan Hovold <johan@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: <linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>,
"H . Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH 2/3] Input: twl6040-vibra: fix child-node lookup
Date: Mon, 13 Nov 2017 09:17:21 +0200 [thread overview]
Message-ID: <a4020ee9-fbb3-c63e-02a1-c90665f7cf59@ti.com> (raw)
In-Reply-To: <20171111154339.16875-2-johan@kernel.org>
On 2017-11-11 17:43, Johan Hovold wrote:
> Fix child-node lookup during probe, which ended up searching the whole
> device tree depth-first starting at parent rather than just matching on
> its children.
>
> Later sanity checks on node properties (which would likely be missing)
> should prevent this from causing much trouble however, especially as the
> original premature free of the parent node has already been fixed
> separately (but that "fix" was apparently never backported to stable).
>
> Fixes: e7ec014a47e4 ("Input: twl6040-vibra - update for device tree support")
> Fixes: c52c545ead97 ("Input: twl6040-vibra - fix DT node memory management")
> Cc: stable <stable@vger.kernel.org> # 3.6
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Cc: H. Nikolaus Schaller <hns@goldelico.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/input/misc/twl6040-vibra.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/input/misc/twl6040-vibra.c b/drivers/input/misc/twl6040-vibra.c
> index 5690eb7ff954..15e0d352c4cc 100644
> --- a/drivers/input/misc/twl6040-vibra.c
> +++ b/drivers/input/misc/twl6040-vibra.c
> @@ -248,8 +248,7 @@ static int twl6040_vibra_probe(struct platform_device *pdev)
> int vddvibr_uV = 0;
> int error;
>
> - of_node_get(twl6040_core_dev->of_node);
> - twl6040_core_node = of_find_node_by_name(twl6040_core_dev->of_node,
> + twl6040_core_node = of_get_child_by_name(twl6040_core_dev->of_node,
> "vibra");
> if (!twl6040_core_node) {
> dev_err(&pdev->dev, "parent of node is missing?\n");
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2017-11-13 7:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-11 15:43 [PATCH 1/3] Input: twl4030-vibra: fix sibling-node lookup Johan Hovold
2017-11-11 15:43 ` [PATCH 2/3] Input: twl6040-vibra: fix child-node lookup Johan Hovold
2017-11-13 7:17 ` Peter Ujfalusi [this message]
[not found] ` <91A591C4-D6BD-462D-B81E-224DB268EDDB@goldelico.com>
2017-11-13 9:16 ` Johan Hovold
2017-11-13 14:10 ` Peter Ujfalusi
2017-11-13 14:19 ` Johan Hovold
2017-11-13 14:39 ` H. Nikolaus Schaller
2017-11-13 14:46 ` Johan Hovold
2018-01-09 1:35 ` Dmitry Torokhov
2017-11-11 15:43 ` [PATCH 3/3] Input: 88pm860x-ts: " Johan Hovold
2018-01-09 1:35 ` Dmitry Torokhov
2017-11-11 17:50 ` [PATCH 1/3] Input: twl4030-vibra: fix sibling-node lookup Dmitry Torokhov
2017-11-12 12:12 ` Johan Hovold
2017-11-13 9:11 ` Lee Jones
2017-11-13 9:35 ` Johan Hovold
2017-11-13 10:20 ` Lee Jones
2017-11-13 11:51 ` Johan Hovold
2017-11-13 21:54 ` Dmitry Torokhov
2017-11-14 10:39 ` Lee Jones
2017-11-13 7:17 ` Peter Ujfalusi
2017-12-11 10:21 ` Johan Hovold
2018-01-08 13:55 ` Johan Hovold
2018-01-09 1:36 ` Dmitry Torokhov
2018-01-09 9:21 ` Johan Hovold
2018-01-09 1:17 ` Dmitry Torokhov
2018-01-09 1:35 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4020ee9-fbb3-c63e-02a1-c90665f7cf59@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hns@goldelico.com \
--cc=johan@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).