* [RFC PATCH mkp-scsi] scsi: libsas: sas_destruct_ports() can be static
2018-01-09 7:51 [mkp-scsi:for-next 237/263] drivers/scsi/libsas/sas_discover.c:364:6: sparse: symbol 'sas_destruct_ports' was not declared. Should it be static? kbuild test robot
@ 2018-01-09 7:51 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2018-01-09 7:51 UTC (permalink / raw)
To: Jason Yan
Cc: kbuild-all, Martin K. Petersen, Hannes Reinecke,
James E.J. Bottomley, Yijing Wang, linux-scsi, linux-kernel
Fixes: 99cfdc04c12e ("scsi: libsas: direct call probe and destruct")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
sas_discover.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/libsas/sas_discover.c b/drivers/scsi/libsas/sas_discover.c
index 190108e..e4fd078 100644
--- a/drivers/scsi/libsas/sas_discover.c
+++ b/drivers/scsi/libsas/sas_discover.c
@@ -361,7 +361,7 @@ void sas_destruct_devices(struct asd_sas_port *port)
}
}
-void sas_destruct_ports(struct asd_sas_port *port)
+static void sas_destruct_ports(struct asd_sas_port *port)
{
struct sas_port *sas_port, *p;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [mkp-scsi:for-next 237/263] drivers/scsi/libsas/sas_discover.c:364:6: sparse: symbol 'sas_destruct_ports' was not declared. Should it be static?
@ 2018-01-09 7:51 kbuild test robot
2018-01-09 7:51 ` [RFC PATCH mkp-scsi] scsi: libsas: sas_destruct_ports() can be static kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2018-01-09 7:51 UTC (permalink / raw)
To: Jason Yan
Cc: kbuild-all, Martin K. Petersen, Hannes Reinecke,
James E.J. Bottomley, Yijing Wang, linux-scsi, linux-kernel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
head: f7c3d0667404295422c9a5d71fd87ca20c770f49
commit: 99cfdc04c12ea1bc5719bff15f24dae8b5b90da9 [237/263] scsi: libsas: direct call probe and destruct
reproduce:
# apt-get install sparse
git checkout 99cfdc04c12ea1bc5719bff15f24dae8b5b90da9
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/scsi/libsas/sas_discover.c:364:6: sparse: symbol 'sas_destruct_ports' was not declared. Should it be
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-09 7:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-09 7:51 [mkp-scsi:for-next 237/263] drivers/scsi/libsas/sas_discover.c:364:6: sparse: symbol 'sas_destruct_ports' was not declared. Should it be static? kbuild test robot
2018-01-09 7:51 ` [RFC PATCH mkp-scsi] scsi: libsas: sas_destruct_ports() can be static kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).