[PATCH] clk: sunxi-ng: defaultly enable DE2 CCU for sun8i/sun50i

[PATCH] clk: sunxi-ng: defaultly enable DE2 CCU for sun8i/sun50i

[Icenowy Zheng]

As DE2 support for more SoCs are introducing, there's many reports that
the DE2 is not functional due to DE2 CCU code not included in kernel.

Defaultly enable DE2 CCU for sun8i/sun50i to reduce this kind of
problems.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 drivers/clk/sunxi-ng/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig
index 6427d0ebe2de..c2b04dcb6f18 100644
--- a/drivers/clk/sunxi-ng/Kconfig
+++ b/drivers/clk/sunxi-ng/Kconfig
@@ -60,6 +60,8 @@ config SUN8I_V3S_CCU
 
 config SUN8I_DE2_CCU
 	bool "Support for the Allwinner SoCs DE2 CCU"
+	default MACH_SUN8I || (ARM64 && ARCH_SUNXI)
+	depends on MACH_SUN8I || (ARM64 && ARCH_SUNXI) || COMPILE_TEST
 
 config SUN8I_R40_CCU
 	bool "Support for the Allwinner R40 CCU"
-- 
2.14.2

Re: [PATCH] clk: sunxi-ng: defaultly enable DE2 CCU for sun8i/sun50i

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

On Thu, Jan 11, 2018 at 11:04:51AM +0800, Icenowy Zheng wrote:
> As DE2 support for more SoCs are introducing, there's many reports that
> the DE2 is not functional due to DE2 CCU code not included in kernel.
> 
> Defaultly enable DE2 CCU for sun8i/sun50i to reduce this kind of
> problems.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>

One way to avoid this would have been to add the symbol to the sunxi
and multi_v7 defconfigs...

You're also adding a depends on. This should be explained or at least
mentionned in your commit log.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]