* [PATCH] platform/x86: have ACPI_CMPC use depends instead of select for INPUT
@ 2018-01-15 5:11 Randy Dunlap
2018-01-15 20:42 ` Darren Hart
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2018-01-15 5:11 UTC (permalink / raw)
To: Platform Driver, LKML; +Cc: Darren Hart, Andy Shevchenko
From: Randy Dunlap <rdunlap@infradead.org>
Drivers should not 'select' a subsystem. Instead they should depend
on it. If the subsystem is disabled, the user probably did that for
a purpose and one driver shouldn't be changing that.
This also makes all platform/x86/ drivers consistent w.r.t depending on
INPUT instead of selecting it.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Darren Hart <dvhart@infradead.org>
Cc: Andy Shevchenko <andy@infradead.org>
Cc: platform-driver-x86@vger.kernel.org
---
drivers/platform/x86/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- lnx-415-rc8.orig/drivers/platform/x86/Kconfig
+++ lnx-415-rc8/drivers/platform/x86/Kconfig
@@ -812,9 +812,8 @@ config TOSHIBA_WMI
config ACPI_CMPC
tristate "CMPC Laptop Extras"
- depends on ACPI
+ depends on ACPI && INPUT
depends on RFKILL || RFKILL=n
- select INPUT
select BACKLIGHT_CLASS_DEVICE
help
Support for Intel Classmate PC ACPI devices, including some
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: have ACPI_CMPC use depends instead of select for INPUT
2018-01-15 5:11 [PATCH] platform/x86: have ACPI_CMPC use depends instead of select for INPUT Randy Dunlap
@ 2018-01-15 20:42 ` Darren Hart
0 siblings, 0 replies; 2+ messages in thread
From: Darren Hart @ 2018-01-15 20:42 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Platform Driver, LKML, Andy Shevchenko
On Sun, Jan 14, 2018 at 09:11:18PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Drivers should not 'select' a subsystem. Instead they should depend
> on it. If the subsystem is disabled, the user probably did that for
> a purpose and one driver shouldn't be changing that.
>
> This also makes all platform/x86/ drivers consistent w.r.t depending on
> INPUT instead of selecting it.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Darren Hart <dvhart@infradead.org>
> Cc: Andy Shevchenko <andy@infradead.org>
> Cc: platform-driver-x86@vger.kernel.org
Thanks Randy, queued.
--
Darren Hart
VMware Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-15 20:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-15 5:11 [PATCH] platform/x86: have ACPI_CMPC use depends instead of select for INPUT Randy Dunlap
2018-01-15 20:42 ` Darren Hart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).