* [PATCH] cifs: remove redundant duplicated assignment of pointer 'node'
@ 2018-01-17 9:52 Colin King
2018-01-17 23:11 ` Ronnie Sahlberg
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2018-01-17 9:52 UTC (permalink / raw)
To: Steve French, linux-cifs, samba-technical; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Node is assigned twice to rb_first(root), first during declaration
time and second after a taking a spin lock, so we have a duplicated
assignment. Remove the first assignment because it is redundant and
also not protected by the spin lock.
Cleans up clang warning:
fs/cifs/connect.c:4435:18: warning: Value stored to 'node' during
its initialization is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/cifs/connect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 0efd22e75ac7..63c5d85fe25e 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -4432,7 +4432,7 @@ cifs_prune_tlinks(struct work_struct *work)
struct cifs_sb_info *cifs_sb = container_of(work, struct cifs_sb_info,
prune_tlinks.work);
struct rb_root *root = &cifs_sb->tlink_tree;
- struct rb_node *node = rb_first(root);
+ struct rb_node *node;
struct rb_node *tmp;
struct tcon_link *tlink;
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cifs: remove redundant duplicated assignment of pointer 'node'
2018-01-17 9:52 [PATCH] cifs: remove redundant duplicated assignment of pointer 'node' Colin King
@ 2018-01-17 23:11 ` Ronnie Sahlberg
2018-01-18 16:17 ` Steve French
0 siblings, 1 reply; 3+ messages in thread
From: Ronnie Sahlberg @ 2018-01-17 23:11 UTC (permalink / raw)
To: Colin King
Cc: Steve French, linux-cifs, samba-technical, kernel-janitors, linux-kernel
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
----- Original Message -----
From: "Colin King" <colin.king@canonical.com>
To: "Steve French" <sfrench@samba.org>, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Sent: Wednesday, 17 January, 2018 8:52:39 PM
Subject: [PATCH] cifs: remove redundant duplicated assignment of pointer 'node'
From: Colin Ian King <colin.king@canonical.com>
Node is assigned twice to rb_first(root), first during declaration
time and second after a taking a spin lock, so we have a duplicated
assignment. Remove the first assignment because it is redundant and
also not protected by the spin lock.
Cleans up clang warning:
fs/cifs/connect.c:4435:18: warning: Value stored to 'node' during
its initialization is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/cifs/connect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 0efd22e75ac7..63c5d85fe25e 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -4432,7 +4432,7 @@ cifs_prune_tlinks(struct work_struct *work)
struct cifs_sb_info *cifs_sb = container_of(work, struct cifs_sb_info,
prune_tlinks.work);
struct rb_root *root = &cifs_sb->tlink_tree;
- struct rb_node *node = rb_first(root);
+ struct rb_node *node;
struct rb_node *tmp;
struct tcon_link *tlink;
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cifs: remove redundant duplicated assignment of pointer 'node'
2018-01-17 23:11 ` Ronnie Sahlberg
@ 2018-01-18 16:17 ` Steve French
0 siblings, 0 replies; 3+ messages in thread
From: Steve French @ 2018-01-18 16:17 UTC (permalink / raw)
To: Ronnie Sahlberg
Cc: Colin King, Steve French, CIFS, samba-technical, kernel-janitors, LKML
merged into cifs-2.6.git for-next
thx
On Wed, Jan 17, 2018 at 5:11 PM, Ronnie Sahlberg <lsahlber@redhat.com> wrote:
> Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
>
>
> ----- Original Message -----
> From: "Colin King" <colin.king@canonical.com>
> To: "Steve French" <sfrench@samba.org>, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org
> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
> Sent: Wednesday, 17 January, 2018 8:52:39 PM
> Subject: [PATCH] cifs: remove redundant duplicated assignment of pointer 'node'
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Node is assigned twice to rb_first(root), first during declaration
> time and second after a taking a spin lock, so we have a duplicated
> assignment. Remove the first assignment because it is redundant and
> also not protected by the spin lock.
>
> Cleans up clang warning:
> fs/cifs/connect.c:4435:18: warning: Value stored to 'node' during
> its initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> fs/cifs/connect.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 0efd22e75ac7..63c5d85fe25e 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -4432,7 +4432,7 @@ cifs_prune_tlinks(struct work_struct *work)
> struct cifs_sb_info *cifs_sb = container_of(work, struct cifs_sb_info,
> prune_tlinks.work);
> struct rb_root *root = &cifs_sb->tlink_tree;
> - struct rb_node *node = rb_first(root);
> + struct rb_node *node;
> struct rb_node *tmp;
> struct tcon_link *tlink;
>
> --
> 2.15.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-18 16:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-17 9:52 [PATCH] cifs: remove redundant duplicated assignment of pointer 'node' Colin King
2018-01-17 23:11 ` Ronnie Sahlberg
2018-01-18 16:17 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).