* [PATCH] net/mlx5e: Fix trailing semicolon
@ 2018-01-17 12:09 Luis de Bethencourt
2018-01-18 1:35 ` Saeed Mahameed
2018-01-18 21:22 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Luis de Bethencourt @ 2018-01-17 12:09 UTC (permalink / raw)
To: linux-kernel
Cc: Joe Perches, Saeed Mahameed, Matan Barak, Leon Romanovsky,
Erez Shitrit, David S . Miller, Alex Vesker, Feras Daoud, netdev,
linux-rdma, Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards,
Luis
[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c b/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c
index bf9dc4516d2c..3ff81411ae93 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c
@@ -485,7 +485,7 @@ static int mlx5i_close(struct net_device *netdev)
mlx5_fs_remove_rx_underlay_qpn(mdev, ipriv->qp.qpn);
mlx5i_uninit_underlay_qp(epriv);
mlx5e_deactivate_priv_channels(epriv);
- mlx5e_close_channels(&epriv->channels);;
+ mlx5e_close_channels(&epriv->channels);
unlock:
mutex_unlock(&epriv->state_lock);
return 0;
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5e: Fix trailing semicolon
2018-01-17 12:09 [PATCH] net/mlx5e: Fix trailing semicolon Luis de Bethencourt
@ 2018-01-18 1:35 ` Saeed Mahameed
2018-01-18 21:22 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2018-01-18 1:35 UTC (permalink / raw)
To: Luis de Bethencourt, linux-kernel
Cc: Joe Perches, Matan Barak, Leon Romanovsky, Erez Shitrit,
David S . Miller, Alex Vesker, Feras Daoud, netdev, linux-rdma
On 01/17/2018 04:09 AM, Luis de Bethencourt wrote:
> The trailing semicolon is an empty statement that does no operation.
> Removing it since it doesn't do anything.
>
> Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
Looks Good, Thanks Luis.
Reviewed-by: Saeed Mahameed <saeedm@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5e: Fix trailing semicolon
2018-01-17 12:09 [PATCH] net/mlx5e: Fix trailing semicolon Luis de Bethencourt
2018-01-18 1:35 ` Saeed Mahameed
@ 2018-01-18 21:22 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-01-18 21:22 UTC (permalink / raw)
To: luisbg
Cc: linux-kernel, joe, saeedm, matanb, leonro, erezsh, valex,
ferasda, netdev, linux-rdma
From: Luis de Bethencourt <luisbg@kernel.org>
Date: Wed, 17 Jan 2018 12:09:15 +0000
> The trailing semicolon is an empty statement that does no operation.
> Removing it since it doesn't do anything.
>
> Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
Applied to net-next, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-18 21:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-17 12:09 [PATCH] net/mlx5e: Fix trailing semicolon Luis de Bethencourt
2018-01-18 1:35 ` Saeed Mahameed
2018-01-18 21:22 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).