From: Chao Fan <fanc.fnst@cn.fujitsu.com>
To: Baoquan He <bhe@redhat.com>
Cc: <linux-kernel@vger.kernel.org>, <x86@kernel.org>, <hpa@zytor.com>,
<tglx@linutronix.de>, <mingo@redhat.com>, <keescook@chromium.org>,
<yasu.isimatu@gmail.com>, <indou.takao@jp.fujitsu.com>,
<lcapitulino@redhat.com>
Subject: Re: [PATCH v7 3/5] x86/KASLR: Give a warning if movable_node specified without kaslr_mem=
Date: Thu, 18 Jan 2018 09:20:01 +0800 [thread overview]
Message-ID: <20180118012001.GC24593@localhost.localdomain> (raw)
In-Reply-To: <20180117140248.GG2321@localhost.localdomain>
On Wed, Jan 17, 2018 at 10:02:48PM +0800, Baoquan He wrote:
>On 01/17/18 at 06:53pm, Chao Fan wrote:
>> Since only 'movable_node' specified without 'kaslr_mem=' may break
>> memory hotplug, so reconmmend users using 'kaslr_mem=' when
>> 'movable_node' specified..
>>
>> Signed-off-by: Chao Fan <fanc.fnst@cn.fujitsu.com>
>> ---
>> arch/x86/boot/compressed/kaslr.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
>> index b200a7ceafc1..dca846b522fc 100644
>> --- a/arch/x86/boot/compressed/kaslr.c
>> +++ b/arch/x86/boot/compressed/kaslr.c
>> @@ -282,6 +282,16 @@ static int handle_mem_filter(void)
>> !strstr(args, "kaslr_mem="))
>> return 0;
>>
>> +#ifdef CONFIG_MEMORY_HOTPLUG
>> + /*
>> + * Check if "kaslr_mem=" specified when "movable_node" found. If not,
>> + * just give warrning. Otherwise memory hotplug could be
>> + * affected if kernel put on movable memory regions.
>> + */
>> + if (strstr(args, "movable_node") && !strstr(args, "kaslr_mem="))
>> + warn("kaslr_mem= should specified when using movable_node.\n");
> 'kaslr_mem=' ^be
You have given me a large help for my poor English.
Thanks,
Chao Fan
>> +#endif
>> +
>> tmp_cmdline = malloc(len + 1);
>> if (!tmp_cmdline)
>> error("Failed to allocate space for tmp_cmdline");
>> --
>> 2.14.3
>>
>>
>>
>
>
next prev parent reply other threads:[~2018-01-18 1:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 10:53 [PATCH v7 0/5] x86/KASLR: Add parameter kaslr_mem=nn[KMG]@ss[KMG] Chao Fan
2018-01-17 10:53 ` [PATCH v7 1/5] x86/KASLR: Add kaslr_mem=nn[KMG]@ss[KMG] Chao Fan
2018-01-19 2:34 ` Baoquan He
2018-01-17 10:53 ` [PATCH v7 2/5] x86/KASLR: Handle the memory regions specified in kaslr_mem Chao Fan
2018-01-19 2:39 ` Baoquan He
2018-01-17 10:53 ` [PATCH v7 3/5] x86/KASLR: Give a warning if movable_node specified without kaslr_mem= Chao Fan
2018-01-17 14:02 ` Baoquan He
2018-01-18 1:20 ` Chao Fan [this message]
2018-01-17 14:04 ` Baoquan He
2018-01-19 3:31 ` [PATCH v8 " Chao Fan
2018-01-19 3:48 ` Baoquan He
2018-01-17 10:53 ` [PATCH v7 4/5] x86/KASLR: Skip memory mirror handling if movable_node specified Chao Fan
2018-01-17 14:03 ` Baoquan He
2018-01-18 1:13 ` Chao Fan
2018-01-19 3:33 ` [PATCH v8 " Chao Fan
2018-01-19 3:47 ` Baoquan He
2018-01-17 10:53 ` [PATCH v7 5/5] document: add document for kaslr_mem Chao Fan
2018-01-19 3:00 ` Baoquan He
2018-01-19 3:36 ` [PATCH v8 " Chao Fan
2018-01-19 3:53 ` Baoquan He
2018-01-19 5:27 ` Chao Fan
2018-01-19 5:23 ` [RESEND PATCH " Chao Fan
2018-01-19 18:20 ` Randy Dunlap
2018-01-17 17:32 ` [PATCH v7 0/5] x86/KASLR: Add parameter kaslr_mem=nn[KMG]@ss[KMG] Luiz Capitulino
2018-01-18 1:11 ` Chao Fan
2018-01-18 13:39 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118012001.GC24593@localhost.localdomain \
--to=fanc.fnst@cn.fujitsu.com \
--cc=bhe@redhat.com \
--cc=hpa@zytor.com \
--cc=indou.takao@jp.fujitsu.com \
--cc=keescook@chromium.org \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).