* [PATCH -next] mtd: onenand: omap2: Remove redundant dev_err call in omap2_onenand_probe()
@ 2018-01-17 11:25 Wei Yongjun
2018-01-20 13:49 ` Boris Brezillon
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2018-01-17 11:25 UTC (permalink / raw)
To: Kyungmin Park, David Woodhouse, Brian Norris, Boris Brezillon,
Marek Vasut, Richard Weinberger, Cyrille Pitchen
Cc: Wei Yongjun, linux-mtd, linux-kernel, kernel-janitors
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/mtd/onenand/omap2.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
index a4a2159..87c34f6 100644
--- a/drivers/mtd/onenand/omap2.c
+++ b/drivers/mtd/onenand/omap2.c
@@ -532,10 +532,8 @@ static int omap2_onenand_probe(struct platform_device *pdev)
c->phys_base = res->start;
c->onenand.base = devm_ioremap_resource(dev, res);
- if (IS_ERR(c->onenand.base)) {
- dev_err(dev, "Cannot reserve memory region %pR\n", res);
+ if (IS_ERR(c->onenand.base))
return PTR_ERR(c->onenand.base);
- }
c->int_gpiod = devm_gpiod_get_optional(dev, "int", GPIOD_IN);
if (IS_ERR(c->int_gpiod)) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] mtd: onenand: omap2: Remove redundant dev_err call in omap2_onenand_probe()
2018-01-17 11:25 [PATCH -next] mtd: onenand: omap2: Remove redundant dev_err call in omap2_onenand_probe() Wei Yongjun
@ 2018-01-20 13:49 ` Boris Brezillon
0 siblings, 0 replies; 2+ messages in thread
From: Boris Brezillon @ 2018-01-20 13:49 UTC (permalink / raw)
To: Wei Yongjun
Cc: Kyungmin Park, David Woodhouse, Brian Norris, Marek Vasut,
Richard Weinberger, Cyrille Pitchen, linux-mtd, linux-kernel,
kernel-janitors
On Wed, 17 Jan 2018 11:25:33 +0000
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
Applied.
Thanks,
Boris
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/mtd/onenand/omap2.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
> index a4a2159..87c34f6 100644
> --- a/drivers/mtd/onenand/omap2.c
> +++ b/drivers/mtd/onenand/omap2.c
> @@ -532,10 +532,8 @@ static int omap2_onenand_probe(struct platform_device *pdev)
> c->phys_base = res->start;
>
> c->onenand.base = devm_ioremap_resource(dev, res);
> - if (IS_ERR(c->onenand.base)) {
> - dev_err(dev, "Cannot reserve memory region %pR\n", res);
> + if (IS_ERR(c->onenand.base))
> return PTR_ERR(c->onenand.base);
> - }
>
> c->int_gpiod = devm_gpiod_get_optional(dev, "int", GPIOD_IN);
> if (IS_ERR(c->int_gpiod)) {
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-20 13:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-17 11:25 [PATCH -next] mtd: onenand: omap2: Remove redundant dev_err call in omap2_onenand_probe() Wei Yongjun
2018-01-20 13:49 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).