Re: [PATCH] cpufreq: mediatek: Add mediatek related projects into blacklist

Re: [PATCH] cpufreq: mediatek: Add mediatek related projects into blacklist

[Greg KH]

On Tue, Jan 23, 2018 at 04:31:11PM +0800, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
> 
> commit 6066998cbd2b1012a8d5bc9a2957cfd0ad53150e upstream.
> 
> commit edeec420de24 ("cpufreq: dt-platdev: Automatically create cpufreq
> device with OPP v2") not added MediaTek SoCs to the blacklist that would
> lead to cause an occasional hang or unexpected behaviors on related boards
> as kernelci reported and complained on [1] specifically for 4.14 and 4.15
> tree.
> 
> For those reasons, add MediaTek SoCs into cpufreq-dt blacklist and wish
> the patch be applied to 4.14 and 4.15 tree to allow kernelci able to
> complete following automated kernel testing.
> 
> [1] https://kernelci.org/boot/mt7623n-bananapi-bpi-r2/
> 
> Fixes: edeec420de24 (cpufreq: dt-cpufreq: platdev Automatically create device with OPP v2)
> Signed-off-by: Andrew-sh Cheng <andrew-sh.cheng@mediatek.com>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> Cc: Kevin Hilman <khilman@baylibre.com>
> ---
>  drivers/cpufreq/cpufreq-dt-platdev.c | 8 ++++++++
>  1 file changed, 8 insertions(+)

What stable kernel tree(s) are you wanting this backported to?

thanks,

greg k-h

Re: [PATCH] cpufreq: mediatek: Add mediatek related projects into blacklist

[Sean Wang]

On Tue, 2018-01-23 at 09:46 +0100, Greg KH wrote:
> On Tue, Jan 23, 2018 at 04:31:11PM +0800, sean.wang@mediatek.com wrote:
> > From: Sean Wang <sean.wang@mediatek.com>
> > 
> > commit 6066998cbd2b1012a8d5bc9a2957cfd0ad53150e upstream.
> > 
> > commit edeec420de24 ("cpufreq: dt-platdev: Automatically create cpufreq
> > device with OPP v2") not added MediaTek SoCs to the blacklist that would
> > lead to cause an occasional hang or unexpected behaviors on related boards
> > as kernelci reported and complained on [1] specifically for 4.14 and 4.15
> > tree.
> > 
> > For those reasons, add MediaTek SoCs into cpufreq-dt blacklist and wish
> > the patch be applied to 4.14 and 4.15 tree to allow kernelci able to
> > complete following automated kernel testing.
> > 
> > [1] https://kernelci.org/boot/mt7623n-bananapi-bpi-r2/
> > 
> > Fixes: edeec420de24 (cpufreq: dt-cpufreq: platdev Automatically create device with OPP v2)
> > Signed-off-by: Andrew-sh Cheng <andrew-sh.cheng@mediatek.com>
> > Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> > Cc: Kevin Hilman <khilman@baylibre.com>
> > ---
> >  drivers/cpufreq/cpufreq-dt-platdev.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> 
> What stable kernel tree(s) are you wanting this backported to?
> 
> thanks,
> 
> greg k-h

Hi, Greg,

thanks for your help!

stable and stable-rc are those trees I want this backported to 

Hi, Viresh

currently, can the patch be permitted to go through tree linux-pm branch
master to be part of mainline? 

	Sean

Re: [PATCH] cpufreq: mediatek: Add mediatek related projects into blacklist

[Greg KH]

On Tue, Jan 23, 2018 at 05:38:34PM +0800, Sean Wang wrote:
> On Tue, 2018-01-23 at 09:46 +0100, Greg KH wrote:
> > On Tue, Jan 23, 2018 at 04:31:11PM +0800, sean.wang@mediatek.com wrote:
> > > From: Sean Wang <sean.wang@mediatek.com>
> > > 
> > > commit 6066998cbd2b1012a8d5bc9a2957cfd0ad53150e upstream.
> > > 
> > > commit edeec420de24 ("cpufreq: dt-platdev: Automatically create cpufreq
> > > device with OPP v2") not added MediaTek SoCs to the blacklist that would
> > > lead to cause an occasional hang or unexpected behaviors on related boards
> > > as kernelci reported and complained on [1] specifically for 4.14 and 4.15
> > > tree.
> > > 
> > > For those reasons, add MediaTek SoCs into cpufreq-dt blacklist and wish
> > > the patch be applied to 4.14 and 4.15 tree to allow kernelci able to
> > > complete following automated kernel testing.
> > > 
> > > [1] https://kernelci.org/boot/mt7623n-bananapi-bpi-r2/
> > > 
> > > Fixes: edeec420de24 (cpufreq: dt-cpufreq: platdev Automatically create device with OPP v2)
> > > Signed-off-by: Andrew-sh Cheng <andrew-sh.cheng@mediatek.com>
> > > Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> > > Cc: Kevin Hilman <khilman@baylibre.com>
> > > ---
> > >  drivers/cpufreq/cpufreq-dt-platdev.c | 8 ++++++++
> > >  1 file changed, 8 insertions(+)
> > 
> > What stable kernel tree(s) are you wanting this backported to?
> > 
> > thanks,
> > 
> > greg k-h
> 
> Hi, Greg,
> 
> thanks for your help!
> 
> stable and stable-rc are those trees I want this backported to 

I don't understand, what exactly do you mean by this?

Have you read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly?

> Hi, Viresh
> 
> currently, can the patch be permitted to go through tree linux-pm branch
> master to be part of mainline? 

Wait, this is not in Linus's tree already?  If not, what is that big
"commit XXXX upstream" in the changelog for?

I don't see that commit in Linus's tree at all.

totally confused,

greg k-h

Re: [PATCH] cpufreq: mediatek: Add mediatek related projects into blacklist

[Sean Wang]

On Tue, 2018-01-23 at 10:42 +0100, Greg KH wrote:
> On Tue, Jan 23, 2018 at 05:38:34PM +0800, Sean Wang wrote:
> > On Tue, 2018-01-23 at 09:46 +0100, Greg KH wrote:
> > > On Tue, Jan 23, 2018 at 04:31:11PM +0800, sean.wang@mediatek.com wrote:
> > > > From: Sean Wang <sean.wang@mediatek.com>
> > > > 
> > > > commit 6066998cbd2b1012a8d5bc9a2957cfd0ad53150e upstream.
> > > > 
> > > > commit edeec420de24 ("cpufreq: dt-platdev: Automatically create cpufreq
> > > > device with OPP v2") not added MediaTek SoCs to the blacklist that would
> > > > lead to cause an occasional hang or unexpected behaviors on related boards
> > > > as kernelci reported and complained on [1] specifically for 4.14 and 4.15
> > > > tree.
> > > > 
> > > > For those reasons, add MediaTek SoCs into cpufreq-dt blacklist and wish
> > > > the patch be applied to 4.14 and 4.15 tree to allow kernelci able to
> > > > complete following automated kernel testing.
> > > > 
> > > > [1] https://kernelci.org/boot/mt7623n-bananapi-bpi-r2/
> > > > 
> > > > Fixes: edeec420de24 (cpufreq: dt-cpufreq: platdev Automatically create device with OPP v2)
> > > > Signed-off-by: Andrew-sh Cheng <andrew-sh.cheng@mediatek.com>
> > > > Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> > > > Cc: Kevin Hilman <khilman@baylibre.com>
> > > > ---
> > > >  drivers/cpufreq/cpufreq-dt-platdev.c | 8 ++++++++
> > > >  1 file changed, 8 insertions(+)
> > > 
> > > What stable kernel tree(s) are you wanting this backported to?
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > Hi, Greg,
> > 
> > thanks for your help!
> > 
> > stable and stable-rc are those trees I want this backported to 
> 
> I don't understand, what exactly do you mean by this?
> 
> Have you read:
>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly?
> 
> > Hi, Viresh
> > 
> > currently, can the patch be permitted to go through tree linux-pm branch
> > master to be part of mainline? 
> 
> Wait, this is not in Linus's tree already?  If not, what is that big
> "commit XXXX upstream" in the changelog for?
> 
> I don't see that commit in Linus's tree at all.
> 
> totally confused,
> 
> greg k-h


Hi Greg,

thanks for your instructions

Sorry for that I missed one thing: The patch is currently not in Linus
tree, but it is already in linux-next tree. So, I will wait until the
patch ends up in Linus's tree and submit again to wish the patch be
applied into 4.14.y tree or 4.15.y tree in the near future.

	Sean

Re: [PATCH] cpufreq: mediatek: Add mediatek related projects into blacklist

[Viresh Kumar]

On 23-01-18, 17:38, Sean Wang wrote:
> currently, can the patch be permitted to go through tree linux-pm branch
> master to be part of mainline? 

As you already said it is in pm/linux-next. It will get merged in 4.16-rc1.

-- 
viresh

[PATCH] cpufreq: mediatek: Add mediatek related projects into blacklist

[sean.wang]

From: Sean Wang <sean.wang@mediatek.com>

commit 6066998cbd2b1012a8d5bc9a2957cfd0ad53150e upstream.

Please apply 6066998cbd2b1012a8d5bc9a2957cfd0ad53150e to 4.14.y and 4.15.y

commit edeec420de24 ("cpufreq: dt-platdev: Automatically create cpufreq
device with OPP v2") not added MediaTek SoCs to the blacklist that would
lead to cause an occasional hang or unexpected behaviors on related boards
as kernelci reported and complained on [1] specifically for 4.14 and 4.15
tree. For those reasons, add MediaTek SoCs into cpufreq-dt blacklist.

[1] https://kernelci.org/boot/mt7623n-bananapi-bpi-r2/

Fixes: edeec420de24 (cpufreq: dt-cpufreq: platdev Automatically create device with OPP v2)
Signed-off-by: Andrew-sh Cheng <andrew-sh.cheng@mediatek.com>
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Cc: Kevin Hilman <khilman@baylibre.com>
---
 drivers/cpufreq/cpufreq-dt-platdev.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index a753c50..9e0aa76 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -111,6 +111,14 @@ static const struct of_device_id blacklist[] __initconst = {
 
 	{ .compatible = "marvell,armadaxp", },
 
+	{ .compatible = "mediatek,mt2701", },
+	{ .compatible = "mediatek,mt2712", },
+	{ .compatible = "mediatek,mt7622", },
+	{ .compatible = "mediatek,mt7623", },
+	{ .compatible = "mediatek,mt817x", },
+	{ .compatible = "mediatek,mt8173", },
+	{ .compatible = "mediatek,mt8176", },
+
 	{ .compatible = "nvidia,tegra124", },
 
 	{ .compatible = "st,stih407", },
-- 
2.7.4