From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Eric Auger <eric.auger@redhat.com>,
eric.auger.pro@gmail.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, okaya@codeaurora.org
Subject: Re: [PATCH v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a module
Date: Wed, 24 Jan 2018 08:27:25 +0200 [thread overview]
Message-ID: <20180124062725.GK27654@lahna.fi.intel.com> (raw)
In-Reply-To: <20180124055615.c3qwhwnj7spmcr3w@ninjato>
On Wed, Jan 24, 2018 at 06:56:16AM +0100, Wolfram Sang wrote:
> On Wed, Jan 03, 2018 at 03:02:31PM +0100, Eric Auger wrote:
> > If I2C is built as a module, ACPI_I2C_OPREGION cannot be set
> > and any ACPI opregion calls targeting I2C fail with no opregion found.
> >
> > This patch allows ACPI_I2C_OPREGION to be enabled both if I2C is
> > built into the kernel or built as a module.
> >
> > Signed-off-by: Eric Auger <eric.auger@redhat.com>
>
> I recall that we had some discussion until ending up with the current
> solution. And I finally found it again:
>
> http://www.serverphorums.com/read.php?12,1001402
>
> In any case, I surely want Mika's ack on any change to ACPI related
> Kconfig symbols. Adding him to CC...
So the problem is/was that what happens if you are in a middle of BIOS
AML code touching the opregion and someone unloads the opregion handler?
If you can quarantee nothing bad happens, then I'm fine with the patch :)
next prev parent reply other threads:[~2018-01-24 6:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 14:02 [PATCH v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a module Eric Auger
2018-01-08 16:22 ` Sinan Kaya
2018-01-24 5:56 ` Wolfram Sang
2018-01-24 6:27 ` Mika Westerberg [this message]
2018-01-24 13:29 ` Sinan Kaya
2018-01-24 14:24 ` Mika Westerberg
2018-01-24 14:44 ` Andy Shevchenko
2018-01-24 14:59 ` Hans de Goede
2018-01-24 15:12 ` Sinan Kaya
2018-01-24 15:23 ` Hans de Goede
2018-01-24 15:37 ` Sinan Kaya
2018-01-24 16:09 ` Hans de Goede
2018-01-24 16:10 ` Sinan Kaya
2018-01-24 16:56 ` Auger Eric
2018-01-24 14:46 ` Andy Shevchenko
2018-01-24 14:49 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124062725.GK27654@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).