From: Hans de Goede <hdegoede@redhat.com>
To: Sinan Kaya <okaya@codeaurora.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>,
Eric Auger <eric.auger@redhat.com>,
eric.auger.pro@gmail.com, linux-i2c <linux-i2c@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a module
Date: Wed, 24 Jan 2018 16:23:50 +0100 [thread overview]
Message-ID: <26d6761c-17c9-73d8-42d6-25815b58bc87@redhat.com> (raw)
In-Reply-To: <f918bbf3-1f9a-df63-9906-7147620ee6cf@codeaurora.org>
Hi,
On 24-01-18 16:12, Sinan Kaya wrote:
> On 1/24/2018 9:59 AM, Hans de Goede wrote:
>> TL;DR: I have to NAK this, I'm sorry but with the current state of ACPI we
>> must simply have some stuff builtin to help with probe-ordering issues. Now
>> if the ACPI code where ever to honor the _DEP method everywhere instead of
>> only for battery devices this might change, but even then things will still
>> be tricky.
>
> Well, the alternative is even worse.
No it is not, if I2C gets builtin things work fine, you proposal does not
fix anything, it merely gives the illusion of being builtin
> Redhat and most other distros configure I2C as a module.
Fedora has stopped building I2C as a module a long time ago already and where
Fedora goes RHEL typically follows.
> With this setup,
> I2C OpRegion support does not get compiled. It doesn't even work let alone to have
> race conditions.
So at least it is consistent then, which makes for a lot easier debugging.
> I2C OpRegion feature is practically dead for most general users unless you recompile
> your own kernel.
Then talk to various distro kernel maintainers and ask them to
set CONFIG_I2C=y.
> There must be a middle ground somewhere.
One thing which comes to mind is to simply not allow building i2c as a module
when ACPI is selected, something like this should work I think:
config I2C
tristate "I2C support"
select RT_MUTEXES
select IRQ_DOMAIN
+ # force building I2C in on ACPI systems, for opregion availability
+ depends on y || !ACPI
> I had some conversation with Rafael about _DEP support. He is not a big fan :)
Ok.
Regards,
Hans
next prev parent reply other threads:[~2018-01-24 15:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 14:02 [PATCH v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a module Eric Auger
2018-01-08 16:22 ` Sinan Kaya
2018-01-24 5:56 ` Wolfram Sang
2018-01-24 6:27 ` Mika Westerberg
2018-01-24 13:29 ` Sinan Kaya
2018-01-24 14:24 ` Mika Westerberg
2018-01-24 14:44 ` Andy Shevchenko
2018-01-24 14:59 ` Hans de Goede
2018-01-24 15:12 ` Sinan Kaya
2018-01-24 15:23 ` Hans de Goede [this message]
2018-01-24 15:37 ` Sinan Kaya
2018-01-24 16:09 ` Hans de Goede
2018-01-24 16:10 ` Sinan Kaya
2018-01-24 16:56 ` Auger Eric
2018-01-24 14:46 ` Andy Shevchenko
2018-01-24 14:49 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26d6761c-17c9-73d8-42d6-25815b58bc87@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy.shevchenko@gmail.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=okaya@codeaurora.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).