* [PATCH] i2c: meson: update doc description to fix build warnings
@ 2018-01-24 7:05 Yixun Lan
2018-01-26 17:34 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Yixun Lan @ 2018-01-24 7:05 UTC (permalink / raw)
To: Wolfram Sang
Cc: Neil Armstrong, Jerome Brunet, Carlo Caione, Kevin Hilman,
Yixun Lan, linux-i2c, linux-amlogic, linux-arm-kernel,
linux-kernel
Add description for 'data' parameter and drop unused 'irq' memeber.
Here is the warnings:
drivers/i2c/busses/i2c-meson.c:103: warning: No description found for
parameter 'data'
drivers/i2c/busses/i2c-meson.c:103: warning: Excess struct member 'irq'
description in 'meson_i2c'
Suggested-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
---
drivers/i2c/busses/i2c-meson.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c
index 37c4aa76f37a..90f5d0407d73 100644
--- a/drivers/i2c/busses/i2c-meson.c
+++ b/drivers/i2c/busses/i2c-meson.c
@@ -69,7 +69,6 @@ struct meson_i2c_data {
* @dev: Pointer to device structure
* @regs: Base address of the device memory mapped registers
* @clk: Pointer to clock structure
- * @irq: IRQ number
* @msg: Pointer to the current I2C message
* @state: Current state in the driver state machine
* @last: Flag set for the last message in the transfer
@@ -80,6 +79,7 @@ struct meson_i2c_data {
* @done: Completion used to wait for transfer termination
* @tokens: Sequence of tokens to be written to the device
* @num_tokens: Number of tokens
+ * @data: Pointer to the controlller's platform data
*/
struct meson_i2c {
struct i2c_adapter adap;
--
2.15.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c: meson: update doc description to fix build warnings
2018-01-24 7:05 [PATCH] i2c: meson: update doc description to fix build warnings Yixun Lan
@ 2018-01-26 17:34 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2018-01-26 17:34 UTC (permalink / raw)
To: Yixun Lan
Cc: Neil Armstrong, Jerome Brunet, Carlo Caione, Kevin Hilman,
linux-i2c, linux-amlogic, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
On Wed, Jan 24, 2018 at 03:05:14PM +0800, Yixun Lan wrote:
> Add description for 'data' parameter and drop unused 'irq' memeber.
>
> Here is the warnings:
> drivers/i2c/busses/i2c-meson.c:103: warning: No description found for
> parameter 'data'
> drivers/i2c/busses/i2c-meson.c:103: warning: Excess struct member 'irq'
> description in 'meson_i2c'
>
> Suggested-by: Wolfram Sang <wsa@the-dreams.de>
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-26 17:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-24 7:05 [PATCH] i2c: meson: update doc description to fix build warnings Yixun Lan
2018-01-26 17:34 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).