* [PATCH] vxfs: fix building with LTO
@ 2018-02-02 15:47 Arnd Bergmann
2018-02-02 18:10 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-02-02 15:47 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Arnd Bergmann, linux-kernel
When link-time optimizations are enabled, vxfs fails to build:
fs/freevxfs/vxfs_lookup.c: In function 'vxfs_readdir':
fs/freevxfs/vxfs_subr.c:50:1: error: inlining failed in call to always_inline 'vxfs_put_page': function not declared inline and code size would grow
vxfs_put_page(struct page *pp)
^
fs/freevxfs/vxfs_lookup.c:291:3: note: called from here
vxfs_put_page(pp);
^
fs/freevxfs/vxfs_inode.c: In function '__vxfs_iget':
fs/freevxfs/vxfs_subr.c:50:1: error: inlining failed in call to always_inline 'vxfs_put_page': function not declared inline and code size would grow
fs/freevxfs/vxfs_lookup.c: In function 'vxfs_lookup':
fs/freevxfs/vxfs_subr.c:50:1: error: inlining failed in call to always_inline 'vxfs_put_page': function not declared inline and code size would grow
This removes the 'inline' annotation that obviously doesn't do much
anyway.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/freevxfs/vxfs_subr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/freevxfs/vxfs_subr.c b/fs/freevxfs/vxfs_subr.c
index e806694d4145..8e213cce586f 100644
--- a/fs/freevxfs/vxfs_subr.c
+++ b/fs/freevxfs/vxfs_subr.c
@@ -46,7 +46,7 @@ const struct address_space_operations vxfs_aops = {
.bmap = vxfs_bmap,
};
-inline void
+void
vxfs_put_page(struct page *pp)
{
kunmap(pp);
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vxfs: fix building with LTO
2018-02-02 15:47 [PATCH] vxfs: fix building with LTO Arnd Bergmann
@ 2018-02-02 18:10 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2018-02-02 18:10 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Christoph Hellwig, linux-kernel
Looks fine to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-02 18:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-02 15:47 [PATCH] vxfs: fix building with LTO Arnd Bergmann
2018-02-02 18:10 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).