* [BUG] drivers/input/misc/pcap: a possible sleep-in-atomic bug in pcap_keys_handler
@ 2017-12-12 8:32 Jia-Ju Bai
2018-02-05 23:25 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Jia-Ju Bai @ 2017-12-12 8:32 UTC (permalink / raw)
To: dmitry.torokhov, ilya.muromec; +Cc: linux-input, linux-kernel
According to drivers/input/misc/pcap_keys.c, the kernel module may sleep
in the interrupt handler.
The function call path is:
pcap_keys_handler (interrupt handler)
ezx_pcap_read
mutex_lock --> may sleep
I do not find a good way to fix it, so I only report.
This possible bug is found by my static analysis tool (DSAC) and checked
by my code review.
Thanks,
Jia-Ju Bai
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [BUG] drivers/input/misc/pcap: a possible sleep-in-atomic bug in pcap_keys_handler
2017-12-12 8:32 [BUG] drivers/input/misc/pcap: a possible sleep-in-atomic bug in pcap_keys_handler Jia-Ju Bai
@ 2018-02-05 23:25 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2018-02-05 23:25 UTC (permalink / raw)
To: Jia-Ju Bai, Daniel Ribeiro; +Cc: ilya.muromec, linux-input, linux-kernel
On Tue, Dec 12, 2017 at 04:32:01PM +0800, Jia-Ju Bai wrote:
> According to drivers/input/misc/pcap_keys.c, the kernel module may sleep in
> the interrupt handler.
> The function call path is:
> pcap_keys_handler (interrupt handler)
> ezx_pcap_read
> mutex_lock --> may sleep
>
> I do not find a good way to fix it, so I only report.
> This possible bug is found by my static analysis tool (DSAC) and checked by
> my code review.
Let's see if Daniel's email still work. I am not sure how it worked to
begin with, given that we've been taking that mutex since very
beginning, and pcap_isr_work() disables local interrupts...
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-05 23:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-12 8:32 [BUG] drivers/input/misc/pcap: a possible sleep-in-atomic bug in pcap_keys_handler Jia-Ju Bai
2018-02-05 23:25 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).