* [PATCH] powerpc/via-pmu: Fix section mismatch warning
@ 2018-02-07 19:44 Mathieu Malaterre
2018-02-13 18:54 ` Laurent Vivier
2018-02-14 21:15 ` [PATCH v2] " Mathieu Malaterre
0 siblings, 2 replies; 6+ messages in thread
From: Mathieu Malaterre @ 2018-02-07 19:44 UTC (permalink / raw)
To: Michael Ellerman
Cc: Mathieu Malaterre, Benjamin Herrenschmidt, linuxppc-dev, linux-kernel
Remove the __init annotation from pmu_init() to avoid the
following warning.
WARNING: vmlinux.o(.data+0x4739c): Section mismatch in reference from the variable via_pmu_driver to the function .init.text:pmu_init()
The variable via_pmu_driver references
the function __init pmu_init()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
drivers/macintosh/via-pmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
index 08849e33c567..5f378272d5b2 100644
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c
@@ -378,7 +378,7 @@ static int pmu_probe(void)
return vias == NULL? -ENODEV: 0;
}
-static int __init pmu_init(void)
+static int pmu_init(void)
{
if (vias == NULL)
return -ENODEV;
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc/via-pmu: Fix section mismatch warning
2018-02-07 19:44 [PATCH] powerpc/via-pmu: Fix section mismatch warning Mathieu Malaterre
@ 2018-02-13 18:54 ` Laurent Vivier
2018-02-14 21:16 ` Mathieu Malaterre
2018-02-14 21:15 ` [PATCH v2] " Mathieu Malaterre
1 sibling, 1 reply; 6+ messages in thread
From: Laurent Vivier @ 2018-02-13 18:54 UTC (permalink / raw)
To: Mathieu Malaterre, Michael Ellerman; +Cc: linuxppc-dev, linux-kernel
On 07/02/2018 20:44, Mathieu Malaterre wrote:
> Remove the __init annotation from pmu_init() to avoid the
> following warning.
>
> WARNING: vmlinux.o(.data+0x4739c): Section mismatch in reference from the variable via_pmu_driver to the function .init.text:pmu_init()
> The variable via_pmu_driver references
> the function __init pmu_init()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> drivers/macintosh/via-pmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
> index 08849e33c567..5f378272d5b2 100644
> --- a/drivers/macintosh/via-pmu.c
> +++ b/drivers/macintosh/via-pmu.c
> @@ -378,7 +378,7 @@ static int pmu_probe(void)
> return vias == NULL? -ENODEV: 0;
> }
>
> -static int __init pmu_init(void)
> +static int pmu_init(void)
> {
> if (vias == NULL)
> return -ENODEV;
>
pmu_init() is really an init function only called by another init
function (adb_init()).
So I think it could be good to let the __init marker.
Did you try:
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c
@@ -198,7 +198,7 @@ static const struct file_operations
pmu_battery_proc_fops;
static const struct file_operations pmu_options_proc_fops;
#ifdef CONFIG_ADB
-struct adb_driver via_pmu_driver = {
+const struct adb_driver via_pmu_driver = {
"PMU",
pmu_probe,
pmu_init,
Thanks,
Laurent
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] powerpc/via-pmu: Fix section mismatch warning
2018-02-07 19:44 [PATCH] powerpc/via-pmu: Fix section mismatch warning Mathieu Malaterre
2018-02-13 18:54 ` Laurent Vivier
@ 2018-02-14 21:15 ` Mathieu Malaterre
2018-02-15 10:35 ` Laurent Vivier
2018-03-14 9:27 ` [v2] " Michael Ellerman
1 sibling, 2 replies; 6+ messages in thread
From: Mathieu Malaterre @ 2018-02-14 21:15 UTC (permalink / raw)
To: Michael Ellerman
Cc: Laurent Vivier, Mathieu Malaterre, Benjamin Herrenschmidt,
linuxppc-dev, linux-kernel
Make the struct via_pmu_driver const to avoid following warning:
WARNING: vmlinux.o(.data+0x4739c): Section mismatch in reference from the variable via_pmu_driver to the function .init.text:pmu_init()
The variable via_pmu_driver references
the function __init pmu_init()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
Signed-off-by: Mathieu Malaterre <malat@debian.org>
Suggested-by: Laurent Vivier <lvivier@redhat.com>
---
v2: pmu_init() is really an init function, leave __init marker
drivers/macintosh/via-pmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
index 94c0f3f7df69..fc56c7067732 100644
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c
@@ -198,7 +198,7 @@ static const struct file_operations pmu_battery_proc_fops;
static const struct file_operations pmu_options_proc_fops;
#ifdef CONFIG_ADB
-struct adb_driver via_pmu_driver = {
+const struct adb_driver via_pmu_driver = {
"PMU",
pmu_probe,
pmu_init,
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc/via-pmu: Fix section mismatch warning
2018-02-13 18:54 ` Laurent Vivier
@ 2018-02-14 21:16 ` Mathieu Malaterre
0 siblings, 0 replies; 6+ messages in thread
From: Mathieu Malaterre @ 2018-02-14 21:16 UTC (permalink / raw)
To: Laurent Vivier; +Cc: Michael Ellerman, linuxppc-dev, LKML
On Tue, Feb 13, 2018 at 7:54 PM, Laurent Vivier <lvivier@redhat.com> wrote:
> On 07/02/2018 20:44, Mathieu Malaterre wrote:
>> Remove the __init annotation from pmu_init() to avoid the
>> following warning.
>>
>> WARNING: vmlinux.o(.data+0x4739c): Section mismatch in reference from the variable via_pmu_driver to the function .init.text:pmu_init()
>> The variable via_pmu_driver references
>> the function __init pmu_init()
>> If the reference is valid then annotate the
>> variable with __init* or __refdata (see linux/init.h) or name the variable:
>> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
>>
>> Signed-off-by: Mathieu Malaterre <malat@debian.org>
>> ---
>> drivers/macintosh/via-pmu.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
>> index 08849e33c567..5f378272d5b2 100644
>> --- a/drivers/macintosh/via-pmu.c
>> +++ b/drivers/macintosh/via-pmu.c
>> @@ -378,7 +378,7 @@ static int pmu_probe(void)
>> return vias == NULL? -ENODEV: 0;
>> }
>>
>> -static int __init pmu_init(void)
>> +static int pmu_init(void)
>> {
>> if (vias == NULL)
>> return -ENODEV;
>>
>
> pmu_init() is really an init function only called by another init
> function (adb_init()).
>
> So I think it could be good to let the __init marker.
>
> Did you try:
>
> --- a/drivers/macintosh/via-pmu.c
> +++ b/drivers/macintosh/via-pmu.c
> @@ -198,7 +198,7 @@ static const struct file_operations
> pmu_battery_proc_fops;
> static const struct file_operations pmu_options_proc_fops;
>
> #ifdef CONFIG_ADB
> -struct adb_driver via_pmu_driver = {
> +const struct adb_driver via_pmu_driver = {
> "PMU",
> pmu_probe,
> pmu_init,
>
>
Indeed much better !
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] powerpc/via-pmu: Fix section mismatch warning
2018-02-14 21:15 ` [PATCH v2] " Mathieu Malaterre
@ 2018-02-15 10:35 ` Laurent Vivier
2018-03-14 9:27 ` [v2] " Michael Ellerman
1 sibling, 0 replies; 6+ messages in thread
From: Laurent Vivier @ 2018-02-15 10:35 UTC (permalink / raw)
To: Mathieu Malaterre, Michael Ellerman
Cc: Benjamin Herrenschmidt, linuxppc-dev, linux-kernel
On 14/02/2018 22:15, Mathieu Malaterre wrote:
> Make the struct via_pmu_driver const to avoid following warning:
>
> WARNING: vmlinux.o(.data+0x4739c): Section mismatch in reference from the variable via_pmu_driver to the function .init.text:pmu_init()
> The variable via_pmu_driver references
> the function __init pmu_init()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> Suggested-by: Laurent Vivier <lvivier@redhat.com>
> ---
> v2: pmu_init() is really an init function, leave __init marker
>
> drivers/macintosh/via-pmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
> index 94c0f3f7df69..fc56c7067732 100644
> --- a/drivers/macintosh/via-pmu.c
> +++ b/drivers/macintosh/via-pmu.c
> @@ -198,7 +198,7 @@ static const struct file_operations pmu_battery_proc_fops;
> static const struct file_operations pmu_options_proc_fops;
>
> #ifdef CONFIG_ADB
> -struct adb_driver via_pmu_driver = {
> +const struct adb_driver via_pmu_driver = {
> "PMU",
> pmu_probe,
> pmu_init,
>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [v2] powerpc/via-pmu: Fix section mismatch warning
2018-02-14 21:15 ` [PATCH v2] " Mathieu Malaterre
2018-02-15 10:35 ` Laurent Vivier
@ 2018-03-14 9:27 ` Michael Ellerman
1 sibling, 0 replies; 6+ messages in thread
From: Michael Ellerman @ 2018-03-14 9:27 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Laurent Vivier, Mathieu Malaterre, linuxppc-dev, linux-kernel
On Wed, 2018-02-14 at 21:15:18 UTC, Mathieu Malaterre wrote:
> Make the struct via_pmu_driver const to avoid following warning:
>
> WARNING: vmlinux.o(.data+0x4739c): Section mismatch in reference from the variable via_pmu_driver to the function .init.text:pmu_init()
> The variable via_pmu_driver references
> the function __init pmu_init()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> Suggested-by: Laurent Vivier <lvivier@redhat.com>
> Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/58935176ad17976b7a7f6ea25c0ceb
cheers
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-03-14 9:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-07 19:44 [PATCH] powerpc/via-pmu: Fix section mismatch warning Mathieu Malaterre
2018-02-13 18:54 ` Laurent Vivier
2018-02-14 21:16 ` Mathieu Malaterre
2018-02-14 21:15 ` [PATCH v2] " Mathieu Malaterre
2018-02-15 10:35 ` Laurent Vivier
2018-03-14 9:27 ` [v2] " Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).