* [PATCH] platform/x86: dell-laptop: Removed duplicates in DMI whitelist
@ 2018-02-07 22:12 Alexander Abrosimov
2018-02-08 14:20 ` Andy Shevchenko
2018-02-08 16:52 ` Pali Rohár
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Abrosimov @ 2018-02-07 22:12 UTC (permalink / raw)
To: Matthew Garrett, Pali Rohár, Darren Hart, Andy Shevchenko,
Mario Limonciello
Cc: platform-driver-x86, linux-kernel, Alexander Abrosimov
Fixed a mistake in which several entries were duplicated in the DMI list
from the below commit
fe486138 platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist
Signed-off-by: Alexander Abrosimov <alexander.n.abrosimov@gmail.com>
---
drivers/platform/x86/dell-laptop.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index a7b141992cb3..a66a6a6e47b9 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -125,28 +125,10 @@ static const struct dmi_system_id dell_device_table[] __initconst = {
DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
},
},
{
- .matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
- DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
- },
- },
- {
- .matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
- DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
- },
- },
- {
- .matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
- DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
- },
- },
- {
.ident = "Dell Computer Corporation",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
DMI_MATCH(DMI_CHASSIS_TYPE, "8"),
},
--
2.13.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: dell-laptop: Removed duplicates in DMI whitelist
2018-02-07 22:12 [PATCH] platform/x86: dell-laptop: Removed duplicates in DMI whitelist Alexander Abrosimov
@ 2018-02-08 14:20 ` Andy Shevchenko
2018-02-08 16:52 ` Pali Rohár
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2018-02-08 14:20 UTC (permalink / raw)
To: Alexander Abrosimov
Cc: Matthew Garrett, Pali Rohár, Darren Hart, Andy Shevchenko,
Mario Limonciello, Platform Driver, Linux Kernel Mailing List
On Thu, Feb 8, 2018 at 12:12 AM, Alexander Abrosimov
<alexander.n.abrosimov@gmail.com> wrote:
> Fixed a mistake in which several entries were duplicated in the DMI list
> from the below commit
> fe486138 platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist
>
Pushed to my review and testing queue, thanks!
(Would be material for v4.17 cycle)
> Signed-off-by: Alexander Abrosimov <alexander.n.abrosimov@gmail.com>
> ---
> drivers/platform/x86/dell-laptop.c | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index a7b141992cb3..a66a6a6e47b9 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -125,28 +125,10 @@ static const struct dmi_system_id dell_device_table[] __initconst = {
> DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
> },
> },
> {
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> - DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
> - },
> - },
> - {
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> - DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
> - },
> - },
> - {
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> - DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
> - },
> - },
> - {
> .ident = "Dell Computer Corporation",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
> DMI_MATCH(DMI_CHASSIS_TYPE, "8"),
> },
> --
> 2.13.6
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: dell-laptop: Removed duplicates in DMI whitelist
2018-02-07 22:12 [PATCH] platform/x86: dell-laptop: Removed duplicates in DMI whitelist Alexander Abrosimov
2018-02-08 14:20 ` Andy Shevchenko
@ 2018-02-08 16:52 ` Pali Rohár
1 sibling, 0 replies; 3+ messages in thread
From: Pali Rohár @ 2018-02-08 16:52 UTC (permalink / raw)
To: Alexander Abrosimov
Cc: Matthew Garrett, Darren Hart, Andy Shevchenko, Mario Limonciello,
platform-driver-x86, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]
On Thursday 08 February 2018 01:12:26 Alexander Abrosimov wrote:
> Fixed a mistake in which several entries were duplicated in the DMI list
> from the below commit
> fe486138 platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist
>
> Signed-off-by: Alexander Abrosimov <alexander.n.abrosimov@gmail.com>
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
> ---
> drivers/platform/x86/dell-laptop.c | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index a7b141992cb3..a66a6a6e47b9 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -125,28 +125,10 @@ static const struct dmi_system_id dell_device_table[] __initconst = {
> DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
> },
> },
> {
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> - DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
> - },
> - },
> - {
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> - DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
> - },
> - },
> - {
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> - DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
> - },
> - },
> - {
> .ident = "Dell Computer Corporation",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
> DMI_MATCH(DMI_CHASSIS_TYPE, "8"),
> },
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-08 16:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-07 22:12 [PATCH] platform/x86: dell-laptop: Removed duplicates in DMI whitelist Alexander Abrosimov
2018-02-08 14:20 ` Andy Shevchenko
2018-02-08 16:52 ` Pali Rohár
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).